From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 08 04:53:32 2022 Received: (at 40641) by debbugs.gnu.org; 8 Jul 2022 08:53:32 +0000 Received: from localhost ([127.0.0.1]:58775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9jjw-0000qc-Dr for submit@debbugs.gnu.org; Fri, 08 Jul 2022 04:53:32 -0400 Received: from relay.yourmailgateway.de ([188.68.61.102]:36469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9jjs-0000qO-WF for 40641@debbugs.gnu.org; Fri, 08 Jul 2022 04:53:31 -0400 Received: from mors-relay-8403.netcup.net (localhost [127.0.0.1]) by mors-relay-8403.netcup.net (Postfix) with ESMTPS id 4LfRrl4Fngz80CR; Fri, 8 Jul 2022 10:53:27 +0200 (CEST) Authentication-Results: mors-relay-8403.netcup.net; dkim=permerror (bad message/signature format) Received: from policy02-mors.netcup.net (unknown [46.38.225.53]) by mors-relay-8403.netcup.net (Postfix) with ESMTPS id 4LfRrl3tKVz80CQ; Fri, 8 Jul 2022 10:53:27 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at policy02-mors.netcup.net X-Spam-Flag: NO X-Spam-Score: -2.899 X-Spam-Level: X-Spam-Status: No, score=-2.899 required=6.31 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no Received: from mxe217.netcup.net (unknown [10.243.12.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by policy02-mors.netcup.net (Postfix) with ESMTPS id 4LfRrj21SXz8sb1; Fri, 8 Jul 2022 10:53:25 +0200 (CEST) Received: from florianrock64 (ip5b40552a.dynamic.kabel-deutschland.de [91.64.85.42]) by mxe217.netcup.net (Postfix) with ESMTPSA id 9A6DB8291C; Fri, 8 Jul 2022 10:53:22 +0200 (CEST) From: "pelzflorian (Florian Pelz)" To: Maxim Cournoyer Subject: Re: bug#40641: Building from git breaks when /bin/sh isn't bash References: <2O2NKRGHD2OZD.30CKDJBOP4LE3@wilsonb.com> <20200415122149.j7b6bcgvrp5cpq5l@pelzflorian.localdomain> <38M8QJ1PDKHCI.2ZBQF20W9BE03@wilsonb.com> <87h74tgxui.fsf@gmail.com> <20220613144005.gv2j5igdmisnaiqv@pelzflorian.localdomain> <874k0nfcq6.fsf@gmail.com> <2N3KLAV9USDUO.2FGVQNI398LFY@"@WILSONB.COM> <20220621090254.kyskzwkliku53mob@pelzflorian.localdomain> <62c2cd89.1c69fb81.7ad72.92c8SMTPIN_ADDED_BROKEN@mx.google.com> <87edywvbdz.fsf@gmail.com> Date: Fri, 08 Jul 2022 10:53:21 +0200 In-Reply-To: <87edywvbdz.fsf@gmail.com> (Maxim Cournoyer's message of "Thu, 07 Jul 2022 17:52:24 -0400") Message-ID: <878rp4c7em.fsf@pelzflorian.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-NC-CID: 8lqXCD3C//hJrSAnMyKx0p/BDHk8vu1zQ8I7RBUyMMTsUTf1F/lceXEO X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 40641 Cc: 40641@debbugs.gnu.org, elaexuotee@wilsonb.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Wait wait Maxim, the discussion was that "B. Wilson" proposed > [PATCH] build: Let make use its hard-coded default shell > To: guix-patches@gnu.org > > * configure.ac: Set AM_SUBST_NOTMAKE([SHELL]) > +# Use make's hard-coded default shell. The make in a guix profile > +# defaults to the Right Thing, e.g. $GUIX_ENVIRONMENT/bin/sh > +AM_SUBST_NOTMAKE([SHELL]) =20 Then Maxim Cournoyer writes: > This seems odd to me. Perhaps it'd be cleaner to detect which shell is > used at configure time to detect when /bin/sh !=3D Bash, and warn that if > there are issues, the user should set the SHELL variable to Bash. elaexuotee@wilsonb.com writes: > Excellent. I agree it's probably not worth POSIXifying the scripts. Forci= ng > make to default to guix's bash seems like the right approach IMHO, so +1 = for > that fix. I think we=E2=80=99re not on the same page. Is AM_SUBST_NOTMAKE([SHELL]) r= eally problematic? Is seems like there is a legitimate use-case that foreign distro users with /bin/sh =3D dash would want =E2=80=9Cguix shell -D guix -= - make=E2=80=9D to just work without workaround? We could use elaexuotee=E2=80=99s AM_SUBST_NOTMAKE([SHELL]) patch, could we not? Regards, Florian