http-parser 2.9.4 fails to build on armhf-linux

  • Done
  • quality assurance status badge
Details
3 participants
  • Marius Bakke
  • Tobias Geerinckx-Rice
  • Ricardo Wurmus
Owner
unassigned
Submitted by
Marius Bakke
Severity
normal
M
M
Marius Bakke wrote on 13 Apr 2020 20:16
(address . bug-guix@gnu.org)
87sgh7i74k.fsf@devup.no
The update to http-parser in 62f7f0d636d3b3ff796263ab892ebf53263539fa
causes a test failure armhf-linux:

Toggle snippet (17 lines)
starting phase `check'
gcc -I. -DHTTP_PARSER_STRICT=1 -Wall -Wextra -Werror -O0 -g -c http_parser.c -o http_parser_g.o
gcc -I. -DHTTP_PARSER_STRICT=1 -Wall -Wextra -Werror -O0 -g -c test.c -o test_g.o
gcc -I. -DHTTP_PARSER_STRICT=0 -Wall -Wextra -Werror -O3 -c http_parser.c
gcc -I. -DHTTP_PARSER_STRICT=0 -Wall -Wextra -Werror -O3 -c test.c -o test.o
gcc -shared -Wl,-soname=libhttp_parser.so.2.9 -o libhttp_parser.so.2.9.4 libhttp_parser.o
gcc -Wall -Wextra -Werror -O0 -g http_parser_g.o test_g.o -o test_g
gcc -Wall -Wextra -Werror -O3 http_parser.o test.o -o test_fast
./test_g
test_g: test.c:4237: main: Assertion `sizeof(http_parser) == 4 + 4 + 8 + 2 + 2 + 4 + sizeof(void *)' failed.
make: *** [Makefile:76: test] Aborted

Test suite failed, dumping logs.
command "make" "test" "-j" "4" "PREFIX=/gnu/store/qlis9jzgcdk1m48hjdzag6gij244cwvz-http-parser-2.9.4" "CC=gcc" "library" failed with status 2
builder for `/gnu/store/gzywh6bmn10ip49yklmiagsjfcr2jflf-http-parser-2.9.4.drv' failed with exit code 1

The assert is new in 2.9.4 (one of two commits since 2.9.3):


I can't tell what causes the size difference on armhf and don't
currently have access to hardware or QEMU for testing. Any takers?

Meanwhile I've reverted the commit on 'master' as this is a dependency
of libgit2 which is needed for 'guix pull'.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6UrGsACgkQoqBt8qM6
VPqnnggArlTnC2uF3+kvWsngxnJs+coakzp4OAfDGBTRj2bVXouJmR9PxcB0L1qb
oh+CnK3vxo5q41/h8kHp7AnX/SaCRfsAeMeYkCU9KbDrmpDkrr/G/+aNZbrbqF8b
hqQX7iGBd6pL4RFfiycMMCCniXjj41ryYVzroBXwsYZFuZ0WltBAhrVpP8ES/A1/
+J3Nde/WkxmUpykFrHQpNtvyO7oaSmT0uYoGlgdMpQUUYC7uCuG05v0uEf6+Cc37
beX+XvVrHqFI6vopDTomuuFr4XeZ1V1yyFQmy3bf+8cRZJRTMGxh4bogAKcWGyfg
eNViZ9R8dSP0keuXThS1qKnCTaBuSA==
=0aNZ
-----END PGP SIGNATURE-----

T
T
Tobias Geerinckx-Rice wrote on 13 Apr 2020 20:25
(address . 40604@debbugs.gnu.org)
87h7xnmedo.fsf@nckx
Marius,

Marius Bakke ???
Toggle quote (4 lines)
> The update to http-parser in
> 62f7f0d636d3b3ff796263ab892ebf53263539fa
> causes a test failure armhf-linux:

[…]

Toggle quote (4 lines)
> Meanwhile I've reverted the commit on 'master' as this is a
> dependency
> of libgit2 which is needed for 'guix pull'.

Thank you!

Toggle quote (4 lines)
> I can't tell what causes the size difference on armhf and don't
> currently have access to hardware or QEMU for testing. Any
> takers?

No access to Qemu? That's no fun.

I'm going to punt: debugging an arch I know nothing about is an
inefficient of time. I only waste my time efficiently.

Kind regards,

T G-R
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl6UrrMACgkQ2Imw8BjF
STzaKBAAjQh7uC1zF8b+wseLdh9W6EBU0GM66AjsktAmIZBxLasSlcPbLoYKv2xH
FYqOtIh2Ohq2tAJyzon9YYHeI5eiAqkRrrSgziZGrjdVQua+feCvz76HtWK/q+In
yW+Xpal4F4MvADZkiey1p8dW1eWx5Ai+VEc+AjSvtYYa+QwyxKdFNMeMdkAEuzzd
uYIPQlsT3ncO0Cl+scblWmStnLmvbLZPSDBAY54F9OK6Lc299eXJBJAKaU0kWpTg
EUCqqgGVf0J4xx7WXS8k9L9HyLZYiwg7GtgqDri6dN3wzosRCmqU3cpJKaRf/fYG
SlyHjTXtca2MY2wIGE13EvXr0uDHXYZwrOmWsnutL+XkWoeV4Se978mhnRjrvn/Q
zsK7BcHcck/jgPUH4V8SIYM2s/RTRH67zzLflRe7amB190MB/MLR8pGiHYz+eN9u
vDaSkwb3MFZX7RQJOdDEeN4Kvemrbe0rqWBd+94gzwUQQft8fwXVhEmSowkV1Jd1
45PTYsB5ESxuFymQaZ5HHoPQYf3/b97jtUTaDD9WjBOLurEg3orNLMdOXJBpsO1t
emDZ/LTt09qeeK1ofx+acJDYTYmG8a+N7BWBVidNFijXXpM/bjz9uz3IW89Qlrwf
znbbZe+VKiJ75A7G4RMB3U+MbQjRDB429zjlyPDxR5gBNjKa6zo=
=7sBq
-----END PGP SIGNATURE-----

R
R
Ricardo Wurmus wrote on 21 May 2020 12:53
(name . Marius Bakke)(address . mbakke@fastmail.com)(address . 40604@debbugs.gnu.org)
87eerdeezz.fsf@elephly.net
Marius Bakke <mbakke@fastmail.com> writes:

Toggle quote (3 lines)
> The update to http-parser in 62f7f0d636d3b3ff796263ab892ebf53263539fa
> causes a test failure armhf-linux:

The same test failure happens on i686-linux.

--
Ricardo
R
R
Ricardo Wurmus wrote on 21 May 2020 12:54
(name . Marius Bakke)(address . mbakke@fastmail.com)(address . 40604@debbugs.gnu.org)
87blmheewx.fsf@elephly.net
Ricardo Wurmus <rekado@elephly.net> writes:

Toggle quote (7 lines)
> Marius Bakke <mbakke@fastmail.com> writes:
>
>> The update to http-parser in 62f7f0d636d3b3ff796263ab892ebf53263539fa
>> causes a test failure armhf-linux:
>
> The same test failure happens on i686-linux.

Actually, this might be a different failure:

test_g: test.c:4240: main: Assertion `sizeof(http_parser) == 32' failed.

This prevents me from running “guix pull” on my i686 machines.

--
Ricardo
T
T
Tobias Geerinckx-Rice wrote on 21 May 2020 16:45
(name . Ricardo Wurmus)(address . rekado@elephly.net)
87o8qhpcry.fsf@nckx
Ricardo, Marius,

Ricardo Wurmus ???
Toggle quote (13 lines)
>> Marius Bakke <mbakke@fastmail.com> writes:
>>
>>> The update to http-parser in
>>> 62f7f0d636d3b3ff796263ab892ebf53263539fa
>>> causes a test failure armhf-linux:
>>
>> The same test failure happens on i686-linux.
>
> Actually, this might be a different failure:
>
> test_g: test.c:4240: main: Assertion `sizeof(http_parser) ==
> 32' failed.

Neither, or both, or whatever. It's the fix for the armhf failure
(5c30eb61) that in turn causes a failure on i686 because there the
struct *is* a mere 28 bytes.

Fixed in f2de892b375d30ad79502509a47a15f0f4d68fee by applying the
fix only on armhf.

Kind regards,

T G-R
-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXsaUEQAKCRANsP+IT1Vt
eQywAP9VHlX6B3c7uU2qJq09k9Nt43Y0tlX56D0bs5uvFTbR/gD+M1o0B1N++Kt4
g0YMpLhk/HzEEHhtyXl/C1tlHEFu6wc=
=Lgbt
-----END PGP SIGNATURE-----

R
R
Ricardo Wurmus wrote on 21 May 2020 22:07
(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)
875zcpdpbm.fsf@elephly.net
Tobias Geerinckx-Rice <me@tobias.gr> writes:

Toggle quote (23 lines)
> Ricardo, Marius,
>
> Ricardo Wurmus ???
>>> Marius Bakke <mbakke@fastmail.com> writes:
>>>
>>>> The update to http-parser in
>>>> 62f7f0d636d3b3ff796263ab892ebf53263539fa
>>>> causes a test failure armhf-linux:
>>>
>>> The same test failure happens on i686-linux.
>>
>> Actually, this might be a different failure:
>>
>> test_g: test.c:4240: main: Assertion `sizeof(http_parser) ==
>> 32' failed.
>
> Neither, or both, or whatever. It's the fix for the armhf failure
> (5c30eb61) that in turn causes a failure on i686 because there the
> struct *is* a mere 28 bytes.
>
> Fixed in f2de892b375d30ad79502509a47a15f0f4d68fee by applying the fix
> only on armhf.

Thank you! That got me past “guix pull” on my i686-linux netbook.

--
Ricardo
Closed
?