From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 18 06:38:11 2020 Received: (at 40601) by debbugs.gnu.org; 18 Dec 2020 11:38:11 +0000 Received: from localhost ([127.0.0.1]:37859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqE5G-0000Qf-2r for submit@debbugs.gnu.org; Fri, 18 Dec 2020 06:38:10 -0500 Received: from mira.cbaines.net ([212.71.252.8]:56862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqE5E-0000QX-5C for 40601@debbugs.gnu.org; Fri, 18 Dec 2020 06:38:04 -0500 Received: from localhost (188.30.130.172.threembb.co.uk [188.30.130.172]) by mira.cbaines.net (Postfix) with ESMTPSA id 408FA27BC05; Fri, 18 Dec 2020 11:38:03 +0000 (GMT) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 2ac9e710; Fri, 18 Dec 2020 11:38:00 +0000 (UTC) References: <20200531204257.18725-1-vincent.legoll@gmail.com> <20200531204257.18725-7-vincent.legoll@gmail.com> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines To: Vincent Legoll Subject: Re: [bug#40601] [PATCH 7/7] guix-install.sh: Add missing variable quoting & curly-bracketing in guix_get_bin(). In-reply-to: <20200531204257.18725-7-vincent.legoll@gmail.com> Date: Fri, 18 Dec 2020 11:37:58 +0000 Message-ID: <87y2hv1h0p.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 40601 Cc: 40601@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Vincent Legoll writes: > * etc/guix-install.sh (guix_get_bin)[dl_path]: Add missing variable quoti= ng and > curly-bracketing, [_PROGRESS_OPT]: Likewise. > --- > etc/guix-install.sh | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/etc/guix-install.sh b/etc/guix-install.sh > index 7d635c2c38..f0d4a38838 100755 > --- a/etc/guix-install.sh > +++ b/etc/guix-install.sh > @@ -239,7 +239,8 @@ guix_get_bin() >=20=20 > wget --help | grep -q '\--show-progress' && \ > _PROGRESS_OPT=3D"-q --show-progress" || _PROGRESS_OPT=3D"" > - wget $_PROGRESS_OPT -P "$dl_path" "${url}/${bin_ver}.tar.xz" "${url}= /${bin_ver}.tar.xz.sig" > + wget "${_PROGRESS_OPT}" -P "${dl_path}" "${url}/${bin_ver}.tar.xz" \ > + "${url}/${bin_ver}.tar.xz.sig" I believe the variable quoting here will break the wget command in the case where _PROGRESS_OPT=3D"-q --show-progress" =E2=86=92 wget "-q --show-progress" https://guix.gnu.org/ wget: invalid option -- ' ' wget: invalid option -- '-' wget: invalid option -- '-' wget: invalid option -- 's' Usage: wget [OPTION]... [URL]... Try `wget --help' for more options. > if [[ "$?" -eq 0 ]]; then > _msg "${PAS}download completed." > @@ -248,7 +249,7 @@ guix_get_bin() > exit 1 > fi >=20=20 > - pushd $dl_path >/dev/null > + pushd "${dl_path}" >/dev/null > gpg --verify "${bin_ver}.tar.xz.sig" >/dev/null 2>&1 > if [[ "$?" -eq 0 ]]; then > _msg "${PAS}Signature is valid." --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl/clJZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xe4TQ//Srwr7acXBMAxOAFzJNYuemblqUfvzB81 /zuJidLQ/LSc2Usx8icn5l4CUKnLpY8d1jSWSVQ+kQJykSdAsB7kTbz5/bAzeFpx r6TYCtxqQZgSIPMIlEsb4H2WKCllQpxXhRkSwSn7/Gp2zGIi8z/GHnqyatgnWMqG i66lLshZv+3b1v5T6ppNPezkcDQ71sRykNwjanU2LJcizMgIwjfjVnCP/HHMAuxZ xlYcWsHUoAo9BReZyOewE3eri+Gp/mmF3xyHCUyN0fDJWTZOwFmKZkrpoUelc0dP mmBXaWZrEFGf7+1t6Hg1Gmf6xZusbDZkVErVg1kh+mnxaAwnoSXzquVa6CiUKo9H RpQX9ZjtLZXzvF1zR6gnwu3HCzAKAYakz/+rCXjWoZKzLaF5tDKdg05Z1gFFLzB5 aRZaqoXgURX1W+mZ+RO/xw+pST4JmNg5GquWu2Dhe3+eHUxvBf9mkztfsEs1d+HV nR0rtYQCAfvkc3Kj6RzqWukOAyCX2848yt3Oop0X/frwnExJOOk5qvRmSvHtKyst yS3bT9tAkGN2sW4npnTn5MdFvOOOpBnBDaDGsRoPoj9jeGCkokMo6+8nHIFVYZLt 8uoLgYhVRtSjjzQUHMHXpOwfRitijGLAq1JGoA3WoGlZtetBj6gAjBlQaObseOnK 4xdb+ZcFX/M= =afVT -----END PGP SIGNATURE----- --=-=-=--