From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 07 15:09:49 2020 Received: (at 40468) by debbugs.gnu.org; 7 Apr 2020 19:09:49 +0000 Received: from localhost ([127.0.0.1]:50877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jLtbY-00082E-U3 for submit@debbugs.gnu.org; Tue, 07 Apr 2020 15:09:49 -0400 Received: from mout01.posteo.de ([185.67.36.141]:46504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jLtbU-00081w-UC for 40468@debbugs.gnu.org; Tue, 07 Apr 2020 15:09:47 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 6EA1116005F for <40468@debbugs.gnu.org>; Tue, 7 Apr 2020 21:09:38 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 48xcR45gp3z6tmH; Tue, 7 Apr 2020 21:09:36 +0200 (CEST) Message-ID: <224c908df7cf2e32dff2bd31e5050dd4d552093a.camel@zrythm.org> Subject: Re: [bug#40468] [PATCH 3/3] gnu: Add shiru-lv2. From: Alexandros Theodotou To: Leo Famulari Date: Tue, 07 Apr 2020 20:09:31 +0100 In-Reply-To: <20200407182511.GA9039@jasmine.lan> References: <053db596207697e4b7d32b55a965b2ba88beca75.camel@zrythm.org> <20200407182511.GA9039@jasmine.lan> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-VFrxbcFNlOBWzXncsjjh" User-Agent: Evolution 3.32.4 MIME-Version: 1.0 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 40468 Cc: 40468@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-VFrxbcFNlOBWzXncsjjh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Leo, > package/inherit is for special cases related to grafting and > replacement > packages. [0] Thank you, I initially thought it was just a shorthand. > Is the idea that there is some build > complication common to the LV2 plugins that we don't want to copy > around? Maybe we could make a build system for them. > > Does it work to inherit the custom install phase from dragonfly- > reverb? > It seems like the install-file procedures would not apply here. Plugins that use the DISTRHO plugin framework ( https://github.com/DISTRHO/DPF) use the same build/install procedure, unless the author makes changes to the Makefiles (like in the case of the zam-plugins package). Dragonfly reverb and shiru plugins both use DPF as-is, so the build/install procedures are exactly the same - built plugins will be produced inside "bin" as binaries, lv2 plugins and vst plugins. There are more DPF-based plugins I plan to package that leave the the DPF Makefiles as-is so I thought inheriting from dragonfly-reverb would be a nice way to do it. Thanks, Alex On Tue, 2020-04-07 at 14:25 -0400, Leo Famulari wrote: > On Mon, Apr 06, 2020 at 10:28:35PM +0100, Alexandros Theodotou wrote: > > * gnu/packages/music.scm (shiru-lv2): New variable. >=20 > Thanks! >=20 > > +(define-public shiru-lv2 > > + (let ((commit "08853f99140012234649e67e5647906fda74f6cc") > > + (revision "1")) > > + (package/inherit dragonfly-reverb >=20 > If inheriting, we should use the regular inherit procedure, like > this: >=20 > (package > (inherit dragonfly-reverb) > ...) >=20 > package/inherit is for special cases related to grafting and > replacement > packages. [0] >=20 > Anyways, it looks like the inherited fields are build-system, > native-inputs, and arguments. Is the idea that there is some build > complication common to the LV2 plugins that we don't want to copy > around? Maybe we could make a build system for them. >=20 > Does it work to inherit the custom install phase from dragonfly- > reverb? > It seems like the install-file procedures would not apply here. >=20 > What do you think? Sorry if I've missed something. >=20 > [0] > https://guix.gnu.org/manual/en/html_node/Security-Updates.html --=-VFrxbcFNlOBWzXncsjjh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEESBMjhK0999huJUuDAi6uQjE9cPMFAl6Mz+sACgkQAi6uQjE9 cPNxNgf+NpxlQY8xu+W5Pchgp9Xjt7H6/CWGkwYImFjAU+F/3YqGYoy0MJ0WxI8F pVmVvl8d2ixX5x3Ejnx8bbL0vxwrQdmEjUqgM8IzIenjepW+bfPvspcVXcAmd/7A QJuNRTcgnC8FgAoyVUslxPyBCR2MHhF4JNA7ZQODU7UymSbdSA1KrqGvGrYlmwLx cQp4k7GF/9kKmMts1JZoFCe68/5UK5PQ3RuSt0yyG4KhB9Sco861GJQVwgrF8nuP 95C5CSo7k8ak8RfEzcJR7AKXiJVp1wT9V4gaUCiK6fOyasA6bihmqyIQjfvbC5jN 8ELf0QymW5cMviLfMWEaVJA2xdcI5w== =3JmO -----END PGP SIGNATURE----- --=-VFrxbcFNlOBWzXncsjjh--