From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 07 14:25:21 2020 Received: (at 40468) by debbugs.gnu.org; 7 Apr 2020 18:25:21 +0000 Received: from localhost ([127.0.0.1]:50862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jLsuX-0006xH-D3 for submit@debbugs.gnu.org; Tue, 07 Apr 2020 14:25:21 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:50555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jLsuW-0006x4-2N for 40468@debbugs.gnu.org; Tue, 07 Apr 2020 14:25:20 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id F308D5C00B6; Tue, 7 Apr 2020 14:25:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 07 Apr 2020 14:25:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=MYCoWFwOrUFrigeQ5nl6NIh5 tv3xHYiZpnSHIp+rTKQ=; b=F9T6N20VO+cXTGHI3RbD49UiCBjSj4DTzxGtL6Dn W9H9T+uc8Lbj7tfMsK/jBF5kkefd2YnfYzch2dNNYt12Puvrrp+4tkIB6MlDb7zt gTHygh4lCcvgS/RoLvWuqRz7lOGuWMy1D6NPHYCJasfMzeraSVSJh6iu9eQshiZN UjA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=MYCoWF wOrUFrigeQ5nl6NIh5tv3xHYiZpnSHIp+rTKQ=; b=cqtTpyC6tkNKeoZ+DlfI/r zeRdKPKFZIBi8xfzz7k1d1RnIP1+/ntrV720r7AoPujUvXkBfqRq37tWSdZqO/iI HlL65Yqvs2VZsUc2DzZoROh/E+LPLcy1vMYaBReGgyEDAq9Q1JDNnsZNnTDdxKpa 55w2MStNtJPTmbe2Pls3r9JWp6RkeKXp2PYO9IpGnKHvOuYQJBHBDsWWhLgsUHfn WE/lYRzamFE23Hy2qQ3xVhUogx3HmKi55fptahtimmI60fZTQe9l77/8O2T0TcND itiAZPSF4fz3nk/lp0/HXqBeOXurmZGrvaaFUn5TMU6+A8/p67H666yTfGyrdgRw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudehgdduvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucffohhmrghinh epghhnuhdrohhrghenucfkphepjeeirdduvdegrddufeekrdeifeenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrih drnhgrmhgv X-ME-Proxy: Received: from localhost (c-76-124-138-63.hsd1.pa.comcast.net [76.124.138.63]) by mail.messagingengine.com (Postfix) with ESMTPA id 6047E3280059; Tue, 7 Apr 2020 14:25:14 -0400 (EDT) Date: Tue, 7 Apr 2020 14:25:11 -0400 From: Leo Famulari To: Alexandros Theodotou Subject: Re: [bug#40468] [PATCH 3/3] gnu: Add shiru-lv2. Message-ID: <20200407182511.GA9039@jasmine.lan> References: <053db596207697e4b7d32b55a965b2ba88beca75.camel@zrythm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40468 Cc: 40468@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Mon, Apr 06, 2020 at 10:28:35PM +0100, Alexandros Theodotou wrote: > * gnu/packages/music.scm (shiru-lv2): New variable. Thanks! > +(define-public shiru-lv2 > + (let ((commit "08853f99140012234649e67e5647906fda74f6cc") > + (revision "1")) > + (package/inherit dragonfly-reverb If inheriting, we should use the regular inherit procedure, like this: (package (inherit dragonfly-reverb) ...) package/inherit is for special cases related to grafting and replacement packages. [0] Anyways, it looks like the inherited fields are build-system, native-inputs, and arguments. Is the idea that there is some build complication common to the LV2 plugins that we don't want to copy around? Maybe we could make a build system for them. Does it work to inherit the custom install phase from dragonfly-reverb? It seems like the install-file procedures would not apply here. What do you think? Sorry if I've missed something. [0] https://guix.gnu.org/manual/en/html_node/Security-Updates.html