From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 11 20:45:59 2020 Received: (at 40301) by debbugs.gnu.org; 12 Apr 2020 00:45:59 +0000 Received: from localhost ([127.0.0.1]:57213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNQl4-0004G0-M1 for submit@debbugs.gnu.org; Sat, 11 Apr 2020 20:45:58 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:34096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNQl2-0004Fm-6d for 40301@debbugs.gnu.org; Sat, 11 Apr 2020 20:45:57 -0400 Received: by mail-pg1-f195.google.com with SMTP id l19so844073pgk.1 for <40301@debbugs.gnu.org>; Sat, 11 Apr 2020 17:45:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asu-edu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=TKzL5ifS3eSwSLyJTHm4bYObPRRHC9QK+THe0rM8ZLw=; b=ljgJbJMq1eEQo8rwDZCRCukj8EAqAaOuspkZkgmDITTeWI2+WU0eZYWFaCA2959R+/ 0v5X4DTDCxRXMXzjvXwjYxGhBYV1hCdy3C16SIMUn2+jc2YrJ8xOYzvDKQFExo3umx1F LIWLaWznKojR8wjGgEkhYddQHjeVEu4ZF4Aoa6OBiq4ahCOwIPQO+zjSaRmKLqgSXU6L OjgjxznXAAC6OocmnjpAXrpq1CHwibCl2A3Z7KmsDf+quFJ0a4fLEYErzRtb6BEDhu88 eypVX89Hanvw01wGnwq9UZcLmYp4bWuOzus0vMZvU5EqrenohgTK8PJV6arwQDsWM8R0 qp4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=TKzL5ifS3eSwSLyJTHm4bYObPRRHC9QK+THe0rM8ZLw=; b=YV0hi/JBJb/f3H0yhgI0BfnRpqkUkYl2fY/z7fysdrDb5F/tH1+7KGgCj9rv6LteYJ BbDYAr4nSG1c8EYWRSgWemLqo5keq4DIyspY6xmO+PMV09H6cO71KeT5CarE5RPPw83a SM/Xn/mU7T3Z7V/HgrNS6EQI7arw0yyESjLdds9avr3Yaq5PwXOGdkCIe1le+yf86Y1V GqQbntp5qXZtA33LkEwJ4HC6NoWLkIn8HBLDF6io9nGBHRWAQ2zTmTay0hcvWxL4mdnF 2e9vem1zpWVJB7FwgbFj/DnxYE0xRI12TY00eGeOOPI3nBpNN8w4+GP1nz2go/XLv+F/ b75A== X-Gm-Message-State: AGi0PuZ4XQjQgEeVxgZDuUqRLldAAsGgQSkdMoAuX3yFMyHqZ78dIFZ5 bH2mS3H2bI7DrUBsGNl4Dl9jVre3r1fmUQ== X-Google-Smtp-Source: APiQypJnWsfkUD5EkH9T8lS3ZK18ANPJ+xFcs40EtGT6WxQhJaH+ZH69ITifDklJgN0SQyJLX0lv3g== X-Received: by 2002:a62:e113:: with SMTP id q19mr257946pfh.107.1586652349863; Sat, 11 Apr 2020 17:45:49 -0700 (PDT) Received: from ecenter ([2600:1700:83b0:8bd0::429]) by smtp.gmail.com with ESMTPSA id k63sm1955575pjb.6.2020.04.11.17.45.47 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 11 Apr 2020 17:45:48 -0700 (PDT) From: John Soo To: Nicolas Goaziou Subject: Re: [bug#40301] [PATCH] Fixed some issues with the patches. References: <87h7y82cey.fsf@asu.edu> <87o8ryq9h4.fsf@asu.edu> <87a73h3ih3.fsf@nicolasgoaziou.fr> Date: Sat, 11 Apr 2020 17:45:47 -0700 In-Reply-To: <87a73h3ih3.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Sat, 11 Apr 2020 21:55:36 +0200") Message-ID: <87ftd9r0p0.fsf@asu.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40301 Cc: 40301@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi Nicolas, Nicolas Goaziou writes: >> +(define-public emacs-psc-ide >> + (package >> + (name "emacs-psc-ide") >> + (version "0.0.0") > > According to "Version:" keyword in "psc-ide.el", it is "0.1.0". Also, > you need to add a revision number, "0", or "1" at this point. > ... >> + (source >> + (origin >> + (method git-fetch) >> + (uri >> + (git-reference >> + (url "https://github.com/purescript-emacs/psc-ide-emacs") >> + (commit "7fc2b841be25f5bc5e1eb7d0634436181c38b3fe"))) > > The commit should be moved in a top-level `let' at the beginning of the > package definition. > >> + (file-name (git-file-name name "0.0.0")) > > This should use version, along with the revision number. >> + (synopsis "Emacs integration for PureScript's psc-ide tool") >> + (description >> + "Emacs integration for PureScript's psc-ide tool. Featuring: Ok I added the revision and the commit and used git-version and git-file-name. As an aside, what does the revision mean? Maybe if I really understand it I can submit better patches in the future. > Description should be made of full sentences. Also, it might be useful > to explain what "psc-ide" tool is. I think I clarified the description a little. This was an excellent detailed review, thank you so much. Also, I changed inputs->propagated-inputs. Kindly, John --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-Add-emacs-psc-ide.patch Content-Description: psc-ide From 20e7f672bb002e8e0e784300789c3e11aeabd41f Mon Sep 17 00:00:00 2001 From: John Soo Date: Tue, 24 Mar 2020 07:36:28 -0700 Subject: [PATCH] gnu: Add emacs-psc-ide. * gnu/packages/emacs-xyz.scm (emacs-psc-ide): New variable. --- gnu/packages/emacs-xyz.scm | 41 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index e700920266..530eee7eb7 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -12334,6 +12334,47 @@ keychains. The keychain entries are displayed in a directory-like structure and can be consulted and modified.") (license license:gpl3+))) +(define-public emacs-psc-ide + (let ((revision "1") + (commit "7fc2b841be25f5bc5e1eb7d0634436181c38b3fe")) + (package + (name "emacs-psc-ide") + (version (git-version "0.1.0" revision commit)) + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/purescript-emacs/psc-ide-emacs") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0r0fymyai30jimm34z1cmav4wgij8ci6s1d9y7qigygfbbfrdsmj")))) + (build-system emacs-build-system) + (propagated-inputs + `(("emacs-company" ,emacs-company) + ("emacs-dash" ,emacs-dash) + ("emacs-flycheck" ,emacs-flycheck) + ("emacs-let-alist" ,emacs-let-alist) + ("emacs-s" ,emacs-s) + ("emacs-seq" ,emacs-seq))) + (home-page "https://github.com/purescript-emacs/psc-ide-emacs") + (synopsis "Emacs integration for PureScript's psc-ide tool") + (description + "PureScript implements an ide protocol in its compiler called psc-ide. +This package provices Emacs integration for psc-ide. It features: + +@itemize +@item Completions +@item Type at point +@item Go to definition +@item Automatic imports +@item Case split +@item Build system integration, and +@item Flycheck support +@end itemize") + (license license:gpl3+)))) + (define-public emacs-evil-anzu (package (name "emacs-evil-anzu") -- 2.26.0 --=-=-=--