Thanks for your submission. Note that you need not create a new thread for to send a update of a patch. If you used the `git send-email` command, you could have used the `--to=` option to send to the previous thread. For instance --8<---------------cut here---------------start------------->8--- git send-email --to=39756@debbugs.gnu.org 0001-my-patch.diff --8<---------------cut here---------------end--------------->8--- Comments below: > --- > gnu/packages/emacs-xyz.scm | 71 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 71 insertions(+) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index 6b9027df8a..c6df469895 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -8601,6 +8601,77 @@ It should enable you to implement low-level X11 applications.") > built on top of XELB.") > (license license:gpl3+))) > > +(define-public emacs-exwm-next I think you don't need to copy the whole package definition. Instead, you could `inherit' from the original definition and only adjust the name, description, inputs and maybe arguments. For instance --8<---------------cut here---------------start------------->8--- (define-public emacs-exwm-next (package (inherit emacs) (name "emacs-exwm-next") (inputs ...) (synopsys ...))) --8<---------------cut here---------------end--------------->8--- See `substitute-keyword-arguments' in the fftwf package for a convenient way to modify just one argument. > + (package > + (name "emacs-exwm-next") > + (version "0.23") > + (synopsis "Emacs X window manager") Maybe tell that this is using the next version of Emacs. > + (source (origin > + (method url-fetch) > + (uri (string-append "https://elpa.gnu.org/packages/exwm-" > + version ".tar")) > + (sha256 > + (base32 > + "05w1v3wrp1lzz20zd9lcvr5nhk809kgy6svvkbs15xhnr6x55ad5")))) > + (build-system emacs-build-system) > + (propagated-inputs > + `(("emacs-xelb" ,emacs-xelb))) > + (inputs > + `(("xhost" ,xhost) > + ("emacs-next" ,emacs-next) > + ("dbus" ,dbus))) > + ;; The following functions and variables needed by emacs-exwm are > + ;; not included in emacs-minimal: > + ;; scroll-bar-mode, fringe-mode > + ;; x-display-pixel-width, x-display-pixel-height > + (arguments > + `(#:emacs ,emacs Shouldn't this be `emacs-next` as well? Cheers! -- Pierre Neidhardt https://ambrevar.xyz/