From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 26 18:55:37 2020 Received: (at 39765) by debbugs.gnu.org; 26 Mar 2020 22:55:37 +0000 Received: from localhost ([127.0.0.1]:60345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jHbPU-0004Ie-Ig for submit@debbugs.gnu.org; Thu, 26 Mar 2020 18:55:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jHbPS-0004IJ-De for 39765@debbugs.gnu.org; Thu, 26 Mar 2020 18:55:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45453) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jHbPN-0005Bl-2g; Thu, 26 Mar 2020 18:55:29 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=38826 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jHbPM-0004sp-4F; Thu, 26 Mar 2020 18:55:28 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Lars-Dominik Braun Subject: Re: [bug#39765] Add package JupyterLab References: <20200224101810.GA9010@zpidnp36> Date: Thu, 26 Mar 2020 23:55:26 +0100 In-Reply-To: <20200224101810.GA9010@zpidnp36> (Lars-Dominik Braun's message of "Mon, 24 Feb 2020 11:18:10 +0100") Message-ID: <87d08y915t.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39765 Cc: 39765@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Lars, Sorry for the late reply. Lars-Dominik Braun skribis: > this patch series adds Jupyter=E2=80=99s JupyterLab, which is the new fro= ntend for > Jupyter Notebooks. The software works fine, but there are a few caveats > > 1) it comes with bundled pre-compiled JavaScript, which cannot be removed= until > we have proper support for importing from NPM > 2) it contains an extension manager, that downloads arbitrary packages fr= om NPM > (`jupyter lab build`). This works, but is less than optimal imo. We sh= ould > figure out how to package extensions in guix. > 3) also it is required to install the package `jupyter`, otherwise instal= led > kernels cannot be found and the `jupyter` command does not work. #2 should be quite easy to address: we could arrange to have that feature disabled by default, so that users don=E2=80=99t find themselves unknowingly downloading arbitrary code from npm. #3 is OK. #1 is a showstopper. :-/ I suppose that=E2=80=99s a lot of code that would need to be imported from npm, right? It=E2=80=99s sad because all this is free software, but we practically can= =E2=80=99t get the corresponding source. I=E2=80=99ve pushed the first two patches of the series (python-json5 and python-pytest-check-links). Comments on the other bits that are readily applicable: >>From a47fd94aa6f3e62b77f3b7208c4e6757e3a9ee08 Mon Sep 17 00:00:00 2001 > From: Lars-Dominik Braun > Date: Thu, 12 Dec 2019 08:53:39 +0100 > Subject: [PATCH 5/5] gnu: python-notebook: Support UNIX domain sockets > > * gnu/packages/python-xyz.scm (python-notebook): Add patch from upstream > https://github.com/jupyter/notebook/pull/4835 > (python-requests-unixsocket) New variable > --- > ...pyter-unix-domain-sockets-4835-5.7.4.patch | 591 ++++++++++++++++++ > gnu/packages/python-xyz.scm | 35 +- > 2 files changed, 624 insertions(+), 2 deletions(-) > create mode 100644 gnu/packages/patches/jupyter-unix-domain-sockets-4835= -5.7.4.patch > > diff --git a/gnu/packages/patches/jupyter-unix-domain-sockets-4835-5.7.4.= patch b/gnu/packages/patches/jupyter-unix-domain-sockets-4835-5.7.4.patch > new file mode 100644 > index 0000000000..134d3ad2b8 > --- /dev/null > +++ b/gnu/packages/patches/jupyter-unix-domain-sockets-4835-5.7.4.patch > @@ -0,0 +1,591 @@ Please add provenance info at the top of the patch (such as the URL of the upstream commit), as well as a line or two explaining what it does. You can omit =E2=80=9C-4835-5.7.4=E2=80=9D from the file name. Make sure to add the file to =E2=80=98gnu/local.mk=E2=80=99. That said, it=E2=80=99s a big patch, so it would be even better if we didn= =E2=80=99t have to carry it. Will the next version of =E2=80=98notebook=E2=80=99 incl= ude it? Last, =E2=80=98python-requests-unixsocket=E2=80=99 should be added in a sep= arate patch. [...] > + (arguments > + ;; tests depend on very specific package version, which are not ava= ilable in guix > + '(#:tests? #f)) Perhaps add a =E2=80=9CFIXME=E2=80=9D and clarify which packages we=E2=80= =99re talking about (the =E2=80=9Cnot available=E2=80=9D bit is bound to become outdated :-)). > + (home-page > + "https://github.com/msabramo/requests-unixsocket") > + (synopsis > + "Use requests to talk HTTP via a UNIX domain socket") > + (description > + "Use requests to talk HTTP via a UNIX domain socket") Please follow the synopsis/description guidelines (info "(guix) Synopses and Descriptions"). Thank you for this endeavor! Ludo=E2=80=99.