From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 12 09:28:21 2020 Received: (at 39572) by debbugs.gnu.org; 12 Feb 2020 14:28:21 +0000 Received: from localhost ([127.0.0.1]:57999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1szx-0001V9-Gt for submit@debbugs.gnu.org; Wed, 12 Feb 2020 09:28:21 -0500 Received: from sender4-pp-o91.zoho.com ([136.143.188.91]:25160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1szv-0001V0-Mo for 39572@debbugs.gnu.org; Wed, 12 Feb 2020 09:28:16 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1581517694; cv=none; d=zohomail.com; s=zohoarc; b=lFzn2+AL6wUWMehRGMFl+G9qYeILQkiCHXlM9OpHpYzFoX0UJOdJu0Q6okIFBgqHZENexbQAR7ByYSor44Wwq1o6QW0DYcQWIEyZDfy2UsCslkJ7Vf7UShmMwwOmrDt2aVp7G0/JHiEdVh/0SBaKR9yzohNpJqNYp59lvkbG5b0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1581517694; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=u6VpQdLqC7yR6v/gSZ+5RLJ/q7sCYlBTYEExIFmGj70=; b=AUdUhO5DTOb/ypPNhHkiyVszFB7hVq26piOIy97VBX6Pigmhd/oImJoNZmdV7eqAVvFW6ZeNLh51wTWtxCKz72mssaUzlksH2Ch0CG5OLMJBwXEpZiNlp2nssjb/6Erq3ykAv9WPp6R/SCt0UtvL8ctTgDz800TOPh42Z0xVXF4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=sirgazil@zoho.com; dmarc=pass header.from= header.from= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=date:from:to:cc:message-id:in-reply-to:references:subject:mime-version:content-type:user-agent; b=TzQAkWv/NfwTRCyrKLDL1rDE0Rtm+K/IwJ6VfVZZ3vpwOy3657ziTkr8bOc0zUY1rJxExwMsblzY GY4bt/UG3kT6/R23Dr1iIOp98LdyQ4n5Nh6nIAodRKmjaFUXWPS3 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1581517694; s=zm2020; d=zoho.com; i=sirgazil@zoho.com; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=u6VpQdLqC7yR6v/gSZ+5RLJ/q7sCYlBTYEExIFmGj70=; b=TBYSBwR4tRdfqLgI90ffqFA53S98EgrCXioYllhHwtu16uNB9j6xzAjG20UCvZZc 1dT9ILvpynHHq5rHhn1Hg74aFeeizSkir8+IHxrWkTbdIx7GjfO7Buzpn/DawQ+4Z3x m5ncZyNZiPmwzbFwTyaYp8rhrsj2Mrkap+28PUuk= Received: from mail.zoho.com by mx.zohomail.com with SMTP id 1581517686803425.67913060427577; Wed, 12 Feb 2020 06:28:06 -0800 (PST) Received: from [179.15.13.185] by mail.zoho.com with HTTP;Wed, 12 Feb 2020 06:28:06 -0800 (PST) Date: Wed, 12 Feb 2020 09:28:06 -0500 From: sirgazil To: "Efraim Flashner" Message-ID: <17039ccc811.f87a728432739.1646525153556191072@zoho.com> In-Reply-To: <20200212074827.GE26092@E5400> References: <20200212001420.24513-1-sirgazil@zoho.com> <20200212074827.GE26092@E5400> Subject: Re: [bug#39572] [PATCH] gnu: Add python-sphinx-autodoc-typehints. MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Importance: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39572 Cc: 39572 <39572@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ---- On Wed, 12 Feb 2020 02:48:27 -0500 Efraim Flashner wrote ---- > Overall the package looks good. I ran into an issue with the tests, > namely that they weren't run. (This is becoming a common issue with our > python packages as they change how the test suite is run) >=20 > On Tue, Feb 11, 2020 at 07:14:20PM -0500, sirgazil via Guix-patches via = wrote: > > * gnu/packages/sphinx.scm (python-sphinx-autodoc-typehints): New varia= ble. > > --- > > gnu/packages/sphinx.scm | 25 +++++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > >=20 > > diff --git a/gnu/packages/sphinx.scm b/gnu/packages/sphinx.scm > > index 4e4abccb04..41bde173c3 100644 > > --- a/gnu/packages/sphinx.scm > > +++ b/gnu/packages/sphinx.scm > > @@ -13,6 +13,7 @@ > > ;;; Copyright =C2=A9 2019 Nicolas Goaziou > > ;;; Copyright =C2=A9 2019 Alexandros Theodotou > > ;;; Copyright =C2=A9 2019 Brett Gilio > > +;;; Copyright =C2=A9 2020 sirgazil > > ;;; > > ;;; This file is part of GNU Guix. > > ;;; > > @@ -597,3 +598,27 @@ to be able to read and render the Doxygen xml out= put.") > > "A utility tool that provides several features that make it easy= to > > translate and to apply translation to Sphinx generated document.") > > (license license:bsd-2))) > > + > > +(define-public python-sphinx-autodoc-typehints > > + (package > > + (name "python-sphinx-autodoc-typehints") > > + (version "1.10.3") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (pypi-uri "sphinx-autodoc-typehints" version)) > > + (sha256 > > + (base32 > > + "1w6zy3cyp24jsdi8dcynrinafw2a0k5vblqy9lncm6j7cw0iicx6")))) > > + (build-system python-build-system) >=20 > I added the following snippet here to run the tests: >=20 > (arguments > `(#:phases > (modify-phases %standard-phases > (replace 'check > (lambda _ > (invoke "pytest")))))) >=20 > And added python-pytest to the native-inputs but it turns out that > wasn't enough: >=20 > starting phase `check' > ImportError while loading conftest '/tmp/guix-build-python-sphinx-autodo= c-typehints-1.10.3.drv-0/sphinx-autodoc-typehints-1.10.3/tests/conftest.py'= . > tests/conftest.py:8: in > from sphobjinv import Inventory > E ModuleNotFoundError: No module named 'sphobjinv' > command "pytest" failed with status 4 >=20 > According to here=C2=B9 there are a couple of other dependencies that ar= e > needed to run the tests, including sphobjinv which isn't packaged yet. Oh, I read "extras_require" as "completely optional". I'll be more careful = with that. > > + (native-inputs > > + `(("python-setuptools-scm" ,python-setuptools-scm))) > > + (propagated-inputs > > + `(("python-sphinx" ,python-sphinx))) > > + (home-page "https://github.com/agronholm/sphinx-autodoc-typehints= ") > > + (synopsis "Type hints support for the Sphinx autodoc extension") > > + (description > > + "This extension allows you to use Python 3 annotations for > > +documenting acceptable argument types and return value types of > > +functions.") > > + (license license:expat))) > > --=20 > > 2.25.0 > >=20 >=20 > =C2=B9 https://github.com/agronholm/sphinx-autodoc-typehints/blob/1.10.3= /setup.cfg >=20 > --=20 > Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7= =9D =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 > GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 > Confidentiality cannot be guaranteed on emails sent or received unencryp= ted >=20 Thank you very much for your review, Efraim. I'll check if I'm able to pack= age whatever is missing.