From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 07 19:20:36 2020 Received: (at 39021) by debbugs.gnu.org; 8 Feb 2020 00:20:36 +0000 Received: from localhost ([127.0.0.1]:50470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0DrQ-0006u3-DZ for submit@debbugs.gnu.org; Fri, 07 Feb 2020 19:20:36 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:47423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0DrO-0006tq-Rt for 39021@debbugs.gnu.org; Fri, 07 Feb 2020 19:20:35 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 18B6044D; Fri, 7 Feb 2020 19:20:29 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 07 Feb 2020 19:20:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=mesmtp; bh=pgdgQmg51U6MknYNeQxfQ4YdSEe4/3EQjMBOYu/ApN8=; b=i1adKXqsHT+d 3XGMbhLl0T0QWF1XjWPGuk/5N+/NgoVfcn6oL11RngC+7zH/k7UmC/o40GtA2Zzi Ar1lal6V6T8N2hNQ1cUWtUb+GrHdIjt+6yOPVBvkuZyhzvnM7iOeFm3T2C0df++u gZKAGl7t4gS9Xq2FLVWFko+S3ZnO7r4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=pgdgQmg51U6MknYNeQxfQ4YdSEe4/3EQjMBOYu/Ap N8=; b=UdvS5M+SwAl99v/SSRz5U7pfamiJbi9PsOZaWbgnXT/EijUtXSDE6R3pY KuEOHDe5oKKOZarr1Y8hRRc6tuGowtZb8QNyiyTwammJ315gBrE9oCotykXBme7C BMrzajvXhBQVrOg+bQE2g2DZubiQacZr4W5lteS4fi3Jj4u519Jh45qJEkWgg7fU kUvb2hLxq8vEHhKTzEMIhkBlrQmxgd5DiiCTsCbXb90vsgv8O9S9iGxfZbCHe9/o Z8Cj3bz7ST0vqPygyov9Xvz9g2RXI8x2KT7I0ynZ0IK2RQwpD7mOGVCXtWry87g6 kwxNGkmf99CRRK5AtB/rAqzQzFEVw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrheeigddvvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtugfgjgesthekre dttddtjeenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuffhomhgrihhnpeguthhhohhmphhsohhnrdhushdpghhithhhuh gsrdgtohhmnecukfhppedujedvrdehkedrvddtfedrudeikeenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnh grmhgv X-ME-Proxy: Received: from localhost (unknown [172.58.203.168]) by mail.messagingengine.com (Postfix) with ESMTPA id 4AD053280060; Fri, 7 Feb 2020 19:20:28 -0500 (EST) Date: Fri, 7 Feb 2020 19:20:20 -0500 From: Leo Famulari To: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= Subject: Re: [bug#39021] [PATCH] Add Keybase Message-ID: <20200208002020.GD12194@jasmine.lan> References: <20200107200039.jga75muq7excgpqu@zdrowyportier.kadziolka.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200107200039.jga75muq7excgpqu@zdrowyportier.kadziolka.net> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39021 Cc: 39021@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Tue, Jan 07, 2020 at 09:00:39PM +0100, Jakub Kądziołka wrote: > please find attached a set of patches that adds the non-GUI parts of > Keybase (the GUI is an Electron application - as far as I am aware, > there are no similar packages in Guix, so packaging the GUI requires a > significant amount of further work). I don't *think* we have any Electron packages, but we do have Chromium (and qtwebengine) and Node.js, so I hope it's possible. > Unresolved question: in other distributions, the package provides user > units for systemd. Should the Guix package provide Shepherd services to > be ran as the user? If so, are there any other examples I could look at > and draw inspiration from? Also, I haven't been able to find any > documentation on how to set up user shepherd, apart from a passing > mention of that being possible in the documentation. I would appreciate > any pointers on the topic. We don't really do this kind of thing — adding features or service manager files to upstream packages. As for user shepherd, there's an example here: https://git.dthompson.us/dotfiles.git/blob/HEAD:/dotfiles/.config/shepherd/init.scm There's a lot going on there but the important parts are (register-services ...), (make ...), (action ...), and (for-each start ...) Then you just invoke `shepherd`. > From 0d744787c48c7184a70dda9fc1bb2c0d334fc080 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= > Date: Sun, 5 Jan 2020 17:13:20 +0100 > Subject: [PATCH 1/2] build-system/go: Allow providing additional build flags > > * guix/build-system/go.scm (build-flags): New argument. > * guix/build/go-build-system.scm (build): Use apply to pass the > additional arguments to invoke. Nice, LGTM! > From 3de233a2d8e6bdb4723844337b69b6612616c9c5 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= > Date: Tue, 7 Jan 2020 20:29:21 +0100 > Subject: [PATCH 2/2] gnu: Add keybase. > > * gnu/packages/crypto.scm > (keybase-component): New function. > (keybase, git-remote-keybase, kbfs): New variables. This is enough of it's own thing that we can make a new (gnu packages keybase) module. > +(define* (keybase-component #:key name repo-path synopsis description) We avoid abbreviations, so maybe "repository-path"? Bonus points if we can make it more descriptive. Can you take a look at the bundled ("vendored") dependencies: https://github.com/keybase/client/tree/master/go/vendor We strive to avoid using these, but sometimes we do, as in the Docker package. It's not really idiomatic to unbundle things in Go. But we need to at least make sure all the bundled dependencies are freely licensed. Also, please run `guix lint` on these packages and make sure the descriptions are written in complete sentences.