From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 31 18:54:48 2019 Received: (at 38827) by debbugs.gnu.org; 31 Dec 2019 23:54:48 +0000 Received: from localhost ([127.0.0.1]:35327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imRLc-0007CS-9c for submit@debbugs.gnu.org; Tue, 31 Dec 2019 18:54:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imRLa-0007CG-3X for 38827@debbugs.gnu.org; Tue, 31 Dec 2019 18:54:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1imRLU-0007wR-Rp; Tue, 31 Dec 2019 18:54:40 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47136 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1imRLS-00089c-Tt; Tue, 31 Dec 2019 18:54:40 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: [bug#38827] [PATCH] gnu: Add gitlab-runner. References: <20191231091757.69869-1-r.majd@pantherx.org> <87imlwsqir.fsf@gmail.com> <87d0c4sjam.fsf@gmail.com> <87tv5ga341.fsf@gmail.com> Date: Wed, 01 Jan 2020 00:54:37 +0100 In-Reply-To: <87tv5ga341.fsf@gmail.com> (Mathieu Othacehe's message of "Tue, 31 Dec 2019 17:09:34 +0100") Message-ID: <878smsxd8i.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38827 Cc: 38827@debbugs.gnu.org, Reza Alizadeh Majd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello! Mathieu Othacehe skribis: >> I update the package definition following the above guidelines. >> could you please check if this updated patch is acceptable? > > I fixed the indentation, added one space between the two description > sentences and pushed. The =E2=80=98vendor=E2=80=99 directory contains a large number of bundled d= ependencies, including various bits of Docker and Kubernetes. I=E2=80=99m not comfortab= le keeping this package as is. Reza, could you look into unbundling these, or at least a significant part of these? There=E2=80=99s a Go importer at , but it=E2=80=99s for =E2=80=98Gopkg.toml=E2=80=99 files, which seem to be o= ut of fashion, so I=E2=80=99m not sure it=E2=80=99d be useful. In the meantime, I=E2=80=99d be in favor of reverting the patch. WDYT? Thanks, Ludo=E2=80=99.