From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 19 17:47:43 2019 Received: (at 38576) by debbugs.gnu.org; 19 Dec 2019 22:47:43 +0000 Received: from localhost ([127.0.0.1]:45697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ii4a7-0006Qz-8s for submit@debbugs.gnu.org; Thu, 19 Dec 2019 17:47:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42127) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ii4a5-0006Qo-Sc for 38576@debbugs.gnu.org; Thu, 19 Dec 2019 17:47:42 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ii4Zz-0006yL-VB; Thu, 19 Dec 2019 17:47:36 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=36386 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ii4Zz-0008BI-Cn; Thu, 19 Dec 2019 17:47:35 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Lars-Dominik Braun Subject: Re: [bug#38576] [PATCH] gnu: r-irkernel: Fix R kernel loading References: <20191212074613.GA11713@zpidnp36> <87wob13mpn.fsf@elephly.net> <20191212100452.GE22717@zpidnp36> Date: Thu, 19 Dec 2019 23:47:33 +0100 In-Reply-To: <20191212100452.GE22717@zpidnp36> (Lars-Dominik Braun's message of "Thu, 12 Dec 2019 11:04:52 +0100") Message-ID: <87r210j5kq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38576 Cc: Ricardo Wurmus , 38576@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Lars-Dominik Braun skribis: >> This part looks fine to me, though I wonder if that=E2=80=99s what users= of this >> package would expect. Is there an expectation that the effective R is >> defined by the environment? Or would that not work anyway? > it=E2=80=99s what python-ipykernel does =E2=80=93 without explanation tho= ugh. I=E2=80=99m not an R > expert, so I=E2=80=99m unsure whether any R installation from the environ= ment (which > could be user-installed in $HOME) would be able to load this plugin or ju= st the > one it was =E2=80=9Cbuilt=E2=80=9D for. This change assumes the latter. > >>=20 >> > @@ -12423,6 +12429,8 @@ running IRkernel session.") >> > ("r-evaluate" ,r-evaluate) >> > ("r-irdisplay" ,r-irdisplay) >> > ("r-jsonlite" ,r-jsonlite) >> > + ;; sets R_LIBS_SITE, so R can actually find this package (IRke= rnel) >> > + ("r-minimal" ,r-minimal) >> > ("r-pbdzmq" ,r-pbdzmq) >> > ("r-repr" ,r-repr) >> > ("r-uuid" ,r-uuid))) >>=20 >> This doesn=E2=80=99t look right to me. It seems wrong for any R package= to >> propagate R itself. The R_LIBS_SITE variable is =E2=80=9Cattached=E2=80= =9D to >> =E2=80=9Cr-minimal=E2=80=9D, so when that is installed R will find the r= -irkernel >> package. Am I missing something? > If r-minimal is not installed, the kernel will simply not work and thus > render this package useless. That=E2=80=99s why I would consider it a dep= endency. An argument in favor of the status quo would be that it allows users to choose between =E2=80=98r=E2=80=99 and =E2=80=98r-minimal=E2=80=99. Is tha= t a compelling argument? It may be more important for =E2=80=98r-irkernel=E2=80=99 to work out of th= e box, like you did. However, if we go that route, we should arrange to not propagate =E2=80=98r-minimal=E2=80=99 (it=E2=80=99s intrusive) and instead have =E2= =80=98kernel.json=E2=80=99 do the right thing. How does that sound? Thanks, Ludo=E2=80=99.