From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 18:01:39 2020 Received: (at 38576) by debbugs.gnu.org; 7 Jan 2020 23:01:39 +0000 Received: from localhost ([127.0.0.1]:49549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioxr0-0000sh-RA for submit@debbugs.gnu.org; Tue, 07 Jan 2020 18:01:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioxqz-0000sV-Ja for 38576@debbugs.gnu.org; Tue, 07 Jan 2020 18:01:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57216) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ioxqt-00006t-EZ; Tue, 07 Jan 2020 18:01:31 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=48628 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ioxqp-0000po-W8; Tue, 07 Jan 2020 18:01:28 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Roel Janssen Subject: Re: [bug#38576] [PATCH] gnu: r-irkernel: Fix R kernel loading References: <20191212074613.GA11713@zpidnp36> <87wob13mpn.fsf@elephly.net> <20191212100452.GE22717@zpidnp36> <87r210j5kq.fsf@gnu.org> <20200102073536.GA3066@zpidnp36> <87h81ew0aw.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 19 =?utf-8?Q?Niv=C3=B4se?= an 228 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 08 Jan 2020 00:01:26 +0100 In-Reply-To: (Roel Janssen's message of "Tue, 07 Jan 2020 22:02:13 +0100") Message-ID: <874kx6hnw9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38576 Cc: Ricardo Wurmus , 38576@debbugs.gnu.org, Lars-Dominik Braun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Roel, Roel Janssen skribis: > On Thu, 2020-01-02 at 12:43 +0100, Ludovic Court=C3=A8s wrote: >> Hi, >>=20 >> Lars-Dominik Braun skribis: >>=20 >> > > An argument in favor of the status quo would be that it allows users= to >> > > choose between =E2=80=98r=E2=80=99 and =E2=80=98r-minimal=E2=80=99. = Is that a compelling argument? >> > reading the documentation I thought this was possible using >> > --with-input=3Dr-minimal=3Dr ? >>=20 >> Yes, good point. >>=20 >> > > However, if we go that route, we should arrange to not propagate >> > > =E2=80=98r-minimal=E2=80=99 (it=E2=80=99s intrusive) and instead hav= e =E2=80=98kernel.json=E2=80=99 do the right >> > > thing. >> > I=E2=80=99m not following, sorry. What do you suggest kernel.json shou= ld do? >>=20 >> I was suggesting hard-coding the file name of the =E2=80=98R=E2=80=99 ex= ecutable in >> =E2=80=98kernel.json=E2=80=99, but I see you already did that in your in= itial patch. >> Sorry for the confusion. >>=20 >> On second thought, I think propagating R is acceptable in this case >> because a Jupyter kernel is a thin wrapper around a programming language >> implementation. >>=20 >> Unless there are objections, I=E2=80=99ll apply your initial patch. >>=20 > > I'm too late, but doesn't this break the kernel for people who have the "= full" R > in their profile, and therefore expect the "full" R to be available in a = Jupyter > notebook? Indeed, it forces =E2=80=98r-minimal=E2=80=99 for use in the kernel. But t= here are workarounds, as Lars-Dominik suggests above. WDYT? Ludo=E2=80=99.