From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 27 13:58:27 2019 Received: (at 38403) by debbugs.gnu.org; 27 Nov 2019 18:58:27 +0000 Received: from localhost ([127.0.0.1]:56219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ia2WB-0003ai-8e for submit@debbugs.gnu.org; Wed, 27 Nov 2019 13:58:27 -0500 Received: from tobias.gr ([80.241.217.52]:38140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ia2W9-0003aW-JL for 38403@debbugs.gnu.org; Wed, 27 Nov 2019 13:58:26 -0500 Received: by tobias.gr (OpenSMTPD) with ESMTP id af235ce6; Wed, 27 Nov 2019 18:58:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc :subject:references:in-reply-to:date:message-id:mime-version :content-type; s=2018; i=me@tobias.gr; bh=OWA6GLrTmlkplGn8666EGG MDqUDg1C1GBP9y9gOCdiM=; b=j3rMZ8EaUmt75TenkeHg8pS5vUkVxvsFRSTjdY ynxTht+gr1lQ5X+uUPG/N40Z0RacYQkFNX+q2iSxMqlc6qemeeMY2HsOoerBMNkx C2Q3Aj8KNIhLrxX0DuuJkt05eLwyUaUNOi/J+5x3mg5lCMb7GByaxXZKGRMfPIM6 /F7rcY60a5TfRI5GdPWrB/JVdV2eMocpTG3ZgSm6Q6V/80BOXDSOnmN7AJAnlqiL l8CP6xCQSOGtxqT/gccXpvJIRGI2mUQ0oO2gBfQbe3S/jRQ2PM5hC6e8Y5G+Dqt5 0EwL8jbrWb2SAdmNvlvO457YN70DRuzySaRmeb3OBmcQZJPA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 2f2631c5 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 27 Nov 2019 18:58:21 +0000 (UTC) From: Tobias Geerinckx-Rice To: guix-patches@gnu.org Subject: Re: [bug#38403] [PATCH] gnu: Add intel-vaapi-driver-g45-h264. References: <87y2w1uug9.fsf@jlicht.xyz> In-reply-to: <87y2w1uug9.fsf@jlicht.xyz> Date: Wed, 27 Nov 2019 19:58:19 +0100 Message-ID: <875zj59mes.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38403 Cc: 38403@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Jelle, Jelle Licht =E5=86=99=E9=81=93=EF=BC=9A > I am not sure if this package offers any practical benefit or=20 > not, so I > defer to someone who actually knows what they are talking about=20 > to make > a judgment call ;-). I don't have a G45, but if this driver verifiably works for you=20 (and the regular version does not) I think it's good to to include=20 it. Also because I expect this card to be overrepresented amongst=20 Guix users: there aren't that many common Librebootable machines. It needs its own clear synopsis, description, and home page=20 though. Is there a home page? I'm not good at navigating=20 BitBucket. > This variant of intel-vaapi-driver is a backport of the ancient=20 > g45-h264 > branch that used to be maintained by the intel-vaapi-driver=20 > team. As far > as I know, the reason they don't maintain this branch anymore is=20 > that > hardware accelerated h264 decoding on the G45 chipset was much=20 > too slow > for 1080p video, as by default it only had 32MB of VRAM to work=20 > with. These devices don't have their own RAM chips, so =E2=80=98by default=E2=80= =99 here=20 means the BIOS menu setting, right? If so, it should be mentioned=20 in the description for lack of upstream documentation. I'm guessing that your card identifies as an Intel=C2=AE GMA X4500MHD.=20 Is that correct? We should include the marketing name in the=20 synopsis & description too, even if it might not map 1:1 to the=20 chipset. > This variant of intel-vaapi-driver is a backport of the ancient=20 > g45-h264 > branch that used to be maintained by the intel-vaapi-driver=20 > team. As far > as I know, the reason they don't maintain this branch anymore is=20 > that > hardware accelerated h264 decoding on the G45 chipset was much=20 > too slow > for 1080p video, as by default it only had 32MB of VRAM to work=20 > with. This is good! :-) It should be slightly edited and used as a=20 description together with the original intel-vaapi-driver text. Apart from that, the package LGTM. Thanks! Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl3ex0sACgkQ2Imw8BjF STyxuA//VpCXPwBUI1N8uTdYzHO6DkhbmDlcpxV9PKvHAWQNGROrD+Z5XjcP+Srd QHR1rCqWMkNgCvcw8DX7P8QR4SHe7SB0kUtyZF5zPUOiLZW1SpTcI7qdaNbQ36yS tJXemW02JXredPhfm87QCGm0csGib6JlZfs4ph8R9eeWGTlaWLUllnlrJITkBJSG PuvnL8wYPuAlkWhbmZH54i2CVde815Y1DGb1poC03sTMtkWGI5TahEFHYWb8Vw1D sXOuApsKbn/mC0yfdLefkGlj1VJWdqPRQXYkXEfAKpEJHQPgjNFurdntboSdNCST yViI12dy4lCQnVKqTtrgjFwLInITMsGMcTnbqaW2HN6/wkIg3zsanWyN6wVGfNn1 yOXFQOdtSUEWsMVmakSFXXvkLkh0O24vIbq7CkEQg/a0MTB5rOHfNPrsBYbCbDn9 qRSUhs9XvaKiZtrYbzqYe19+FT95boUahYmUdGdnsIRp0dILG8Jb7d7eKdIhwTae qVScSeFQQEOtF+JUQwNzsKLBbmi46hSnfmnipNsuPN675WGmY+k/OIT0im7Owluh EEGiBb1Xmj67TYfCNJDO8EXvqwg+9nw1AKNYT3VYD9+NR62tv0bH7eVWnxDqlt6t RWCn3/HsYyhyl9kBLzlT4Tdzsx01JbBGqo1h/aW3PDXhBs8Q3KA= =8gG9 -----END PGP SIGNATURE----- --=-=-=--