From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 11:55:14 2019 Received: (at 38312) by debbugs.gnu.org; 21 Nov 2019 16:55:14 +0000 Received: from localhost ([127.0.0.1]:53246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXpjd-0004vT-W6 for submit@debbugs.gnu.org; Thu, 21 Nov 2019 11:55:14 -0500 Received: from mail-40131.protonmail.ch ([185.70.40.131]:41387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXpjZ-0004v5-3V for 38312@debbugs.gnu.org; Thu, 21 Nov 2019 11:55:12 -0500 Date: Thu, 21 Nov 2019 16:54:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=carldong.me; s=protonmail; t=1574355302; bh=TTi63jqah5l/FdmXTMzqgr/FaPejyAqvqn9bJUs7x8s=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References: Feedback-ID:From; b=Vz1lB5qM9qm7hQZnbMndClAGbauCS4sWM0QaVkCSkK2HtIGtCd69BxR1HoHQqXuR8 2lEmu4Y9037yvcHOMQWK/JzexIEbLSWOkmx2fPTb5Zbbv1dHadySthBH2axfMe68Ti aqtwtCIj5V2NLaUkJfKUeII7o+I8ZHEcIeU3w94A= To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= From: Carl Dong Subject: Re: [bug#38312] [PATCH 3/3] guix build: '--keep-failed' implies '--no-offload'. Message-ID: <86FB364B-E8B7-4813-A7C8-AAB4A74B3EB2@carldong.me> In-Reply-To: <20191121150358.21044-2-ludo@gnu.org> References: <20191121150358.21044-1-ludo@gnu.org> <20191121150358.21044-2-ludo@gnu.org> Feedback-ID: a8j8tDUaJ4AYuDVBywMTwsJebN4w8TVXadJLsJb8td3t3dZi9RdXFlPaQvoFKnI9KgXySsPXcRkajVyY0cGTcA==:Ext:ProtonMail MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.protonmail.ch X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 38312 Cc: 38312@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Carl Dong Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludovic! Perhaps we should print a message to the user for better user visibility wh= en this case gets triggered? Cheers, Carl Dong > On Nov 21, 2019, at 10:03 AM, Ludovic Court=C3=A8s wrote: >=20 >=20 > * guix/scripts/build.scm (set-build-options-from-command-line): Pass > #:offload? #f when 'keep-failed? is true. > * doc/guix.texi (Common Build Options): Document it. > --- > doc/guix.texi | 6 +++--- > guix/scripts/build.scm | 3 ++- > 2 files changed, 5 insertions(+), 4 deletions(-) >=20 > diff --git a/doc/guix.texi b/doc/guix.texi > index b1c615235b..e57c12ab7f 100644 > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -8048,9 +8048,9 @@ the end of the build log. This is useful when debu= gging build issues. > @xref{Debugging Build Failures}, for tips and tricks on how to debug > build issues. >=20 > -This option has no effect when connecting to a remote daemon with a > -@code{guix://} URI (@pxref{The Store, the @code{GUIX_DAEMON_SOCKET} > -variable}). > +This option implies @option{--no-offload}, and it has no effect when > +connecting to a remote daemon with a @code{guix://} URI (@pxref{The > +Store, the @code{GUIX_DAEMON_SOCKET} variable}). >=20 > @item --keep-going > @itemx -k > diff --git a/guix/scripts/build.scm b/guix/scripts/build.scm > index acb495a462..a853ac6c7d 100644 > --- a/guix/scripts/build.scm > +++ b/guix/scripts/build.scm > @@ -545,7 +545,8 @@ talking to a remote daemon\n"))) > #:fallback? (assoc-ref opts 'fallback?) > #:use-substitutes? (assoc-ref opts 'substitutes?) > #:substitute-urls (assoc-ref opts 'substitute-urls) > - #:offload? (assoc-ref opts 'offload?) > + #:offload? (and (assoc-ref opts 'offload?) > + (not (assoc-ref opts 'keep-failed?)= )) > #:max-silent-time (assoc-ref opts 'max-silent-time) > #:timeout (assoc-ref opts 'timeout) > #:print-build-trace (assoc-ref opts 'print-build-tra= ce?) > -- > 2.24.0 >=20 >=20 >=20 >=20