From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 23 22:46:56 2019 Received: (at 38309) by debbugs.gnu.org; 24 Nov 2019 03:46:56 +0000 Received: from localhost ([127.0.0.1]:58048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYirI-0007pV-Gn for submit@debbugs.gnu.org; Sat, 23 Nov 2019 22:46:53 -0500 Received: from mail-qv1-f68.google.com ([209.85.219.68]:45868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYiqW-0007nw-1e for 38309@debbugs.gnu.org; Sat, 23 Nov 2019 22:46:23 -0500 Received: by mail-qv1-f68.google.com with SMTP id d12so2472299qvv.12 for <38309@debbugs.gnu.org>; Sat, 23 Nov 2019 19:45:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=HT9WuZAhPv98Vo4fnRiF0FOqrUaf4s8XCrnUicXzzWw=; b=NKde9pUe1gjIQbhrgHjf4qcgeqqQQMy5LUHVM6M5/B5UDagj/NRtwvnx99iJ3Ifffo MwReH89kywJHjkOVQfwBqNuvz1H6YZnvwJH/cu1oCHXR9R/4mLJu2ITg1LjUJes6c/+4 OUcE/p/ayG8USdSjA7tsJiBKQCLRDnQxRrgjTnNcrnxaEhmw9JtMx2hTe+2FZzyF954N XK2UctagS8xpbwa/xVtRdX/HjkwO6jZjSsXVnbrDRzrjCBYeMtCMgbA2RwPNtMKr7esh ehowtDeb1UuYZ8pR8hiTlXKK7MFVL9HjeubBRFIX36DJtZk5+37J1dVHu1UcCkjgRYZp htqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=HT9WuZAhPv98Vo4fnRiF0FOqrUaf4s8XCrnUicXzzWw=; b=DfIBCaWk8aHP6LkQecoozIBpss2KpqqOIc+szpHIfQ12jcpjal7uv8NTQk/A84ilL3 FAWBsNGauTRXIC1j37THu/bBIwedrXJegaeO8nui8mk+6I+GQH9XRo4EeMI3t1qvffRQ Kh39ZK4pqA8qGG3SwyEtLDDhY4YfdrzSGn6axoSHeuTpWc2zkSdBoD/8dUd1ED6LWvoA C3/W8awMiGmXoYpOknoVgthtUax9CUrxsKYrfWBlq72PlsKxWIawoJEY+0ED8mzAJ5uJ EGlP9KMsUNbkRW8lLBR9QaP0CGswLe0IfdXUSuAJzG4X3YyBVmxD+D6escpBOwoiJtYG 5GFw== X-Gm-Message-State: APjAAAUnMWlHlJufv2i4HPLo5TDXfnyZb0MZjjK6cjkBLxzvNmZ2rbh8 W0FXbT+YeKOj45EKNr6u4zIhA9r/ X-Google-Smtp-Source: APXvYqwohw3AIqUqGnqLWZFcHsEZyTM8DJHmQfLeeByOuYDY17o3sShjs5HGy9CWO4L/GxiF2rA5Ng== X-Received: by 2002:a05:6214:1051:: with SMTP id l17mr10128333qvr.60.1574567154093; Sat, 23 Nov 2019 19:45:54 -0800 (PST) Received: from x200 ([207.35.95.252]) by smtp.gmail.com with ESMTPSA id o70sm1309379qke.47.2019.11.23.19.45.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Nov 2019 19:45:53 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#38309: Recent $EMACSLOADPATH changes crash gnome-session References: <87y2w8vzeq.fsf@lassieur.org> <8736egaw7g.fsf@gmail.com> <87k17rvmfw.fsf@gmail.com> <87eexy1nah.fsf@gnu.org> Date: Sun, 24 Nov 2019 12:45:51 +0900 In-Reply-To: <87eexy1nah.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 23 Nov 2019 19:05:10 +0100") Message-ID: <87d0diuec0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38309 Cc: Mathieu Othacehe , 38309@debbugs.gnu.org, a@ajgrf.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Ludovic Court=C3=A8s writes: > Hi Maxim, > > Maxim Cournoyer skribis: > >> Really sorry about this ugly regression :-/. > > Should we revert 47b3b4c2aa49e21f4cc32c97ff7bbbd069bb849c so we can > address this without pressure in the meantime? > > I think I missed the discussions around this patch, but we should get > Alex Kost into the loop (Alex did the initial work in that area, if I=E2= =80=99m > not mistaken.) > > Thanks, > Ludo=E2=80=99. There would be a couple more commits to include in the revert to undo the changes (one to the build system, others to adapt the renaming of the emacs-set-load-path phase for some packages: --8<---------------cut here---------------start------------->8--- 63edbb65e4 * origin/master gnu: emacs-protobuf-mode: Rename the set-emacs-l= oad-path phase. ffb2316548 * gnu: emacs-erlang: Rename the set-emacs-load-path phase. ed94123667 * gnu: emacs-pdf-tools: Adapt phase name. 418febb54f * gnu: emacs-scel: Fix build. 1bb39982f1 * gnu: emacs-realgud: Fix build. c51d4c7746 * gnu: emacs-pdf-tools: Fix build. b44357d02a * gnu: emacs-forge: Fix build. 47b3b4c2aa * gnu: emacs: Adapt the autoloads auxiliary code to use EMACSLOA= DPATH. e1d31e6457 * build-system: emacs: Simplify the SET-EMACS-LOAD-PATH phase. 215a45d9b8 * gnu: emacs: Locate Elisp libraries via EMACSLOADPATH. --8<---------------cut here---------------end--------------->8--- The bug in questino seems to have to do with a regression in recent versions PCRE, that trigger a crash on large environment variables as reported in [0]. There's a new version of PCRE2 (10.34) available; but I'm unsure if it addresses this particular problem: https://pcre.org/changelog.txt. If it doesn't we should report the problem to them. This could happen with any other environment variable than EMACSLOADPATH; it's just a matter of having an environment variable grow sufficiently long to trigger it. I'm testing a patch that may workaround this problem successfully right now (that would reduce the length of EMACSLOADPATH) I'll send an incomplete patch shortly for discussing the idea or testing. In case it's not clear; I'd rather workaround the issue or have it fixed at its source, ideally. WDYT? Maxim [0] https://bugzilla.redhat.com/show_bug.cgi?id=3D1430103