From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 14:54:49 2019 Received: (at 38304) by debbugs.gnu.org; 20 Nov 2019 19:54:49 +0000 Received: from localhost ([127.0.0.1]:50953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXW3t-00088O-2z for submit@debbugs.gnu.org; Wed, 20 Nov 2019 14:54:49 -0500 Received: from flashner.co.il ([178.62.234.194]:54254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXW3o-000886-Vv for 38304@debbugs.gnu.org; Wed, 20 Nov 2019 14:54:47 -0500 Received: from localhost (unknown [141.226.13.108]) by flashner.co.il (Postfix) with ESMTPSA id 0CFC1401AA for <38304@debbugs.gnu.org>; Wed, 20 Nov 2019 19:54:38 +0000 (UTC) Date: Wed, 20 Nov 2019 21:54:08 +0200 From: Efraim Flashner To: 38304@debbugs.gnu.org Subject: Re: [bug#38304] [PATCH]: Make more services one-shot Message-ID: <20191120195408.GW15074@E5400> References: <20191120194544.GV15074@E5400> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZGDvG9BNY5+B3nxW" Content-Disposition: inline In-Reply-To: <20191120194544.GV15074@E5400> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 User-Agent: Mutt/1.12.2 (2019-09-21) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 38304 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --ZGDvG9BNY5+B3nxW Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 20, 2019 at 09:45:44PM +0200, Efraim Flashner wrote: > After changing the sysctl service to use one-shot I found 3 more that > look like they'd be good choices. >=20 Actually, it looks like agetty and mingetty both rely on the host-name service, so that one doesn't look like a good choice after all. > From 64126d7a861a415bf4faafb30687928742db4f2b Mon Sep 17 00:00:00 2001 > From: Efraim Flashner > Date: Wed, 20 Nov 2019 21:36:56 +0200 > Subject: [PATCH 1/3] services: host-name: Make service one-shot. >=20 > * gnu/services/base.scm (host-name-service-type): Remove 'respawn?' > keyword from shepherd-service-type, add 'one-shot?'. > --- > gnu/services/base.scm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/gnu/services/base.scm b/gnu/services/base.scm > index b1eff89ecc..7cd42bb30a 100644 > --- a/gnu/services/base.scm > +++ b/gnu/services/base.scm > @@ -705,7 +705,7 @@ to add @var{device} to the kernel's entropy pool. Th= e service will fail if > (provision '(host-name)) > (start #~(lambda _ > (sethostname #$name))) > - (respawn? #f))))) > + (one-shot? #t))))) > =20 > (define (host-name-service name) > "Return a service that sets the host name to @var{name}." > --=20 > 2.24.0 >=20 > From 6c13de1914503afb3533a0fe032b4db767011874 Mon Sep 17 00:00:00 2001 > From: Efraim Flashner > Date: Wed, 20 Nov 2019 21:38:18 +0200 > Subject: [PATCH 2/3] services: console-keymap-service-type: Make service > one-shot. >=20 > * gnu/services/base.scm (console-keymap-service-type): Remove 'respawn?' > keyword from shepherd-service-type, add 'one-shot?'. > --- > gnu/services/base.scm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/gnu/services/base.scm b/gnu/services/base.scm > index 7cd42bb30a..022bb501ba 100644 > --- a/gnu/services/base.scm > +++ b/gnu/services/base.scm > @@ -746,7 +746,7 @@ to add @var{device} to the kernel's entropy pool. Th= e service will fail if > (start #~(lambda _ > (zero? (system* #$(file-append kbd "/bin/loadkeys") > #$@files)))) > - (respawn? #f))))) > + (one-shot? #t))))) > =20 > (define-deprecated (console-keymap-service #:rest files) > #f > --=20 > 2.24.0 >=20 > From 153d02caa1333788df435ca4ffbf915c50d9cb01 Mon Sep 17 00:00:00 2001 > From: Efraim Flashner > Date: Wed, 20 Nov 2019 21:40:50 +0200 > Subject: [PATCH 3/3] services: console-font-shepherd-services: Make servi= ce > one-shot. >=20 > * gnu/services/base.scm (console-font-shepherd-services): Remove 'stop' > and 'respawn?' keywords from shepherd-service-type, add 'one-shot?'. > --- > gnu/services/base.scm | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/gnu/services/base.scm b/gnu/services/base.scm > index 022bb501ba..cef2d4cb2b 100644 > --- a/gnu/services/base.scm > +++ b/gnu/services/base.scm > @@ -797,8 +797,7 @@ to add @var{device} to the kernel's entropy pool. Th= e service will fail if > "-C" #$device #$font)) > ((0 71) #t) > (else #f)))) > - (stop #~(const #t)) > - (respawn? #f))))) > + (one-shot? #t))))) > tty+font)) > =20 > (define console-font-service-type > --=20 > 2.24.0 >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --ZGDvG9BNY5+B3nxW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl3Vmd8ACgkQQarn3Mo9 g1Gw+g/+Okj7lvNo8Y6JZIB5h1QAaGkGy7BARklokYkeTKRZ+vsUjz7+OBBder4M QrDO7aDhpP088on5/f897u7mfTxG+pkS+elKtfwd6S6PWcQEEufOCEde5gIiJgUJ FWHjbpgv/TWvyT2gaCiFRQwPSWdqB5/WCwF4YGI0pAiFAkUPI5SFfXGSgwRxTXfX p8DO/d3nKvRjX1C+DZQcxxdujRySav90v11+7bcw9QranRnzLnqKmJU4bASXx+l/ jfTt4alJ4F6JSpzQ8yjP35JqHpxQutMYVrYhyQpN8AOXlIdEIEp7Uio8ljA9wHd1 JFnWvKZ/ASz+GBA9P7H/qJ3baAksBGSzQXTB3fBqAeqWJgaL61DROXBYKKMj3++K 03aqZAkZ/H6DF+zLevCFjY+fo/v7Q9Ld0Y83rW5+Zz9RKtGfVq+d2yX/D44X25xa AfbTK+cmuq8WxCxxzuA8XDvfb53tl5sgn0Ld0r33VC6j/dM3yWk47cyAzO0RT1C9 zc1rmpr+Lgl3SSezAlam0RDqnoKoQd3aHgwrxRvXRxzaiOazPZ1eunDiDKHMRVaE DjVAtb0ym1VX6uWB5DuBd62F09PK4TCuioc2ps8bPevOJsAEKgIY0Up6Eq0dI6tB glFThR9GJbYwUS1JjJzP9ls9ydw6X0BzuNNj6uCn3iY8AYEPOfQ= =GvYp -----END PGP SIGNATURE----- --ZGDvG9BNY5+B3nxW--