From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 06 08:37:03 2019 Received: (at 37535) by debbugs.gnu.org; 6 Oct 2019 12:37:03 +0000 Received: from localhost ([127.0.0.1]:45758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iH5mZ-0002Ld-1L for submit@debbugs.gnu.org; Sun, 06 Oct 2019 08:37:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iH5mW-0002L3-Dp for 37535@debbugs.gnu.org; Sun, 06 Oct 2019 08:37:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55866) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iH5mR-0005OA-9f; Sun, 06 Oct 2019 08:36:55 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=40704 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iH5mQ-0003u2-MY; Sun, 06 Oct 2019 08:36:55 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: "Hamzeh Nasajpour" Subject: Re: [bug#37535] [PATCH] gnu: Add python-flask-cors. References: <3f1fdf71-c664-4fb1-8ba1-f82e2d5f39b7@www.fastmail.com> <87h84wnoh9.fsf@gnu.org> Date: Sun, 06 Oct 2019 14:36:53 +0200 In-Reply-To: <87h84wnoh9.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 28 Sep 2019 22:40:50 +0200") Message-ID: <87k19idp96.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37535 Cc: 37535@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ping! :-) Ludovic Court=C3=A8s skribis: > Hi Hamzeh, > > "Hamzeh Nasajpour" skribis: > >> * gnu/packages/python-web.scm (python-flask-cors): New variable. > > [...] > >> +(define-public python-flask-cors >> + (package >> + (name "python-flask-cors") >> + (version "3.0.7") > > The indentation is different from what we usually do. Could you run > ./etc/indent-code.el as noted at > ? > >> + (arguments >> + `(#:tests? #f)) > > Could you try to run the test suite or, as a last resort, add a comment > explaining why it is disabled? > >> + (home-page "https://github.com/corydolphin/flask-cors") >> + (synopsis "A Flask extension adding a decorator for CORS support") >> + (description >> + "A Flask extension for handling Cross Origin Resource Sharing (COR= S),=20 >> +making cross-origin AJAX possible.") > > Please fix the issue reported by =E2=80=98guix lint=E2=80=99 for the syno= psis and make a > full sentence for the description. See > . > > Could you send an updated patch? > > Thanks, > Ludo=E2=80=99.