From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 28 16:40:58 2019 Received: (at 37535) by debbugs.gnu.org; 28 Sep 2019 20:40:59 +0000 Received: from localhost ([127.0.0.1]:51345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEJWU-0001Ed-LK for submit@debbugs.gnu.org; Sat, 28 Sep 2019 16:40:58 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:56916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEJWQ-0001EP-O5 for 37535@debbugs.gnu.org; Sat, 28 Sep 2019 16:40:55 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 1A6438FE66; Sat, 28 Sep 2019 22:40:53 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0Bzp5aON29Ur; Sat, 28 Sep 2019 22:40:51 +0200 (CEST) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 6665F8FE90; Sat, 28 Sep 2019 22:40:51 +0200 (CEST) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: "Hamzeh Nasajpour" Subject: Re: [bug#37535] [PATCH] gnu: Add python-flask-cors. References: <3f1fdf71-c664-4fb1-8ba1-f82e2d5f39b7@www.fastmail.com> Date: Sat, 28 Sep 2019 22:40:50 +0200 In-Reply-To: <3f1fdf71-c664-4fb1-8ba1-f82e2d5f39b7@www.fastmail.com> (Hamzeh Nasajpour's message of "Sat, 28 Sep 2019 01:46:24 +0330") Message-ID: <87h84wnoh9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 37535 Cc: 37535@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi Hamzeh, "Hamzeh Nasajpour" skribis: > * gnu/packages/python-web.scm (python-flask-cors): New variable. [...] > +(define-public python-flask-cors > + (package > + (name "python-flask-cors") > + (version "3.0.7") The indentation is different from what we usually do. Could you run ./etc/indent-code.el as noted at ? > + (arguments > + `(#:tests? #f)) Could you try to run the test suite or, as a last resort, add a comment explaining why it is disabled? > + (home-page "https://github.com/corydolphin/flask-cors") > + (synopsis "A Flask extension adding a decorator for CORS support") > + (description > + "A Flask extension for handling Cross Origin Resource Sharing (CORS= ),=20 > +making cross-origin AJAX possible.") Please fix the issue reported by =E2=80=98guix lint=E2=80=99 for the synops= is and make a full sentence for the description. See . Could you send an updated patch? Thanks, Ludo=E2=80=99.