From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 01 17:34:34 2019 Received: (at 37444) by debbugs.gnu.org; 1 Oct 2019 21:34:34 +0000 Received: from localhost ([127.0.0.1]:35011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFPmz-00074e-UU for submit@debbugs.gnu.org; Tue, 01 Oct 2019 17:34:34 -0400 Received: from mx1.riseup.net ([198.252.153.129]:50902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFPmx-00074W-Pw for 37444@debbugs.gnu.org; Tue, 01 Oct 2019 17:34:32 -0400 Received: from bell.riseup.net (bell-pn.riseup.net [10.0.1.178]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id 46jXbV75K6zDtVV; Tue, 1 Oct 2019 14:34:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1569965671; bh=NY4lHfo6KSXzm73xcpR6q348biYA21BGn86v+OpP0As=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=F2rp+d9hOHqtQUia1juLO0ZPGZ4SCwo7qJKKzNyF1pmmLEEzU/30NQ0zhm03tFuBR mcsjsZio0aCfwdnbG2k+27wrXW+hC+ubsDAnytrmmDDJdgcoEOSnzZLryIig1cVLe1 xKrCCBLqYpDkT7cu+eigoiOFo5G9oDqWUCYzYfsI= X-Riseup-User-ID: 5C9BE822AD8E8EB12EC09E0576C773AB4304446CF7D64CF9975AF5DAFA16532C Received: from [127.0.0.1] (localhost [127.0.0.1]) by bell.riseup.net (Postfix) with ESMTPSA id 46jXbV65qLzJsBk; Tue, 1 Oct 2019 14:34:30 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Date: Tue, 01 Oct 2019 14:34:30 -0700 From: Martin Becze To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Subject: Re: [bug#37444] [PATCH] added aerc, a simple email client and its dependcies In-Reply-To: <87blv7pfdi.fsf@gnu.org> References: <20190918082313.3514-1-mjbecze@riseup.net> <87woe6nfka.fsf@elephly.net> <574a6c68d80bb669bbbaac7ebede8f9c@riseup.net> <87blv7pfdi.fsf@gnu.org> Message-ID: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37444 Cc: Ricardo Wurmus , 37444@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2019-09-26 09:37, Ludovic Courtès wrote: > Hi Martin, > > Martin Becze skribis: > >> On 2019-09-18 09:01, Ricardo Wurmus wrote: >>> Hi Martin, >>> >>>> This adds aerc, which is a terminal based email client written in go. >>> >>> Thank you for your patch! >>> >>> Could you please separate the independent changes into separate commits >>> and add commit summaries? For example, the update of >>> go-github-com-mitchellh-go-homedir should be done separately. >>> >>> Please also explain why “inputs” had to be changed to >>> “propagated-inputs” in some packages, and mention these kind of changes >>> in the commit summary. >>> >>> Thanks! >> >> just bumping, updated patch has been made and split into commits now. >> https://issues.guix.gnu.org/issue/37444 let me know if that is ok > > Like Ricardo mentioned, it would be great if patch #1 were split into > several commits, one per new package. That’s how we usually do it. > > I saw your commit logs provide explanations. However, they are all on > the “subject line” of the commit log. Could you take a look at > > regarding the format of commit logs, or run, say, “git log > gnu/packages/golang.scm” to view examples? > > I could do these changes on your behalf, but I’d rather let you do it to > make sure I don’t mess up or misrepresent what you did! > > Thanks, > Ludo’. ohhh i think i finally figured it out. (but not how to use add-change-log-entry, it looks like ppl are using that to generate the messages somehow?) anyways, v4 incoming!