From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 18 05:20:50 2019 Received: (at 37444) by debbugs.gnu.org; 18 Sep 2019 09:20:50 +0000 Received: from localhost ([127.0.0.1]:53592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAW8o-0001fg-8V for submit@debbugs.gnu.org; Wed, 18 Sep 2019 05:20:50 -0400 Received: from mx1.riseup.net ([198.252.153.129]:57236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAW8m-0001fW-C7 for 37444@debbugs.gnu.org; Wed, 18 Sep 2019 05:20:49 -0400 Received: from bell.riseup.net (bell-pn.riseup.net [10.0.1.178]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id 07B0D1B944B; Wed, 18 Sep 2019 02:20:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1568798446; bh=SHKDx+dvZ4lMzZ4w1hUiTmOK0bQvTE6qzddXL6wH7rQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LqKRm+04dTI/dSSnujPmukqQxHEhxK1eEkQQ9yKkWE8gGnZ5k5cCIIOV1N5W6mNjK 0nsk3jIv92w7SNPP6hPOd32uvFBbZwBTI0psJF32jUG4BNg2PNjiBZsTe8tozfv2m+ erjWNMLcT7TSUyTZuTsV9J9ePUeAmbrBQBdHWWnE= X-Riseup-User-ID: ECAC3B3E95E8075D548A29702D93807696ADC66A30C8D5FCC9D1F322B9674E2D Received: from [127.0.0.1] (localhost [127.0.0.1]) by bell.riseup.net (Postfix) with ESMTPSA id 15D4D2241AE; Wed, 18 Sep 2019 02:20:27 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Date: Wed, 18 Sep 2019 02:20:26 -0700 From: Martin Becze To: Ricardo Wurmus Subject: Re: [bug#37444] [PATCH] added aerc, a simple email client and its dependcies In-Reply-To: <87woe6nfka.fsf@elephly.net> References: <20190918082313.3514-1-mjbecze@riseup.net> <87woe6nfka.fsf@elephly.net> Message-ID: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37444 Cc: 37444@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Certainly! I'll get that up later today. On the propagated-inputs issue. So I might be wrong here. But since all the go libraries are source only it doesn't matter to the end result if the are propagated or not if the libraries are used as `native-inputs`.. they shouldn't be left lying around (I think?). Now the reason why the need to be propagated is that when the go compiler go to compile the top level app (aerc) it needs to have in it's GOPATH all of the dependencies and the dependencies of the dependencies. The other way to do it is to put all of dependencies and the dependencies of the dependencies in the native-input. But that didn't seem right to me. Let me know what you think! On 2019-09-18 09:01, Ricardo Wurmus wrote: > Hi Martin, > >> This adds aerc, which is a terminal based email client written in go. > > Thank you for your patch! > > Could you please separate the independent changes into separate commits > and add commit summaries? For example, the update of > go-github-com-mitchellh-go-homedir should be done separately. > > Please also explain why “inputs” had to be changed to > “propagated-inputs” in some packages, and mention these kind of changes > in the commit summary. > > Thanks!