From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 16 17:03:32 2019 Received: (at 36777-done) by debbugs.gnu.org; 16 Aug 2019 21:03:32 +0000 Received: from localhost ([127.0.0.1]:55022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyjNk-0004qZ-KJ for submit@debbugs.gnu.org; Fri, 16 Aug 2019 17:03:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyjNi-0004qL-T3 for 36777-done@debbugs.gnu.org; Fri, 16 Aug 2019 17:03:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59241) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hyjNd-0003F3-DW; Fri, 16 Aug 2019 17:03:25 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=50860 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hyjNc-0003WD-Gx; Fri, 16 Aug 2019 17:03:25 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Carl Dong Subject: Re: bug#36777: Guix Inferiors: Curious incorrect derivation output bug References: <875znps08a.fsf@gnu.org> <1WSz93jYl9XxYywM_b-gQYV4SiIG9VyTXLYpj4bueFcBZByRMIdXQNnVY4YDnbH_hPe4y_ZDjl7lIgyvynH8J85NtO93namyeEVMU7Lj9WY=@carldong.me> <87wog3i2sj.fsf@gnu.org> <87r26bi1x2.fsf@gnu.org> Date: Fri, 16 Aug 2019 23:03:23 +0200 In-Reply-To: (Carl Dong's message of "Tue, 30 Jul 2019 18:36:01 +0000") Message-ID: <87h86gg6w4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36777-done Cc: "36777@debbugs.gnu.org" <36777-done@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Carl, Carl Dong skribis: > Yes! The patch actually fixed the problem when applied on top of 5cf4b26d= 52bcea382d98fb4becce89be9ee37b55! [...] > Not sure what the next steps are for this, but I'd very much like to unde= rstand where this went wrong. Perhaps we could write tests for this so it d= oesn't happen in the future for releases. Yup, I understood when this could happen (if multiple inputs of a derivation are =E2=80=9Cfixed-output=E2=80=9D derivations leading to the sa= me output), wrote a test for that, and came up with a simpler fix in commit 268896444bed7b958add74b2e1e86ff802c5f5cb. Let me know if anything is amiss! Thanks for testing the patch, Ludo=E2=80=99.