From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 09:00:01 2019 Received: (at 36602) by debbugs.gnu.org; 14 Jul 2019 13:00:01 +0000 Received: from localhost ([127.0.0.1]:43981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hme6j-00021h-3u for submit@debbugs.gnu.org; Sun, 14 Jul 2019 09:00:01 -0400 Received: from lepiller.eu ([89.234.186.109]:34744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hme6h-00021X-Cs for 36602@debbugs.gnu.org; Sun, 14 Jul 2019 09:00:00 -0400 Received: from sybil.lepiller.eu (89-92-10-229.hfc.dyn.abo.bbox.fr [89.92.10.229]) by lepiller.eu (OpenSMTPD) with ESMTPSA id ddca519c (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sun, 14 Jul 2019 12:59:51 +0000 (UTC) Date: Sun, 14 Jul 2019 14:59:45 +0200 From: Julien Lepiller To: Robert Vollmert Subject: Re: [bug#36602] guix/build/json.scm Message-ID: <20190714145945.65841b36@sybil.lepiller.eu> In-Reply-To: <055006A2-DA0C-4570-A9D0-4A9FFD5A6037@vllmrt.net> References: <20190711184653.3f6956b8@sybil.lepiller.eu> <055006A2-DA0C-4570-A9D0-4A9FFD5A6037@vllmrt.net> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36602 Cc: 36602@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Le Sun, 14 Jul 2019 13:09:18 +0200, Robert Vollmert a =C3=A9crit : > Hi, >=20 > just had a look at 09a1f92f61d1ab11d2cf9f7a0983f4fc9f436f57, some > questions: >=20 > - the link to > https://github.com/cwebber/activitystuff/blob/master/activitystuff/contri= b/json.scm > is a 404, and I can=E2=80=99t find (ice-9 json) elsewhere (also, shouldn= =E2=80=99t > cwebber be listed in the copyright line?) > - how does this embedded json parsing module differ from (json > parser) as used by the cargo build system? wouldn=E2=80=99t it be better = to > have both use the same json modules? >=20 > Cheers > Robert >=20 You're right, I thought we didn't use guile-json, but since we already use it in the cargo build system, I removed (guix build json) and fixed the node-build-system to use (json parser) instead. I tested a few packages, so it should be working. I pushed the changes in 8eb0ba532ebbebef23180e666e0607ea735f9c1a.