From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 22 10:11:25 2019 Received: (at 36440) by debbugs.gnu.org; 22 Jul 2019 14:11:25 +0000 Received: from localhost ([127.0.0.1]:33456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpZ2D-0005tI-6K for submit@debbugs.gnu.org; Mon, 22 Jul 2019 10:11:25 -0400 Received: from m4s11.vlinux.de ([83.151.27.109]:41962 helo=bjoernhoefling.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpZ2A-0005t8-NN for 36440@debbugs.gnu.org; Mon, 22 Jul 2019 10:11:23 -0400 Received: from alma-ubu (p57B525BE.dip0.t-ipconnect.de [87.181.37.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 369BA3F845; Mon, 22 Jul 2019 16:11:21 +0200 (CEST) Date: Mon, 22 Jul 2019 16:11:20 +0200 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= To: John Soo Subject: Re: [bug#36440] [PATCH] Add FreeCAD Message-ID: <20190722161120.36fd0942@alma-ubu> In-Reply-To: References: X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/cFxNcKccpkVN3mk5ZNaiqGP"; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36440 Cc: 36440@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Sig_/cFxNcKccpkVN3mk5ZNaiqGP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 30 Jun 2019 02:39:52 +0000 John Soo wrote: > Hi all, >=20 > I've done linting, and indentation checks. There are still some > issues with licenses that I've marked and I don't know where to put > the changes that I've included in llvm.scm. Also I discovered some > non-determinism in the build of freecad just now. I thought it would > be good to share my work, though. It's been long enough. >=20 > - John Hi John, this is not a easy "guix import" package. Thanks for looking into this. Here are some remarks from my side: Commit-log: You have a summary line, but missing this: * gnu/package/...scm (freecad): New variable. This holds for all packages. See the manual (https://guix.gnu.org/manual/en/guix.html#Submitting-Patches) and other commits as reference. You might like to work with magit and yasnippets to automate this. Add a copyright line for yourself to all files you touched. For the dependencies, you often used commits from the git/hg repository instead of a released version. Was there specific reason for that? If so, please add a comment on why you need this specific version. For some (all), I found out that a proper release was only created after you submitted/edited your patch. Maybe you can give it a try with the released versions? I wanted to give it a try for myself but failed: I could not build qtwebkit locally, and no substitutes are available. I don't want to hold back my comments any longer, so I postponed trying it out. Also, I wanted to compare with the AppPack provided by FreeCAD, but I wasn't able to extract it: I did not want to do it on my machine directly, because you use the AppPack executable to extract it! And it did not work in a Guix-VM, probably due to some "standard" library paths being expected. We should fix this package and then suggest them using Guix or at least "guix pack" for really relocatable BLOBs :-) coin3D: There are two binaries in the source repository: ./cfg/csubst.exe ./cfg/wrapmsvc.exe Also the .hg directory is included. Could you please remove them with "snippets"? You can search for "snippet" to find examples for that. I did it like that: + (modules '((guix build utils))) + (snippet + '(begin + (delete-file-recursively ".hg") + (for-each delete-file + '("cfg/csubst.exe" + "cfg/wrapmsvc.exe")) + #t)))) soqt: Same snippets apply here too. soqt: There is a 1.6.0-package available since some hours. Would you like to use this? Also, they say it is superseeded by Quarter. Would it be possible/better to use this one? Is there anything known from FreeCAD side? llvm-toolchain-6: I haven't looked into that yet. pyside2/shiboken: There are two Qt-bindings for Python: PyQt and PySide2. As we have PyQt already in=20 gnu/packages/qt.scm, I think it would make sense to move Pyside2 and its binding generator Shiboken into that package instead of python-xyz.scm. PySide2/Qt version: We currently have 5.11.3 in Guix. 5.12 is the current LTS available and 5.13 is also out since June. The PySide homepage (https://wiki.qt.io/Qt_for_Python) says: The module was released mid June 2018 as a Technical Preview (supporting Qt 5.11), and it was officially released without the Technical Preview tag, in December 2018 for Qt 5.12.=20 What does it mean if we use it still with 5.11? Or do we need to update to 5.12 first? I wonder if we need the dependency on qtwebkit or if we can get rid of this= , but I haven't investigated yet. medfile: Is there a specific reason you chose 3.x, instead of the available 4.0.0? If you, could you add a comment of why? License is GPLv3+ libarea: Also licensed under GPL v3 (files under "pocket" directory). freecad: Can you use the releasted sources instead of the git-version? Bj=C3=B6rn --Sig_/cFxNcKccpkVN3mk5ZNaiqGP Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQQiGUP0np8nb5SZM4K/KGy2WT5f/QUCXTXECAAKCRC/KGy2WT5f /SVBAJ9IPrN06JlYfRl6d8qyfkDRdsooIACffCkztLQf70aqrbOMTVXyaeHUqRg= =sjg+ -----END PGP SIGNATURE----- --Sig_/cFxNcKccpkVN3mk5ZNaiqGP--