From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 02 03:06:47 2019 Received: (at 36440) by debbugs.gnu.org; 2 Jul 2019 07:06:47 +0000 Received: from localhost ([127.0.0.1]:46490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiCsI-00023I-QC for submit@debbugs.gnu.org; Tue, 02 Jul 2019 03:06:47 -0400 Received: from m4s11.vlinux.de ([83.151.27.109]:41122 helo=bjoernhoefling.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiCsH-000239-KJ for 36440@debbugs.gnu.org; Tue, 02 Jul 2019 03:06:46 -0400 Received: from alma-ubu (pD951F287.dip0.t-ipconnect.de [217.81.242.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 554893F945; Tue, 2 Jul 2019 09:06:43 +0200 (CEST) Date: Tue, 2 Jul 2019 09:06:42 +0200 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= To: John Soo Subject: Re: [bug#36440] [PATCH] Add FreeCAD Message-ID: <20190702090642.2e07bc01@alma-ubu> In-Reply-To: References: X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/E3=s.8TO8.Mx5SPv7Mozry9"; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36440 Cc: 36440@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Sig_/E3=s.8TO8.Mx5SPv7Mozry9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 30 Jun 2019 02:39:52 +0000 John Soo wrote: > Hi all, >=20 > I've done linting, and indentation checks. There are still some > issues with licenses that I've marked and I don't know where to put > the changes that I've included in llvm.scm. Also I discovered some > non-determinism in the build of freecad just now. I thought it would > be good to share my work, though. It's been long enough. >=20 > - John Hi John, thank you very much for working on FreeCAD! And thanks for sharing this work even if it is not 100% polished. The first thing I noticed is that you packed everything into one commit. Could you please split it up in one commit per added/modified package? That's the usual way Guix expects commits, and it would make the reviewing easier, you can concentrate on each package as a reviewer and you better see the dependency structure right away. Thanks, Bj=C3=B6rn --Sig_/E3=s.8TO8.Mx5SPv7Mozry9 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQQiGUP0np8nb5SZM4K/KGy2WT5f/QUCXRsCggAKCRC/KGy2WT5f /ekmAJ9duHFOgQ9bvyHczKPfvT+apYvEOwCeK6g7D+0KYJFjCivWPVhCINsmbxw= =SvwO -----END PGP SIGNATURE----- --Sig_/E3=s.8TO8.Mx5SPv7Mozry9--