On Sun, 30 Jun 2019 02:39:52 +0000 John Soo wrote: > Hi all, > > I've done linting, and indentation checks. There are still some > issues with licenses that I've marked and I don't know where to put > the changes that I've included in llvm.scm. Also I discovered some > non-determinism in the build of freecad just now. I thought it would > be good to share my work, though. It's been long enough. > > - John Hi John, thank you very much for working on FreeCAD! And thanks for sharing this work even if it is not 100% polished. The first thing I noticed is that you packed everything into one commit. Could you please split it up in one commit per added/modified package? That's the usual way Guix expects commits, and it would make the reviewing easier, you can concentrate on each package as a reviewer and you better see the dependency structure right away. Thanks, Björn