Installer first check for wifi then format the disk

  • Done
  • quality assurance status badge
Details
3 participants
  • juh
  • Ludovic Courtès
  • Tobias Geerinckx-Rice
Owner
unassigned
Submitted by
juh
Severity
normal
Merged with
J
J
juh wrote on 25 May 2019 16:07
(address . bug-guix@gnu.org)
d9db656a-8719-6246-586a-21f306b8d085@mailbox.org
Hi all,

can you change the installer steps and check for wifi at first and then
format the disks?

I inserted the usb stick and started the installation only to see that
no wifi was discovered. Sadly the disks now are formatted and I have to
reinstall my old OS.

juh
T
T
Tobias Geerinckx-Rice wrote on 8 Jun 2019 17:49
(no subject)
(name . GNU bug tracker automated control server)(address . control@debbugs.gnu.org)
87v9xg5b6p.fsf@nckx
reassign 35901 guix-patches
merge 35901 36132
L
L
Ludovic Courtès wrote on 11 Jun 2019 10:02
Re: [bug#36132] [PATCH 1/2] installer: Partition as the last step.
(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)
878su87dn2.fsf@gnu.org
Hi!,

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

Toggle quote (7 lines)
> Multiple users have been understandably displeased after finding out
> that their network card was unsupported, and Internet access mandatory,
> after having already formatted their partitions.
>
> * gnu/installer.scm (installer-steps): Run the ‘partition’ step just
> before the ‘final’ one.

LGTM! Please add “Fixes http://bugs.gnu.org/35901.” in the log.

Should we also move “Network selection” above “Hostname”?

Thanks,
Ludo’.
L
L
Ludovic Courtès wrote on 11 Jun 2019 10:05
Re: [bug#36132] [PATCH 2/2] installer: Show, don't Hide.
(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)
8736kg7di3.fsf@gnu.org
Hi,

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

Toggle quote (5 lines)
> * gnu/installer/newt/user.scm (run-user-add-page): Change the input
> visibility checkbox's text to ‘Show’, and default to unchecked.
> * gnu/installer/newt/page.scm (run-input-page): Likewise.
> Rename INPUT-HIDE-CHECKBOX? argument to INPUT-SHOW-CHECKBOX?.

I think the argument should perhaps be ‘input-visibility-checkbox?’,
otherwise I find it a bit unclear (both before and after the patch
actually.)

Other than that LGTM, thank you!

Ludo’.
T
T
Tobias Geerinckx-Rice wrote on 26 Aug 2019 16:23
Re: [bug#36132] [PATCH 1/2] installer: Partition as the last step.
(name . Ludovic Courtès)(address . ludo@gnu.org)
87lfvgqa3y.fsf@nckx
Ludo',

Ludovic Courtès ???
Toggle quote (3 lines)
> LGTM! Please add “Fixes http://bugs.gnu.org/35901.” in the
> log.

Oh, bugger. This message got lost in my messy box (it floated
back to the top when I closed the bug). Sorry about that.

Toggle quote (2 lines)
> Should we also move “Network selection” above “Hostname”?

Perhaps! I'll fire up the installer again and see if anything new
seems odd/out of place after these few months.

Kind regards,

T G-R
-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXWPrUQAKCRANsP+IT1Vt
eQ1yAP0c6rMMB414vgJ8QQM6owjiHAvklmy5/nwSsW5Q7BuucAEA0on33OtTqi3P
Q/n5kUcCUX+W8zec0Val9oBuaTVXEAM=
=iq60
-----END PGP SIGNATURE-----

?