From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 08 03:57:41 2019 Received: (at 35813) by debbugs.gnu.org; 8 Sep 2019 07:57:41 +0000 Received: from localhost ([127.0.0.1]:38327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i6s4q-00019s-Rw for submit@debbugs.gnu.org; Sun, 08 Sep 2019 03:57:41 -0400 Received: from flashner.co.il ([178.62.234.194]:43366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i6s4o-00019b-80 for 35813@debbugs.gnu.org; Sun, 08 Sep 2019 03:57:39 -0400 Received: from localhost (unknown [188.120.128.191]) by flashner.co.il (Postfix) with ESMTPSA id 3A12F401E4; Sun, 8 Sep 2019 07:57:31 +0000 (UTC) Date: Sun, 8 Sep 2019 10:57:30 +0300 From: Efraim Flashner To: Brian Leung Subject: Re: [bug#35813] [PATCH] Add crate-recursive-import. Message-ID: <20190908075730.GA977@E5400> References: <20190808103956.GD5507@E2140> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7AUc2qLy4jB3hD7Z" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 User-Agent: Mutt/1.12.1 (2019-06-15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 35813 Cc: 35813@debbugs.gnu.org, Ivan Petkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --7AUc2qLy4jB3hD7Z Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable As a simple test I ran 'guix import crate encoding -r' and it gave me the 6 packages I expected. 'guix import crate winapi -r' only gave me rust-winapi, as the dependent crates are already packaged. When I tried 'guix import crate rand -r' it found the updated version and started importing all the new dependencies also. It looks good. I'm tempted to leave it running with 'guix import crate serde -r' just to see if we're ever going to make it there. I see that it imports A then B then C then D, and prints out D then C then B then A. For the one I tested with is still rust-encoding. I'll try my hand at ascii art: encoding | ------------------------------------------------------- | | | | | japanese korean simpchinese singlebyte tradchinese | | | | | ------------------------------------------------------- | encoding-tests import went encoding, japanese, tests, korean, simpchinese, singlebyte, tradchinese I think the only thing I would wish for would be to do tests, then the languages and then encoding (best for upstreaming one at a time), or to do them alphabetically (plop them in alphabetically all at once). This I'm happy to live without I think. The other thing was I ran 'guix import crate security-framework -r' and after ~40 crates it crashed on me with: web/http.scm:1186:15: In procedure read-response-line: Bad Read-Header-Line header: # and I would prefer to have the ~40 crates it did grab first to be printed out and not lost. Between these two I would like most to not lose the imported crates than worrying over the printed order. Great job! From what I've tested I think it's ready as-is and any changes would just be gravy. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --7AUc2qLy4jB3hD7Z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl10tGYACgkQQarn3Mo9 g1EKBxAAhZlAiOJPpc3Yu4Qg0hUegfq0tpMRIefiTZ+YNMmQeQ6A50UVOctwraJo 088Co86+EYIfWfDN43Dm78SrYEviE5rhVqpPbEaMQYKMpRyI2tGPHdLmOM0ijiZ0 UakCGakWcQhfKBwlqRxdKhimk0HU/7k0ruixbtAYHhsvflQ7guf5nziSxLccZgLq WLI34r7ZWB+VYeqqTZuaGOqnsEk1Y0+KESySkm2pi6sc2qImGuVqqtO+KXbCiAQq tOPorw+G/x3Wk71ebM1ZAKK+nVmZPya2eeFZvVvvAELM4eBOljfSpRTDQjGB/kFE Kgtuefh8WQdyPCuQGkeI+SRl/npQbrPelPbjF5tzdbGv0X766OPEFlY0VH3Q2bKg HVePtizoK0XYHrdVB+mBw5bA/qc8xsdrsSXpV3yy9x12OzPD5/RTJOdbgw56xHtX VAC+cQQCxOUXsBadge9iI9UrVP4GzPLcIXRADDxBzxnRUiHP4hbThQ2181dpol3w 9LXc84iE5tvZbGJJnl5a9q70ACtsvZ326ajSmzNXpMD6t5WCyk2qTwmeDfQ3CVbI PJ7xdx+mp1WRTiFSwtgqe8DqQ4dJ54hVqcOWZOwB6hT3IDuzh48ezNWrWMqc0yeE 1V1HJz5AsLBW+Ftcgk3NIc1IsdZ1q5+lDFfmhZkTDJLe7pLPgqc= =7hxM -----END PGP SIGNATURE----- --7AUc2qLy4jB3hD7Z--