From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 29 19:32:55 2019 Received: (at 35483) by debbugs.gnu.org; 29 Apr 2019 23:32:55 +0000 Received: from localhost ([127.0.0.1]:40116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLFlW-0005SN-MP for submit@debbugs.gnu.org; Mon, 29 Apr 2019 19:32:55 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:57124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLFlU-0005S7-8B for 35483@debbugs.gnu.org; Mon, 29 Apr 2019 19:32:53 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100e]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 986731AA54; Mon, 29 Apr 2019 16:32:45 -0700 (PDT) From: Vagrant Cascadian To: 35483@debbugs.gnu.org Subject: Re: gnu: u-boot-tools: Only run full test suite on x86. In-Reply-To: <87ef5lbh38.fsf@ponder> References: <87ef5lbh38.fsf@ponder> Date: Mon, 29 Apr 2019 16:32:40 -0700 Message-ID: <87pnp4wfon.fsf@ponder> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35483 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable I neglected to mention in my initial submission that the test suite has failed on non-x86 architectures since I started testing u-boot on Guix a year or so ago... It blocks working support for veyron-speedy/Asus C201, and that would be very nice to have fixed for 1.0, of course! I may need to update the patch to exclude i686-linux from the full test suite, as it seems with u-boot 2019.04 to also fail with 32-bit x86 making some 64-bit assumptions... Thanks for the review, if you can! live well, vagrant On 2019-04-28, Vagrant Cascadian wrote: > * gnu/packages/bootloaders (u-boot-tools)[check]: Remove x86 tests. > [check-x86]: New phase with x86 tests. > [patch]: Patch test-imagetools.sh to test binaries to be installed. > --- > gnu/packages/bootloaders.scm | 23 +++++++++++++++++------ > 1 file changed, 17 insertions(+), 6 deletions(-) > > diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm > index b4eabaea48..0cd72fb44c 100644 > --- a/gnu/packages/bootloaders.scm > +++ b/gnu/packages/bootloaders.scm > @@ -442,6 +442,10 @@ also initializes the boards (RAM etc).") > (("def test_ctrl_c") > "@pytest.mark.skip(reason=3D'Guix has problems with SIGIN= T') > def test_ctrl_c")) > + ;; Test against the tools being installed rather than tools= built > + ;; for "sandbox" target. > + (substitute* "test/image/test-imagetools.sh" > + (("BASEDIR=3Dsandbox") "BASEDIR=3D.")) > (for-each (lambda (file) > (substitute* file > ;; Disable signatures, due to GPL/Open= ssl > @@ -484,12 +488,19 @@ def test_ctrl_c")) > (delete 'check) > (add-after 'install 'check > (lambda* (#:key make-flags test-target #:allow-other-keys) > - (apply invoke "make" "mrproper" make-flags) > - (setenv "SDL_VIDEODRIVER" "dummy") > - (setenv "PAGER" "cat") > - (apply invoke "make" test-target make-flags) > - (symlink "build-sandbox_spl" "sandbox") > - (invoke "test/image/test-imagetools.sh")))))) > + (invoke "test/image/test-imagetools.sh"))) > + ;; Only run full test suite on x86 systems, as many tests ass= ume > + ;; x86. > + ,@(if (string-match "^(x86_64|i686)-linux" > + (or (%current-target-system) > + (%current-system))) > + '((add-after 'check 'check-x86 > + (lambda* (#:key make-flags test-target #:allow-othe= r-keys) > + (apply invoke "make" "mrproper" make-flags) > + (setenv "SDL_VIDEODRIVER" "dummy") > + (setenv "PAGER" "cat") > + (apply invoke "make" test-target make-flags)))) > + '())))) > (description "U-Boot is a bootloader used mostly for ARM boards. It > also initializes the boards (RAM etc). This package provides its > board-independent tools."))) > --=20 > 2.20.1 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCXMeJmAAKCRDcUY/If5cW qs4FAQCKXNiv9TLg2rclBDH1uyiuDNPcR3z7/ZgOOSQG6HO6pwD+Opfnfin+bJV/ wVR6f1yOYff//8PVGLTDgHHbRpd5MQY= =myC2 -----END PGP SIGNATURE----- --=-=-=--