From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 26 05:31:05 2020 Received: (at 34638) by debbugs.gnu.org; 26 Mar 2020 09:31:05 +0000 Received: from localhost ([127.0.0.1]:58117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jHOqv-0003Pa-Kg for submit@debbugs.gnu.org; Thu, 26 Mar 2020 05:31:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jHOqu-0003P8-9F for 34638@debbugs.gnu.org; Thu, 26 Mar 2020 05:31:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58700) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jHOqp-0002vE-5A; Thu, 26 Mar 2020 05:30:59 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=36482 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jHOqo-0005BG-5l; Thu, 26 Mar 2020 05:30:58 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Christopher Baines Subject: Re: [bug#34638] [PATCH v2 3/4] inferior: Add a shared-directory field to References: <20190419140427.15183-1-mail@cbaines.net> <20190419140427.15183-3-mail@cbaines.net> Date: Thu, 26 Mar 2020 10:30:57 +0100 In-Reply-To: <20190419140427.15183-3-mail@cbaines.net> (Christopher Baines's message of "Fri, 19 Apr 2019 15:04:26 +0100") Message-ID: <87blojea3y.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34638 Cc: 34638@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Christopher Baines skribis: > --- > guix/inferior.scm | 25 ++++++++++++++----------- > 1 file changed, 14 insertions(+), 11 deletions(-) Commit log please. :-) > + (pid inferior-pid) > + (socket inferior-socket) > + (close inferior-close-socket) ;procedure > + (shared-directory inferior-shared-directory) Please add a margin comment like =E2=80=9C#f | directory=E2=80=9D. > -(define* (port->inferior pipe #:optional (close close-port)) > +(define* (port->inferior pipe shared-directory #:optional (close close-p= ort)) > "Given PIPE, an input/output port, return an inferior that talks over = PIPE. > PIPE is closed with CLOSE when 'close-inferior' is called on the returned > inferior." Make =E2=80=98shared-directory=E2=80=99 a keyword argument? (Otherwise there=E2=80=99s a user in (guix ssh) that needs to be updated.) > ((client . address) > (proxy client (store-connection-socket store)))) > (close-port socket) > - (read-inferior-response inferior))))) > + (read-inferior-response inferior))) > + #:base-directory (inferior-shared-directory inferior))) What if =E2=80=98inferior-shared-directory=E2=80=99 returns #f? Otherwise LGTM. Ludo=E2=80=99.