From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 22 16:48:45 2019 Received: (at 34128) by debbugs.gnu.org; 22 Jan 2019 21:48:45 +0000 Received: from localhost ([127.0.0.1]:41642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gm3uI-000266-Mn for submit@debbugs.gnu.org; Tue, 22 Jan 2019 16:48:45 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:50642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gm3uG-00025x-VH for 34128@debbugs.gnu.org; Tue, 22 Jan 2019 16:48:29 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 865EC4EFC; Tue, 22 Jan 2019 22:48:27 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gztcRBsrVXr7; Tue, 22 Jan 2019 22:48:27 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id B6EF34EFB; Tue, 22 Jan 2019 22:48:26 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Arne Babenhauserheide Subject: Re: [bug#34128] [PATCH] add emacs built with xwidgets-support References: <87zhrx4mlu.fsf@web.de> Date: Tue, 22 Jan 2019 22:48:26 +0100 In-Reply-To: <87zhrx4mlu.fsf@web.de> (Arne Babenhauserheide's message of "Fri, 18 Jan 2019 23:29:14 +0100") Message-ID: <87lg3cjrdh.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 34128 Cc: 34128@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Arne, Arne Babenhauserheide skribis: > * gnu/packages/emacs.scm (emacs-xwidgets): new variable Thanks for the patch! I wonder why this hadn=E2=80=99t been done before; Nicolas, Alex, Pierre, thoughts? The patch LGTM, minor stylistic issues: > +(define-public emacs-xwidgets > + (package (inherit emacs) > + (name "emacs-xwidgets") > + (synopsis "The extensible, customizable, self-documenting text > +editor (with xwidgets support)") > + (build-system gnu-build-system) > + (arguments (append > + (package-arguments emacs) > + `(#:configure-flags > + '("--with-xwidgets")))) > + (inputs (append > + (package-inputs emacs) > + `(("webkitgtk" ,webkitgtk) > + ("libxcomposite" ,libxcomposite)))))) Please indent rather along these lines (like in the rest of the file): (define-public emacs-xwidgets (package (inherit emacs) (name =E2=80=A6) =E2=80=A6)) Likewise, for consistency, use unquote-splicing rather than =E2=80=98append= =E2=80=99: (inputs `(("webkitgtk" ,webkitgtk) ;; =E2=80=A6 ,@(package-inputs emacs))) Could you send an updated patch? Thanks, Ludo=E2=80=99.