[PATCH] add emacs built with xwidgets-support

Arne Babenhauserheide wrote on 18 Jan 2019 23:29

Recipients:(address . guix-patches@gnu.org)

Message-ID:87zhrx4mlu.fsf@web.de

* gnu/packages/emacs.scm (emacs-xwidgets): new variable

---

gnu/packages/emacs.scm | 16 ++++++++++++++++

1 file changed, 16 insertions(+)

Toggle diff (36 lines)diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index a488289f1..8c3ea1728 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -59,6 +59,7 @@
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages tls)
+  #:use-module (gnu packages webkit)
   #:use-module (gnu packages xml)
   #:use-module (gnu packages xorg)
   #:use-module (guix utils)
@@ -210,6 +211,21 @@ languages.")
     (native-inputs
      `(("pkg-config" ,pkg-config)))))
 
+(define-public emacs-xwidgets
+  (package (inherit emacs)
+           (name "emacs-xwidgets")
+           (synopsis "The extensible, customizable, self-documenting text
+editor (with xwidgets support)")
+           (build-system gnu-build-system)
+           (arguments (append
+                       (package-arguments emacs)
+                       `(#:configure-flags
+                         '("--with-xwidgets"))))
+           (inputs (append
+                    (package-inputs emacs)
+                    `(("webkitgtk" ,webkitgtk)
+                      ("libxcomposite" ,libxcomposite))))))
+
 (define-public emacs-no-x
   (package (inherit emacs)
     (name "emacs-no-x")
-- 
2.19.2

Ludovic Courtès wrote on 22 Jan 2019 22:48

Recipients:(name . Arne Babenhauserheide)(address . arne_bab@web.de)(address . 34128@debbugs.gnu.org)

Message-ID:87lg3cjrdh.fsf@gnu.org

Hi Arne,

Arne Babenhauserheide <arne_bab@web.de> skribis:

Toggle quote (2 lines)

> * gnu/packages/emacs.scm (emacs-xwidgets): new variable

Thanks for the patch! I wonder why this hadn’t been done before;

Nicolas, Alex, Pierre, thoughts?

The patch LGTM, minor stylistic issues:

Toggle quote (15 lines)> +(define-public emacs-xwidgets
> +  (package (inherit emacs)
> +           (name "emacs-xwidgets")
> +           (synopsis "The extensible, customizable, self-documenting text
> +editor (with xwidgets support)")
> +           (build-system gnu-build-system)
> +           (arguments (append
> +                       (package-arguments emacs)
> +                       `(#:configure-flags
> +                         '("--with-xwidgets"))))
> +           (inputs (append
> +                    (package-inputs emacs)
> +                    `(("webkitgtk" ,webkitgtk)
> +                      ("libxcomposite" ,libxcomposite))))))

Please indent rather along these lines (like in the rest of the file):

(define-public emacs-xwidgets

(package

(inherit emacs)

(name …) …))

Likewise, for consistency, use unquote-splicing rather than ‘append’:

(inputs `(("webkitgtk" ,webkitgtk)

;; …

,@(package-inputs emacs)))

Could you send an updated patch?

Thanks,

Ludo’.

Arne Babenhauserheide wrote on 23 Jan 2019 00:10

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 34128@debbugs.gnu.org)

Message-ID:877eew70ge.fsf@web.de

Hi Ludovic,

Toggle quote (2 lines)

> Thanks for the patch!

Thank you for your review!

Toggle quote (3 lines)

> I wonder why this hadn’t been done before;

> Nicolas, Alex, Pierre, thoughts?

There is an older bug with xwidgets support which had problems because

it depended on an old version of webkitgtk (I only found it after I sent

the patch). Maybe that stopped others from submitting.

Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (17 lines)> The patch LGTM, minor stylistic issues:
> …
> Please indent rather along these lines (like in the rest of the file):
>
>   (define-public emacs-xwidgets
>     (package
>       (inherit emacs)
>       (name …) …))
>
> Likewise, for consistency, use unquote-splicing rather than ‘append’:
>
>   (inputs `(("webkitgtk" ,webkitgtk)
>             ;; …
>             ,@(package-inputs emacs)))
>
> Could you send an updated patch?

Is inline here OK? If yes:

From ed2eca1ade73eb6b7c2e8b17541e3e182ade4608 Mon Sep 17 00:00:00 2001

* gnu/packages/emacs.scm (emacs-xwidgets): new variable

---

gnu/packages/emacs.scm | 17 +++++++++++++++++

1 file changed, 17 insertions(+)

Toggle diff (44 lines)diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index a488289f1..7e8dcadf9 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -59,6 +59,7 @@
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages tls)
+  #:use-module (gnu packages webkit)
   #:use-module (gnu packages xml)
   #:use-module (gnu packages xorg)
   #:use-module (guix utils)
@@ -210,6 +211,22 @@ languages.")
     (native-inputs
      `(("pkg-config" ,pkg-config)))))
 
+(define-public emacs-xwidgets
+  (package
+    (inherit emacs)
+    (name "emacs-xwidgets")
+    (synopsis "The extensible, customizable, self-documenting text
+editor (with xwidgets support)")
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags
+       '("--with-xwidgets")
+       ,@(package-arguments emacs)))
+    (inputs
+     `(("webkitgtk" ,webkitgtk)
+       ("libxcomposite" ,libxcomposite)
+       ,@(package-inputs emacs)))))
+
 (define-public emacs-no-x
   (package (inherit emacs)
     (name "emacs-no-x")
-- 
2.19.2

Best wishes,
Arne
-- 
Unpolitisch sein
heißt politisch sein
ohne es zu merken

Ricardo Wurmus wrote on 23 Jan 2019 09:19

Recipients:(name . Arne Babenhauserheide)(address . arne_bab@web.de)

Message-ID:87munr7ply.fsf@elephly.net

Arne Babenhauserheide <arne_bab@web.de> writes:

Toggle quote (13 lines)> Hi Ludovic,
>
>> Thanks for the patch!
>
> Thank you for your review!
>
>> I wonder why this hadn’t been done before;
>> Nicolas, Alex, Pierre, thoughts?
>
> There is an older bug with xwidgets support which had problems because
> it depended on an old version of webkitgtk (I only found it after I sent
> the patch). Maybe that stopped others from submitting.

I performed the migration of the Emacs xwidgets feature from the old to
the newer webkitgtk API, but that’s when I noticed that xwidgets are
hardly usable in its current state.  I certainly wouldn’t use it as a
browser, for example, because there is virtually no integration with the
rest of Emacs.

It works fine for sending JavaScript snippets to the widgets and have it
respond, but it’s not very well integrated into Emacs.  Disabling
JavaScript has the effect of disabling *all* JavaScript, which makes
scrolling impossible (as it is implemented by sending JavaScript to the
widget).

Turning it into a usable browser would require more fundamental changes,
and that’s when I stopped working on patches.

--
Ricardo

Arne Babenhauserheide wrote on 23 Jan 2019 10:37

Recipients:(name . Ricardo Wurmus)(address . rekado@elephly.net)

Message-ID:87d0onu330.fsf@web.de

Ricardo Wurmus <rekado@elephly.net> writes:

Toggle quote (6 lines)

> I performed the migration of the Emacs xwidgets feature from the old to

> the newer webkitgtk API, but that’s when I noticed that xwidgets are

> hardly usable in its current state. I certainly wouldn’t use it as a

> browser, for example, because there is virtually no integration with the

> rest of Emacs.

I see it as pretty good for many usecases already. I often just want to

look up something in a browser without switching away from Emacs, and

many websites nowadays don’t work with text browsers anymore.

The main thing that’s missing right now is a way to highlight all links

and select the one to follow — similar to next (or one of the other

projects listed on https://qutebrowser.org/).

Do you know why it flickers?

Toggle quote (6 lines)

> It works fine for sending JavaScript snippets to the widgets and have it

> respond, but it’s not very well integrated into Emacs. Disabling

> JavaScript has the effect of disabling *all* JavaScript, which makes

> scrolling impossible (as it is implemented by sending JavaScript to the

> widget).

That doesn’t really hurt me: For sites without javascript, eww mostly
works fine. So when running a webkit, I typically need javascript
anyway.

Also xwidgets as a feature enables much more than just a browser.

Best wishes,
Arne
--
Unpolitisch sein
heißt politisch sein
ohne es zu merken

Ludovic Courtès wrote on 23 Jan 2019 10:53

Recipients:(name . Ricardo Wurmus)(address . rekado@elephly.net)

Message-ID:87o987hf82.fsf@gnu.org

Heya,

Ricardo Wurmus <rekado@elephly.net> skribis:

Toggle quote (30 lines)> Arne Babenhauserheide <arne_bab@web.de> writes:
>
>> Hi Ludovic,
>>
>>> Thanks for the patch!
>>
>> Thank you for your review!
>>
>>> I wonder why this hadn’t been done before;
>>> Nicolas, Alex, Pierre, thoughts?
>>
>> There is an older bug with xwidgets support which had problems because
>> it depended on an old version of webkitgtk (I only found it after I sent
>> the patch). Maybe that stopped others from submitting.
>
> I performed the migration of the Emacs xwidgets feature from the old to
> the newer webkitgtk API, but that’s when I noticed that xwidgets are
> hardly usable in its current state.  I certainly wouldn’t use it as a
> browser, for example, because there is virtually no integration with the
> rest of Emacs.
>
> It works fine for sending JavaScript snippets to the widgets and have it
> respond, but it’s not very well integrated into Emacs.  Disabling
> JavaScript has the effect of disabling *all* JavaScript, which makes
> scrolling impossible (as it is implemented by sending JavaScript to the
> widget).
>
> Turning it into a usable browser would require more fundamental changes,
> and that’s when I stopped working on patches.

Oh, I was more optimistic; thanks for explaining.

Knowing this, what do you think of adding it as a package? We also have

‘guile-emacs’ anyway…

Ludo’.

Ricardo Wurmus wrote on 23 Jan 2019 12:41

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)

Message-ID:87fttj7g8t.fsf@elephly.net

Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (20 lines)>> I performed the migration of the Emacs xwidgets feature from the old to
>> the newer webkitgtk API, but that’s when I noticed that xwidgets are
>> hardly usable in its current state.  I certainly wouldn’t use it as a
>> browser, for example, because there is virtually no integration with the
>> rest of Emacs.
>>
>> It works fine for sending JavaScript snippets to the widgets and have it
>> respond, but it’s not very well integrated into Emacs.  Disabling
>> JavaScript has the effect of disabling *all* JavaScript, which makes
>> scrolling impossible (as it is implemented by sending JavaScript to the
>> widget).
>>
>> Turning it into a usable browser would require more fundamental changes,
>> and that’s when I stopped working on patches.
>
> Oh, I was more optimistic; thanks for explaining.
>
> Knowing this, what do you think of adding it as a package?  We also have
> ‘guile-emacs’ anyway…

I’m not at all opposed to adding it as a package.  After all, it is a
potentially useful feature and providing a package makes it more likely
that people get to play with it and maybe extend the features by
contributing elisp and JavaScript.

--
Ricardo

Ludovic Courtès wrote on 23 Jan 2019 23:29

Recipients:(name . Arne Babenhauserheide)(address . arne_bab@web.de)(address . 34128-done@debbugs.gnu.org)

Message-ID:87bm47dn3c.fsf@gnu.org

Hi Arne,

Arne Babenhauserheide <arne_bab@web.de> skribis:

Toggle quote (2 lines)

> Is inline here OK? If yes:

It is.

Toggle quote (7 lines)

> From ed2eca1ade73eb6b7c2e8b17541e3e182ade4608 Mon Sep 17 00:00:00 2001

> From: Arne Babenhauserheide <arne_bab@web.de>

> Date: Fri, 18 Jan 2019 23:29:14 +0100

> Subject: [PATCH] add emacs built with xwidgets-support

> * gnu/packages/emacs.scm (emacs-xwidgets): new variable

Applied, thank you!

I’ve tried it and I confirm that it flickers and that scrolling doesn’t

quite work as nicely as it could. ;-)

Ludo’.

Closed

Arne Babenhauserheide wrote on 24 Jan 2019 20:06

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 34128-done@debbugs.gnu.org)

Message-ID:87sgxh98ow.fsf@web.de

Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (6 lines)

>> Subject: [PATCH] add emacs built with xwidgets-support

>> * gnu/packages/emacs.scm (emacs-xwidgets): new variable

> Applied, thank you!

Thank you!

Toggle quote (3 lines)

> I’ve tried it and I confirm that it flickers and that scrolling doesn’t

> quite work as nicely as it could. ;-)

Yes — and that it is now as easy as running

guix package -i emacs-xwidgets && emacs

M-x xwidget-webkit-browse-url

to test this is cool!

Best wishes,

Arne

Unpolitisch sein

heißt politisch sein

ohne es zu merken

Closed

Your comment

This issue is archived.

To comment on this conversation send email to 34128@debbugs.gnu.org

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date