[PATCH] gnu: Add libaom and activate AV1 support in ffmpeg.

DoneSubmitted by Arne Babenhauserheide.
Details
4 participants
  • Arne Babenhauserheide
  • Arne Babenhauserheide
  • Leo Famulari
  • Ludovic Courtès
Owner
unassigned
Severity
normal
A
A
Arne Babenhauserheide wrote on 12 Jan 2019 01:24
(address . guix-patches@gnu.org)
871s5iemss.fsf@web.de
* gnu/packages/video.scm (libaom): New variable.
* gnu/packages/video.scm (ffmpeg): Add libaom support.
[inputs] new input libaom.
[arguments] new configure-flag --enable-libaom.
---
gnu/packages/video.scm | 38 +++++++++++++++++++++++++++++++++++++-
1 file changed, 37 insertions(+), 1 deletion(-)

Toggle diff (65 lines)
diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 52facebe4..97ae20b05 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -236,6 +236,40 @@ A/52 standard is used in a variety of applications, including digital
 television and DVD.  It is also known as AC-3.")
     (license license:gpl2+)))
 
+(define-public libaom
+  (package
+    (name "libaom")
+    (version "22b150bf040608028a56d8bf39e72f771383d836") ;; master
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://aomedia.googlesource.com/aom/")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1pdd5h3n42607n6qmggz4yv8izhjr2kl6knb3kh7gh4v0vy47h1r"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("git" ,git)
+       ("perl" ,perl)
+       ("pkg-config" ,pkg-config)
+       ("python" ,python))) ; to detect the version
+    (arguments
+     `(#:tests? #f  ;no check target
+       #:configure-flags
+         ;; build dynamic library
+       (list "-DBUILD_SHARED_LIBS=YES"
+             "-DENABLE_PIC=TRUE"
+             "-DAOM_TARGET_CPU=generic"
+             (string-append "-DCMAKE_INSTALL_PREFIX="
+                              (assoc-ref %outputs "out")))))
+    (home-page "https://aomedia.googlesource.com/aom/")
+    (synopsis "AV1 Codec Library")
+    (description "libaom is the reference encoder of AV1.")
+    (license license:bsd-2)))
+
+
 (define-public libmpeg2
   (package
     (name "libmpeg2")
@@ -700,6 +734,7 @@ standards (MPEG-2, MPEG-4 ASP/H.263, MPEG-4 AVC/H.264, and VC-1/VMW3).")
        ("opus" ,opus)
        ("ladspa" ,ladspa)
        ("lame" ,lame)
+       ("libaom" ,libaom)
        ("libass" ,libass)
        ("libbluray" ,libbluray)
        ("libcaca" ,libcaca)
@@ -778,7 +813,8 @@ standards (MPEG-2, MPEG-4 ASP/H.263, MPEG-4 AVC/H.264, and VC-1/VMW3).")
        ;;   --enable-libzmq          enable message passing via libzmq [no]
        ;;   --enable-libzvbi         enable teletext support via libzvbi [no]
        ;;   --enable-opencl          enable OpenCL code
-       '("--enable-avresample"
+       '("--enable-libaom" ; for AV1
+         "--enable-avresample"
          "--enable-gpl" ; enable optional gpl licensed parts
          "--enable-shared"
          "--enable-frei0r"
-- 
2.19.2
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE801qEjXQSQPNItXAE++NRSQDw+sFAlw5NhQACgkQE++NRSQD
w+uWMA//SMI6cDhpDtCRGRdx8H9hwPyCNiUn97ktpFIbRdtObKjfu/c2Tjp4dKH0
FOhfQmQpircTdpBXwR4vAUjBJN5SRoTDzQ2TM0auxzv5vLi26ljKA87V9B4r1Har
XS6aegsTdokfzAo5EyNsLFHhqfer94Qy5VBW+ltVZJ2ydEXGYCPOSxKAhfMW5+Ob
qeMuTGz9+ArOi4geh9gC60vuJpH6nGOmeC8u8UXCHqihl14TZIYGnNOj7VdBWgeo
ppA4rXpWWA+VMk5eP4Zfcir5oXIclZNPZLmFkiIYFAI0BOi/4WTL0/2+WJkwQtIz
UL2fOZkeZwfq1RvhbWD+EwdAJNM8dyNZ4jO/d4mFnylHVM9xriSSOzYqxlm0Gb4O
mLMkb3ibyvDNIj5ZtzQ0GzPaXw6P08I/aq2A7fVZy2pdlZqxLD/4w6yNGIXQ27Az
+4kZROZpuxtW9svhJWkuI3nE+bdY0SfUjZq95oqZiRMdb+8EScfitEc8AdmnAubo
9+c8m/VavlJ65+iikZEGkbRNE+2pL4cRJmtFg9YLRBY4vYSSdLgv9i+E9c9uudql
2HoNsUT5W8PdRnBG7/+1Ig5AHMNJ05J1GETV/7jr8xDfzYRFcRrD7QPu0p0YqTnC
eqeAu3mZYa/On37C1624iE0dS2UWWG+6+23RAaHNHLpbje8k5XyIswQBAQgAHRYh
BN0ovebZh1yrzkqLHdzPDbMLwQVIBQJcOTYXAAoJENzPDbMLwQVISFYEAI7apUK0
8EdBUaLLmdiyuysp2g65h5tgjiMt2C3AAWRvNM41ued/ulwuOaPzYfj7i6veraxG
3drt90AU44MgOviTXZWKZIsZnNIuL43M1oOt2gYGr+1yzT27Xj9TrcCHVWRtjRus
QuihTULrIvpfnMspG+tig/acUvIui5iQ6kaE
=ACHR
-----END PGP SIGNATURE-----

A
A
Arne Babenhauserheide wrote on 12 Jan 2019 13:13
Aw: bug#34050: Acknowledgement ([PATCH] gnu: Add libaom and activate AV1 support in ffmpeg.)
(address . 34050@debbugs.gnu.org)
trinity-dba92c62-1d87-4068-be18-e5290f2aad7b-1547295189677@3c-app-webde-bs07
There’s a problem with my patch: ffmpeg-3.4 inherits the values of ffmpeg but does not support the --enable-aom option.

How can I filter it?

This is the definition:

(define-public ffmpeg-3.4
(package
(inherit ffmpeg)
(version "3.4.5")
(source (origin
(method url-fetch)
version ".tar.xz"))
(sha256
(base32
"0b59qk5wpc5ksiha76jbhb859g5gxa4w0k6afh3kgvgajiivs73l"))))))

Best wishes,
Arne
L
L
Ludovic Courtès wrote on 13 Jan 2019 23:19
Re: [bug#34050] Aw: bug#34050: Acknowledgement ([PATCH] gnu: Add libaom and activate AV1 support in ffmpeg.)
(name . Arne Babenhauserheide)(address . Arne_Bab@web.de)(address . 34050@debbugs.gnu.org)
877ef8yzdc.fsf@gnu.org
Hello Arne,

"Arne Babenhauserheide" <Arne_Bab@web.de> skribis:

Toggle quote (4 lines)
> There’s a problem with my patch: ffmpeg-3.4 inherits the values of ffmpeg but does not support the --enable-aom option.
>
> How can I filter it?

You can use ‘substitute-keyword-arguments’, along these lines:


(define ffmpeg-3.4
(package
(inherit ffmpeg)
;; …
(arguments (substitute-keyword-arguments (package-arguments ffmpeg)
…))))

See the other packages that use it as examples.

HTH!

Ludo’.
L
L
Leo Famulari wrote on 13 Jan 2019 00:33
(name . Arne Babenhauserheide)(address . Arne_Bab@web.de)(address . 34050@debbugs.gnu.org)
20190112233358.GC16245@jasmine.lan
On Sat, Jan 12, 2019 at 01:13:09PM +0100, Arne Babenhauserheide wrote:
Toggle quote (4 lines)
> There’s a problem with my patch: ffmpeg-3.4 inherits the values of ffmpeg but does not support the --enable-aom option.
>
> How can I filter it?

Take a look at ((guix utils) substitute-keyword-arguments) and examples
of it being used in existing packages. Basically, you'll inherit the
arguments of ffmpeg but replace #:configure-flags with something
appropriate for ffmpeg-3.4.
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlw6eWYACgkQJkb6MLrK
fwjPOg/9Fg0Bb3eZOoUgAX6BJCT4FISAYLKJZgNdabwTaooIjgABWVgCcgX/Rhn4
N2M0uc/QtxyZAySRaqWMWcccahECgAwq/VdEe3/1M9Dbp0J2vq6lcUGyblcQt/sL
N5qt61KoJi4zn3ChoKyvhG2+R6N0y04lhG4mka84gQQ4ZphtVj+B/bAD1roSBVnL
B1EIwxe5888BgPgEnp4tu0y9rWawi85X00ptbQRbSD4RDaX+olYWSfiSUm+nGFgz
rZkOoLmT1L4xDRDu3BiKBUno3lhHRWO1TtPFkfN7Cw6Df6Qj3sq5X6wx7CjVLCWp
LgQtUqdPTI0hGe/C5YgxreT18JXT6ZQjQfa/1Ru7uZjO3KgIV7h7lb/JV/9dnZSE
eSYeeUQM9n9E+CY9cZR4+iyhZ9FzgbvRurgtysFB66a1hZCYERy2qj5xw8+s5/Nv
PauWSDdZ8uCg20mQDA4Goav/EMyrz7YargBGkwxhxgLhtm03p0210OOm/M5ykL6f
JEvD3o9WI7585yRyL5TbHDY36flzfMjgnX7PGVUjMYfHuXecbHFYzYZG5osIgCcd
XPXP13Sao+H9d5SWssFheMIznuDeiwN7gOlahfEO+Wb5XurJwfh3NyxDVYYXlq//
1rFPNlL7EX5BjpxRxAlK8NDR9BDZdB5In/gQEnISJq8rtnboL+8=
=tL30
-----END PGP SIGNATURE-----


A
A
Arne Babenhauserheide wrote on 19 Jan 2019 00:13
[PATCH] gnu: Add libaom and activate AV1 support in ffmpeg. updated
(address . 34050@debbugs.gnu.org)
87va2l4l02.fsf@web.de
The following patch now avoids breaking ffmpeg-3.4.

From f4406df33f1ed6dd64757f43ea7354fd5a88d2d3 Mon Sep 17 00:00:00 2001
From: Arne Babenhauserheide <arne_bab@web.de>
Date: Sat, 12 Jan 2019 01:24:58 +0100
Subject: [PATCH] gnu: Add libaom and activate AV1 support in ffmpeg.

* gnu/packages/video.scm (libaom): New variable.
* gnu/packages/video.scm (ffmpeg): Add libaom support.
[inputs] new input libaom.
[arguments] new configure-flag --enable-libaom.
* gnu/packages/video.scm (ffmpeg-3.4): filter out libaom.
[inputs] remove inherited libaom
[arguments] remove inherited configure-flag --enable-libaom
---
gnu/packages/video.scm | 45 +++++++++++++++++++++++++++++++++++++++++-
1 file changed, 44 insertions(+), 1 deletion(-)

Toggle diff (86 lines)
diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 947c498c0..a2d56293f 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -237,6 +237,40 @@ A/52 standard is used in a variety of applications, including digital
 television and DVD.  It is also known as AC-3.")
     (license license:gpl2+)))
 
+(define-public libaom
+  (package
+    (name "libaom")
+    (version "22b150bf040608028a56d8bf39e72f771383d836") ;; master
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://aomedia.googlesource.com/aom/")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1pdd5h3n42607n6qmggz4yv8izhjr2kl6knb3kh7gh4v0vy47h1r"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("git" ,git)
+       ("perl" ,perl)
+       ("pkg-config" ,pkg-config)
+       ("python" ,python))) ; to detect the version
+    (arguments
+     `(#:tests? #f  ;no check target
+       #:configure-flags
+         ;; build dynamic library
+       (list "-DBUILD_SHARED_LIBS=YES"
+             "-DENABLE_PIC=TRUE"
+             "-DAOM_TARGET_CPU=generic"
+             (string-append "-DCMAKE_INSTALL_PREFIX="
+                              (assoc-ref %outputs "out")))))
+    (home-page "https://aomedia.googlesource.com/aom/")
+    (synopsis "AV1 Codec Library")
+    (description "libaom is the reference encoder of AV1.")
+    (license license:bsd-2)))
+
+
 (define-public libmpeg2
   (package
     (name "libmpeg2")
@@ -701,6 +735,7 @@ standards (MPEG-2, MPEG-4 ASP/H.263, MPEG-4 AVC/H.264, and VC-1/VMW3).")
        ("opus" ,opus)
        ("ladspa" ,ladspa)
        ("lame" ,lame)
+       ("libaom" ,libaom)
        ("libass" ,libass)
        ("libbluray" ,libbluray)
        ("libcaca" ,libcaca)
@@ -787,6 +822,7 @@ standards (MPEG-2, MPEG-4 ASP/H.263, MPEG-4 AVC/H.264, and VC-1/VMW3).")
          "--enable-fontconfig"
          "--enable-gnutls"
          "--enable-ladspa"
+         "--enable-libaom"
          "--enable-libass"
          "--enable-libbluray"
          "--enable-libcaca"
@@ -869,7 +905,14 @@ audio/video codec library.")
                                  version ".tar.xz"))
              (sha256
               (base32
-               "0b59qk5wpc5ksiha76jbhb859g5gxa4w0k6afh3kgvgajiivs73l"))))))
+               "0b59qk5wpc5ksiha76jbhb859g5gxa4w0k6afh3kgvgajiivs73l"))))
+    (arguments
+     (substitute-keyword-arguments (package-arguments ffmpeg)
+       ((#:configure-flags flags)
+        `(delete "--enable-libaom" ,flags))))
+    (inputs (fold alist-delete
+                  (package-inputs ffmpeg)
+                  '("libaom")))))
 
 (define-public ffmpegthumbnailer
   (package
-- 
2.19.2



-- 
Unpolitisch sein
heißt politisch sein
ohne es zu merken
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE801qEjXQSQPNItXAE++NRSQDw+sFAlxCXa4ACgkQE++NRSQD
w+sWAw//dg8wwGmuY6lKgMCbJhlRcG5mPx13P8o/VySX8ag29/1/LZAzpcmfeWXy
9SWeqNWrlY37lxSd+3aDcN/z63KX0U3e4VEOPweV028ZZK0WXjaYDmxNPtigcrXW
IXzAqG3nSoZMKs78LBdoKw5kkJ/Dk9eoJw+qIrWfJCPhwrdPYkLRxWu6OhwfNNhr
CuAAlXtGSwo2ctW9dc0JTOVNIOiBcUROkxQns9hVn6dqV7GQId1OpuaDXby355eQ
7QuAj5QtuMq6TUJ6DQxMw9qvO21uRsIpT8YpNo11WK4mZvksl7cZSRHGNsFkWZbT
MTgdUkHBvulz5Qo/JQsjuj3eAW9ZnZVGAbswzQ8RiKDDC4TNsRs/Zpo96BTDP683
mN4aTkh2IkfarONnJSrCayTfzFVKLd0abODomqF3C63c+w9lEXS/lPl+A3UKVYAT
wVdxgYs+bwhIz1NiftOYDSjWzu9FBJIc/3gKrIRrp40TnHCJ2T/wS6oR2r3HPGwx
SL1OHLcR+dWjxU3d+io4hPhotkBgD8N0tn1HdniGna5bUwHGjxw3VwaxgnnFTwPo
bJyhSf4ub9yh0LL1OnVW9rQ5/PYCMHwW++bmP+hTEFe9YcsrVEX5TOvDsS1JB0AP
D6GUjGO2u+gqBjc+8uAdsk3MPyCskxzTmv6SDPwKbB+ijj7FxiyIswQBAQgAHRYh
BN0ovebZh1yrzkqLHdzPDbMLwQVIBQJcQl2uAAoJENzPDbMLwQVIHXsD/1sCRVBG
mOtesPZuOZ2+bUbp9mjTk5oTGQC45mz54+BQjgLoHAMadWihgO5I5oB2/YBondfe
dIwFhr00foY01MkQXQyhN2WVwY3E9YJw7NrioVF/bPkcmd1KbwG/KYI0di0pB38F
bvzY111CWQZLlooZ8G7ac2WAh1pbMX4aIRX1
=Oa0G
-----END PGP SIGNATURE-----

L
L
Leo Famulari wrote on 5 Mar 2019 04:18
(name . Arne Babenhauserheide)(address . arne_bab@web.de)(address . 34050@debbugs.gnu.org)
20190305031810.GA14749@jasmine.lan
On Sat, Jan 19, 2019 at 12:13:49AM +0100, Arne Babenhauserheide wrote:
Toggle quote (15 lines)
> The following patch now avoids breaking ffmpeg-3.4.
>
> From f4406df33f1ed6dd64757f43ea7354fd5a88d2d3 Mon Sep 17 00:00:00 2001
> From: Arne Babenhauserheide <arne_bab@web.de>
> Date: Sat, 12 Jan 2019 01:24:58 +0100
> Subject: [PATCH] gnu: Add libaom and activate AV1 support in ffmpeg.
>
> * gnu/packages/video.scm (libaom): New variable.
> * gnu/packages/video.scm (ffmpeg): Add libaom support.
> [inputs] new input libaom.
> [arguments] new configure-flag --enable-libaom.
> * gnu/packages/video.scm (ffmpeg-3.4): filter out libaom.
> [inputs] remove inherited libaom
> [arguments] remove inherited configure-flag --enable-libaom

Sorry, this fell through the cracks.

I noticed that ffmpeg-for-stepmania (FFmpeg 2) isn't addressed by this
patch.

So, I built ffmpeg-3.4 without filtering out the libaom stuff and it
does build, so I'm wondering how it breaks?
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlx96m8ACgkQJkb6MLrK
fwjwNA/9HzI6hK+khKS+gEuleMDkAW23RF4bZaMnxmOO3A8G0qqLfxIPX7SvD7NI
RuASVCUBJCbjBOdXgrsPIp5RTvier5tbYjTk7BsfHtgcl6ekEztGd3SBuZ9TSdHo
uwMAoYbarnykPkaTfZUolimOTLVjZJAEF50JFrMpyhBydYSm4nFUsZRlqbqOm86l
7HhV0wOE+HrplNm1FM8pkXyzncMPv7fbviyw7CelB+6FebYRg5zyCBTMjWs7q4KP
twVT1pMvBcovl+RvJv85b/8HL1tdOVJEyFugSm14lJ5B1n2FaREKmqswY+25S46r
e4OGJ4o0y3wnTlG1kghmA0RPzm7dD5xnIkJwXcNN9I0yhBVo+Qkqos5YGma5dak9
GWvJhEShTOboeo6uuMb6yeUcYPxXbzOr0cRvkwZvWXmRC3fmPUluCLpYScB9HW5c
Vt9L22cccy6DQXprT9f81g+iL1WNbis1+qtPNDJF3F702isdxz+9YLa+2HeR53Ul
1+cGpuPASafkTbKMAa81ocig2IwpnruTLrc3l4ssyg104d4pshAEKNDkyyFEHrIg
vbfHZOlvFxRdk3Zx3UTwlka+9SIWkwpK6EaWVl2XCv86ml1O+Q6UXtTZtER+FUcq
8KvWwpeZUfZ3/664yognUVQD3jo6ReMoHqaMA209/ndCRUMiyuk=
=s+wj
-----END PGP SIGNATURE-----


A
A
Arne Babenhauserheide wrote on 5 Mar 2019 16:57
(name . Leo Famulari)(address . leo@famulari.name)(address . 34050@debbugs.gnu.org)
87y35tiaaa.fsf@web.de
Leo Famulari <leo@famulari.name> writes:

Toggle quote (21 lines)
> On Sat, Jan 19, 2019 at 12:13:49AM +0100, Arne Babenhauserheide wrote:
>> The following patch now avoids breaking ffmpeg-3.4.
>>
>> From f4406df33f1ed6dd64757f43ea7354fd5a88d2d3 Mon Sep 17 00:00:00 2001
>> From: Arne Babenhauserheide <arne_bab@web.de>
>> Date: Sat, 12 Jan 2019 01:24:58 +0100
>> Subject: [PATCH] gnu: Add libaom and activate AV1 support in ffmpeg.
>>
>> * gnu/packages/video.scm (libaom): New variable.
>> * gnu/packages/video.scm (ffmpeg): Add libaom support.
>> [inputs] new input libaom.
>> [arguments] new configure-flag --enable-libaom.
>> * gnu/packages/video.scm (ffmpeg-3.4): filter out libaom.
>> [inputs] remove inherited libaom
>> [arguments] remove inherited configure-flag --enable-libaom
>
> Sorry, this fell through the cracks.
>
> I noticed that ffmpeg-for-stepmania (FFmpeg 2) isn't addressed by this
> patch.

I did not know about it …

Toggle quote (3 lines)
> So, I built ffmpeg-3.4 without filtering out the libaom stuff and it
> does build, so I'm wondering how it breaks?

It broke because ffmpeg-3.4 does not have the --enable-libaom configure
flag.

What’s the exact patch you applied?

Best wishes,
Arne
--
Unpolitisch sein
heißt politisch sein
ohne es zu merken
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE801qEjXQSQPNItXAE++NRSQDw+sFAlx+nG0ACgkQE++NRSQD
w+t9IBAAkJF1cH1iSO1xQeGFd0LF/Nxb/pX8si2N4MZJiJQh/IjgkvEJwfe7Ju/o
mk0bJkTCTANsNhRUUMUqZWJwZ+VdW9YMzriH47uRWNFu5Nn5ca0CU8GutJ8PqGcB
AQiNIedSiTRZM56sKCo2OoFiX2ndvl64Dzf/murQXJ182SxVLsB3uWvfHLovdNxy
vG8Mm9xhiHG/bI2bGk85No6bTiuEyHi15mzCjItTWhkA5hVtCfrVd5NhsqlKhKl+
vMZpupWFqRu1eLkphhbs28aPLhvaI2Vz3kTVFn/B15wMf3grz+Z1oqWjPplkAHUq
1zgP2oZhf7I6cu/Ct6biGIFKOVrrC6hzJTm1FjHxY4cCpHYKMRXgKdOcYxPlSV2u
m1amqXCBp71kQkE0SDXVpPMzs/U4Fu86nB16SVQ4leMKTNOw7yHbiaofnVUkObFE
4J2NmVMcyeIAna9nKjCmdjNtY6agC0AV046lxre3AWjkpU3RSFybfbYkJ+UzDQSG
ATEyHzSO9Rr762wp3+ZujFfWoPJPRv4UMde7asgX5SHEHBoKup2q63fMNnlJtDLU
Jh4ZHKZzuHTuKKv3nq0zplmR5NAdOF3eU6tJQXXAavOiLCMa6BTLZ7vvI69KquGy
IoVvXhDV6hdrkBROGMXNfeojPDJyEbbId/lgAgBPPwlra1sSWQWIswQBAQgAHRYh
BN0ovebZh1yrzkqLHdzPDbMLwQVIBQJcfpxtAAoJENzPDbMLwQVIUAAD/21tFO23
q/kZEHSL/36rsJDX0brUrwQ1S8HewrduVAnSVaeysaYUjAE5CpDXCjn32r/qcbRq
oorpZ+CX43mYJlCqmQCdocgrGMBXbF5s34oZl3xKEt9dfrl3Ar4Sb9wdPH8UMGlW
OUT3M+u9rHfYQG9HmI2UMI4/AaguTP4yb6rb
=scOc
-----END PGP SIGNATURE-----

L
L
Leo Famulari wrote on 5 Mar 2019 21:08
(name . Arne Babenhauserheide)(address . arne_bab@web.de)(address . 34050@debbugs.gnu.org)
20190305200837.GA14036@jasmine.lan
On Tue, Mar 05, 2019 at 04:57:33PM +0100, Arne Babenhauserheide wrote:
Toggle quote (5 lines)
> It broke because ffmpeg-3.4 does not have the --enable-libaom configure
> flag.
>
> What’s the exact patch you applied?

I'm seeing the build fail now. Auto-compilation of my Git tree must not
have been working previously. Testing...
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlx+10UACgkQJkb6MLrK
fwh1Ug/9Gpn3bjy/KcoIFoyp/zITRsVLrPNmUlGvkQ7iboB8RudL6MEbPBPKHXGr
Z7a+C+JYjKUK2cas2Bg1WfeYam25V+VbMzjLBAXKwWBsstYRUuhwXI7h5QxRQxCO
QFgZmwRwNyLDNzOmWk1bKIieXWB5FHzrjp5mBT/gPJiROrnYaEXKUyGjrtlZpnpY
b7C8y0la54fz9ESP5asyj+UwYdK9VbfoUDQbLFE1MUfsSIoXnbtbi/HFz2GQ3dT5
P4LW1+JQqgtzrQc4mFpRm9FSJay17PcPAp6sssxvE8sDluU4uXCOixg/+nAZyDwN
S8bQjEVZIwdVsU2Us1roLGjmt1bv7EwI/CFdiGjkWZr9/R6/ofT8HC0VCUlCqi2e
QoHZppMgpzFVXTnFIkWF8UGBnsZdnuUDJYN9bBGAG78tMR6C0or/uooi26bdjPKw
JsKyrGd3gphl+3/5vKMPZEUjwoLJ1RHJQdpJAX//uOQnY8b75A+t7MWT058xVBQl
NbrkebCVw6Gg/j1/WQVD6lkPOm7Qic1IebXse4CWmI+HXjAnHlHv196aXgm92s2L
U8/6uOnU8wSeF5V8LPEO8jO2A4gXmQcJZoWy5ldizuKS9QD6LpktP+QyFtGingC9
IKXZcKipqhgGjNb9gOQ1QmhoMRIjgOizy16Mmijw79PGZAPBr9o=
=Vafr
-----END PGP SIGNATURE-----


L
L
Leo Famulari wrote on 5 Mar 2019 21:12
(name . Arne Babenhauserheide)(address . arne_bab@web.de)(address . 34050@debbugs.gnu.org)
20190305201207.GB14036@jasmine.lan
On Sat, Jan 19, 2019 at 12:13:49AM +0100, Arne Babenhauserheide wrote:
Toggle quote (13 lines)
> From f4406df33f1ed6dd64757f43ea7354fd5a88d2d3 Mon Sep 17 00:00:00 2001
> From: Arne Babenhauserheide <arne_bab@web.de>
> Date: Sat, 12 Jan 2019 01:24:58 +0100
> Subject: [PATCH] gnu: Add libaom and activate AV1 support in ffmpeg.
>
> * gnu/packages/video.scm (libaom): New variable.
> * gnu/packages/video.scm (ffmpeg): Add libaom support.
> [inputs] new input libaom.
> [arguments] new configure-flag --enable-libaom.
> * gnu/packages/video.scm (ffmpeg-3.4): filter out libaom.
> [inputs] remove inherited libaom
> [arguments] remove inherited configure-flag --enable-libaom

Okay, looks good in general.

Toggle quote (5 lines)
> +(define-public libaom
> + (package
> + (name "libaom")
> + (version "22b150bf040608028a56d8bf39e72f771383d836") ;; master

Typically we only package tagged releases. I think the latest libaom
release is 'v1.0.0-errata1'. Can we use that or did it not work for you?
If you didn't try it, I can do it here.
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlx+2BcACgkQJkb6MLrK
fwiOjQ//SNCSVqrSbv7W0mGwO85NJs0yGQVHFgEeQd52ZR/0D/pjlOuWl+YhRdqz
UcIFz92QxfAf2yTeV2vC/UAVZa6ftS6XoMgDmmP4MH7XX6mUQCMw0w9uVzG+D+Px
+VFCi2XJl5HRmiMSIuw/dQpwo9vlL0vfkpPOiIVIXOAY2zwyjcD0lEmUfbwxMlGQ
8lheecgpa5ZNA8tCkiImxR8s7tPPiKjhI5+VhyFLVUHMppDuSJw/EANGJ9QCV7oa
1Mk3Mg3qLWnb7kqKN2kwbHXSaZjWaczH1WPE824Nn1oIbdTrsKYrOuPxkPoadaq7
3dkkmSa3rOwGyUsZgI9jXp6E1Ih41mExeAuj2Ma9woImE4QXR0UAU6ZChRfb7PHS
yQGVv5eGDBfAq3twg50YL1X7Dm8RExpPsJhnMBbXqg9CLHTs5AtO9wiiBc+cbdnK
Y/tpqMJ9Cqp69Yjv/1EYbmAFbwvwAp2zywklYCtApFbUyHaCZ/XtDb2JQbSSLRD7
eMHcMEZ0/3fWJ4aKPP6b8TiuocR4QchlCY8z2UB5Z8sqx4CpxktUbBTeSLgQYs3u
Bidvc+LAcET6exwBVLab4cG1J0cflPJo0m21nv0ZU4Dtaj6WYUAKbXk1G1aBmH4T
X7oQNWVnqFnU/pwXzj4CAw2a3WvkCW7dv/CLKeLRgvkei/7aVSw=
=FZ77
-----END PGP SIGNATURE-----


L
L
Leo Famulari wrote on 6 Mar 2019 00:30
(name . Arne Babenhauserheide)(address . arne_bab@web.de)(address . 34050-done@debbugs.gnu.org)
20190305233041.GA24016@jasmine.lan
On Tue, Mar 05, 2019 at 03:12:07PM -0500, Leo Famulari wrote:
Toggle quote (10 lines)
> On Sat, Jan 19, 2019 at 12:13:49AM +0100, Arne Babenhauserheide wrote:
> > +(define-public libaom
> > + (package
> > + (name "libaom")
> > + (version "22b150bf040608028a56d8bf39e72f771383d836") ;; master
>
> Typically we only package tagged releases. I think the latest libaom
> release is 'v1.0.0-errata1'. Can we use that or did it not work for you?
> If you didn't try it, I can do it here.

To answer my own question, 1.0.0-errata1 installs a broken pkg-config
.pc file [0].

This is fixed in a later commit [1] ... we might as well use the commit
you chose originally, which is later than the pkg-config fix commit.

This library's decoder is *very* expensive — it can't even decode
1280x720 in realtime on my Ivy Bridge i5-3230M. I'm sure it only gets
faster as they keep working on it.

I changed the libaom package to be more idiomatic about versioning from
Git [2] and edited the synopsis and description, and pushed as
84eb265eb8076876d2b569bcdff1e44b44b4b295

Thanks a lot!

[0]

[1]

[2]
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlx/BqAACgkQJkb6MLrK
fwijgxAAnFaXZm06AoxLpmdt/OkBWEyJhLsb6hvSMlg5BCWw+slki7hAAI6CGRzV
PHbmgGChV9iAUCQpi5tddaMmu7BAxJyNKKYwbMaLZC0XBEHBSix7Ng4FQy9wDAVM
Tz8w9JnWmVxJgrChEFcIQmi+x3nyIxFlCl2TCqRblzAQvnxammUcO+LU3rn3nIux
1p7e9nEqxobePkwr2MdVmjZrVfcWUi7cY9+kqcwB9Q5kI+NjSqYbrlegbB9trO/+
WdpYG9UDrGKwIRZXaGmApsUJie1wKiZ5QFpsXWGoPmgTTCIkJZgexeuej7y72Vny
wTtmFZFvG0c3ln5otqp2O3ZkEEWE0T092DeijoTxRSxbYQIiZtQl+xnhcHLgDhB+
2B3THcShSMWIGiZpWaPErK2gEWkQkBKcrti1vJbEMJtF4jPTAGVZu6gmyxOSMNa4
Jbkuz5QKxnb0BnytjrpiIpeFY2GDuvcMEatTHDs3mzOxYdQY3uDTd3wDyxD1WiRT
GimWVsTr3w4atE6vV3BSExtejmaBGQ/ctKeL4GmWFHzpSQwd5l/RkaMVoYHf3I0s
fE9XMl1eDdadSWX5sNRxX5FKE7T3Om3CG8/zAKhk/cqN4CAQj4A6eLP1kOXOWzc5
GmdE7a8jG6L4PjdIg1uundwATif2pDUpN7Jd1LKWA5JZCzW8bdE=
=aS8t
-----END PGP SIGNATURE-----


Closed
A
A
Arne Babenhauserheide wrote on 6 Mar 2019 20:24
(name . Leo Famulari)(address . leo@famulari.name)(address . 34050-done@debbugs.gnu.org)
87d0n3957w.fsf@web.de
Leo Famulari <leo@famulari.name> writes:

Toggle quote (14 lines)
> On Tue, Mar 05, 2019 at 03:12:07PM -0500, Leo Famulari wrote:
>> On Sat, Jan 19, 2019 at 12:13:49AM +0100, Arne Babenhauserheide wrote:
>> > +(define-public libaom
>> > + (package
>> > + (name "libaom")
>> > + (version "22b150bf040608028a56d8bf39e72f771383d836") ;; master
>>
>> Typically we only package tagged releases. I think the latest libaom
>> release is 'v1.0.0-errata1'. Can we use that or did it not work for you?
>> If you didn't try it, I can do it here.
>
> To answer my own question, 1.0.0-errata1 installs a broken pkg-config
> .pc file [0].

Thank you for checking!
(I do not remember why I chose the commit instead of the tag)

Toggle quote (3 lines)
> This is fixed in a later commit [1] ... we might as well use the commit
> you chose originally, which is later than the pkg-config fix commit.

Sounds good.

Toggle quote (4 lines)
> This library's decoder is *very* expensive — it can't even decode
> 1280x720 in realtime on my Ivy Bridge i5-3230M. I'm sure it only gets
> faster as they keep working on it.

I take it that you did not test the encoder yet … it takes roughly an
hour per second :-)

But this is a reference for seeing the quality, not for fast de- and
encoding.

Toggle quote (6 lines)
> I changed the libaom package to be more idiomatic about versioning from
> Git [2] and edited the synopsis and description, and pushed as
> 84eb265eb8076876d2b569bcdff1e44b44b4b295
>
> Thanks a lot!

Thank you for taking care of the patch!

Best wishes,
Arne
--
Unpolitisch sein
heißt politisch sein
ohne es zu merken
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE801qEjXQSQPNItXAE++NRSQDw+sFAlyAHlMACgkQE++NRSQD
w+vxpQ//dc7llXmRBFr2JHn2YQsrCtm9Y6fMnNkEWPpMJ91W2I7d60UixboAe+yc
P5BFKqOUoy0Z+sC+On3o2D0GK8cALBe8D9f2C8MTaq3c1uM+zTRSY66AQDtCsnrj
QGdRthVmYjp990lQx1/um/tdq5Vrw0MyAfm1xzz04XoS/9RkWUHHCHC7yMYBJQwU
fQykc7WaKtswgGW3nKXnCelPpiuWNtic9FIZV7pM9XqZahyYblVzv9nwZBW6imur
6mjdKCOtvug9d7dB8WOlqQyqXdwcFFD10vHBSGfLAca00ytVMbhMbW/XHkM/LOtI
JaVpOsi184EzVox+Ow5gU5vAm2i1YSQQmwOypq09EwzQ8olVi0u0Nue0gLvryOk+
+rwDCQF792D+DIg1l+cYnqcIpYdIfXhiNUdUQ4DxIUfzpwbp4FjK/lKDcwQC8nGm
XMcw9F8+W60sOLLR6JuOtQOukDSLB5Cz2YpG11WZtUwYIMhJrPCtefIBbnq8N6qZ
6NyOa4Hbjizq7Ciz7S2PkENgS1APf6XFlq1tCF/z0avoMJGP9lRBJxeQObK4cYlw
bJHXiE1q4GYLIvLY3egPNcmLUv/DyMkjHPIrH14W58/UgahiejS0WPmtM6cmF3FW
1GGhYihImLefVe/CwBr7VaBmnREqIM+Gc2SXDYdXcH4K4pDXEBiIswQBAQgAHRYh
BN0ovebZh1yrzkqLHdzPDbMLwQVIBQJcgB5UAAoJENzPDbMLwQVIObAD/0hRB/pt
rl+QXCpn6iKZtQlpb9zlXPcr3hIjEdfJ9fC5bXSvP/j5XTrsvroQB1WdiDD6EE6F
CUZEEwLvQn2E7lwjo0wWi/bPEXYWV4+YSKa67Mc6t65l3sFAoEDpQNRvSAM56ewX
JRBhmm+oficeNHlTiun2fFNZro0H6rO6Kn7v
=5pts
-----END PGP SIGNATURE-----

Closed
L
L
Leo Famulari wrote on 6 Mar 2019 21:02
(name . Arne Babenhauserheide)(address . arne_bab@web.de)(address . 34050-done@debbugs.gnu.org)
20190306200216.GA29634@jasmine.lan
On Wed, Mar 06, 2019 at 08:24:03PM +0100, Arne Babenhauserheide wrote:
Toggle quote (3 lines)
> I take it that you did not test the encoder yet … it takes roughly an
> hour per second :-)

Wooooow! I had heard it was very slow so I only tested the decoder.

I'm looking forward to dav1d and rav1e or some other implementations
leading us to the AV1+Opus promised land ;)
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlyAJ0UACgkQJkb6MLrK
fwgW6xAA41sbgQhMEHJN8zL5FnvIUsZHsVXqVPhv563n3GSsQwFu3yOtVOtVgTIM
pM/uN5bpPweS1ITXNplnQpw0qOe1di/ZCC9/JnZ0txpVUWTreFGYTRl4aD3BJK9u
blo7JxxHCkfg3kTNQ4tj5eAPAcrRJNz0u4aS5uzL8fTsT/Ed6DxrdhYjAT5bbCar
/qvOvmGfbgvHXL3UZ7ItNHjCwY46rh3mA9aRmX5VEYkYxPm7Mkpq8UWTdwabP/ao
nk732cxuBqXwfFvYVHlMGIvT3aDLVnAZioYVwCxm8OKHR7gKtO2bHg0cAgLAyHNf
i0htzsCyx/1a9kuK1ULPGBtoFYhPa7e+gXahPaGV8sNX9aOJr10W25+Q2WmXR+Bs
9j8umKTHJBkPK2bNNEBrerV0eQqZrJ2N3O0yX66eB7UPrGTsZIHXM1UVGtit7Zy4
xvRP87c25MnXl8/DsAPAg1g7UDc9B9Qxb7F4XFCnP/PNudFVZDP2so0ODeih66EU
1fTD0E4IpIf+ks92p8ZHDCnUbsOTw+ArOEVL2ZbYj5HT6iggdgug6KxkicLzSnJ/
47twmMKauVVHNv6U+zJaGMQOE+WyvBe8LCb3C+f17wfyiuINMVDGmAVgWcFEP4no
F27NkbmxjT8g4OE3RwZ+XU1raHJHC+R++YuRFV8WOy2c1VBjdas=
=BvOI
-----END PGP SIGNATURE-----


Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 34050@debbugs.gnu.org