Cuirass: Evaluations adding no new builds are displayed as "failing"

  • Done
  • quality assurance status badge
Details
3 participants
  • Clément Lassieur
  • Ludovic Courtès
  • Mathieu Othacehe
Owner
unassigned
Submitted by
Clément Lassieur
Severity
normal
C
C
Clément Lassieur wrote on 8 Nov 2018 10:34
(name . Bug Guix)(address . bug-guix@gnu.org)(name . Ludovic Courtès)(address . ludo@gnu.org)
87y3a352w1.fsf@lassieur.org
Hi,

Evaluations adding no new builds are displayed as "failing". I know
this was done on purpose, but I think the check should be done on the
number of jobs returned by the evaluator, rather than on the number of
builds registered in the database.

There is a difference because derivations that are already in the
database won't be added again.

of the evaluations add no new builds, and none of them are failing.

Toggle snippet (7 lines)
(with-store store
(let ((jobs (evaluate store spec eval-id checkouts)))
(log-message "building ~a jobs for '~a'"
(length jobs) name)
(build-packages store jobs eval-id)))

Thus if (zero? (length jobs)) here, we should mark the corresponding
evaluation as failing.

Thanks,
Clément
L
L
Ludovic Courtès wrote on 11 Nov 2018 14:37
(name . Clément Lassieur)(address . clement@lassieur.org)(name . Bug Guix)(address . bug-guix@gnu.org)
87k1ljspku.fsf@gnu.org
Hello,

Clément Lassieur <clement@lassieur.org> skribis:

Toggle quote (5 lines)
> Evaluations adding no new builds are displayed as "failing". I know
> this was done on purpose, but I think the check should be done on the
> number of jobs returned by the evaluator, rather than on the number of
> builds registered in the database.

Indeed, that makes sense. For the record the faulty code was added in
commit 0b40dca734468e8b12b3ff58e3e779679f17d38e. As I wrote there, it
would be ideal to have a “failed” bit in the database, and, even better,
to save the output of ‘evaluate’.

Thanks,
Ludo’.
M
M
Mathieu Othacehe wrote on 25 Mar 2021 13:54
Re: bug#33310: Cuirass: Evaluations adding no new builds are displayed as "failing"
(address . 33310-done@debbugs.gnu.org)
87blb75r7x.fsf@gnu.org
Hello,

Closing as this is fixed on Cuirass master.

Thanks,

Mathieu
Closed
?