From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 17 16:50:58 2018 Received: (at 33078) by debbugs.gnu.org; 17 Oct 2018 20:50:58 +0000 Received: from localhost ([127.0.0.1]:55841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gCsmP-0007Ir-UM for submit@debbugs.gnu.org; Wed, 17 Oct 2018 16:50:58 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:60543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gCsmN-0007Ii-K5 for 33078@debbugs.gnu.org; Wed, 17 Oct 2018 16:50:56 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id C943D220DA; Wed, 17 Oct 2018 16:50:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 17 Oct 2018 16:50:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=2RJFymQBiUFHoV9gsJU5vjIEXE BG/oy8jLn62mCuDA0=; b=kSqQ8IGIt8MeufyFaiAyTe5fKmBw2bk/md8+dU2Ea5 ywm1cVt6Pwm8JFtgJcJ5MOu3Gl3+NkVOI3DuE1yA6uz9bcn1GpFGFcv/CkdT5UWV 4Bszu2/UF3oO/HUlyMwD98Ho5vyxYgmB3PmgrG0gUBKV6qlHPxc5tvo/XCKl+LzT AjjbwkCetbNpOgU37F2j5irtp/IdM3uV36brlGpLOxcGSYzHXGstvELCxC4cb2Yi EGYfBy1qJsK/46DdXHIKxHDoh3nIavIzEI5VOwkVCEc/XJugq+0tyHD9jMfWFTuU MbjTuQUVLaNlIBidoyBjjDxc6zfYtdyZLzhIA7hSwkBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=2RJFym QBiUFHoV9gsJU5vjIEXEBG/oy8jLn62mCuDA0=; b=d6XN+5+aupgRmAWvNKAGoI YvSh8NaLQ/ifS0xCazrJ5YSl6NnElIqOHJ3Ah9tlXCKpRjHMMf8DhFV2ZKXjo7zK 5EmVj3OtwTkiMM2DjNcu5tG8a6n2hSKrSwsuEHGdJIsqctWsC6SUuiVK4JCjnA7Z hkPB0AnTNiOlb1RO3dUqjrtgLQbVJYF8BbxXGzyM7uoZ8tg3Em32pO46JDX9K8S5 pHEQ6tNjKIUKqMFBnKFI38wnE8cjl5spvIFQxf2PKRplnnYx3d4ZLJZRZ+CdZY6G A9t/6Oi+UB7JG4NdxVd/WdZ9tyaZdh7Il7HhZgasJOLI8Al5MuUAP/sVP9jrJMEA == X-ME-Sender: X-ME-Proxy: Received: from localhost (140.226.16.62.customer.cdi.no [62.16.226.140]) by mail.messagingengine.com (Postfix) with ESMTPA id A835BE4074; Wed, 17 Oct 2018 16:50:53 -0400 (EDT) From: Marius Bakke To: Mark H Weaver , 33078@debbugs.gnu.org Subject: Re: bug#33078: Attempt to build my GuixSD system now fails In-Reply-To: <87d0s8nyvi.fsf@netris.org> References: <87d0s8nyvi.fsf@netris.org> User-Agent: Notmuch/0.27 (https://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu) Date: Wed, 17 Oct 2018 22:50:51 +0200 Message-ID: <87woqgfgb8.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33078 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Mark H Weaver writes: > When I try to build my x86_64 GuixSD system, based on my system > configuration which I've not modified since May, it now fails: [...] > In gnu/services/networking.scm: > 1076:9 0 (config->package _) > > gnu/services/networking.scm:1076:9: In procedure config->package: > Throw to key `match-error' with args `("match" "no matching pattern" #)'. Whoops, sorry for this breakage! > Here's my system configuration: [...] > (services (cons* (console-keymap-service keymap) > ;;(xfce-desktop-service) > (gnome-desktop-service) > (service network-manager-service-type > (network-manager-configuration)) > (service wpa-supplicant-service-type wpa-supplicant) To adapt to the new interface, this should be changed to: (service wpa-supplicant-service-type) ...though it would be good to have backwards compatibility here. WDYT of this approach? --=-=-= Content-Type: text/x-patch Content-Disposition: inline 1 file changed, 15 insertions(+), 12 deletions(-) gnu/services/networking.scm | 27 +++++++++++++++------------ modified gnu/services/networking.scm @@ -1072,19 +1072,22 @@ networking.")))) (stop #~(make-kill-destructor))))))) (define wpa-supplicant-service-type - (let ((config->package - (match-lambda - (($ wpa-supplicant) - (list wpa-supplicant))))) - (service-type (name 'wpa-supplicant) - (extensions - (list (service-extension shepherd-root-service-type - wpa-supplicant-shepherd-service) - (service-extension dbus-root-service-type config->package) - (service-extension profile-service-type config->package))) - (description "Run the WPA Supplicant daemon, a service that + (lambda* (#:optional wpa-supplicant-package) ;deprecated + (let ((package + (if wpa-supplicant-package + wpa-supplicant-package + (match-lambda + (($ wpa-supplicant) + (list wpa-supplicant)))))) + (service-type (name 'wpa-supplicant) + (extensions + (list (service-extension shepherd-root-service-type + wpa-supplicant-shepherd-service) + (service-extension dbus-root-service-type package) + (service-extension profile-service-type package))) + (description "Run the WPA Supplicant daemon, a service that implements authentication, key negotiation and more for wireless networks.") - (default-value (wpa-supplicant-configuration))))) + (default-value (wpa-supplicant-configuration)))))) ;;; [back] --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlvHoKwACgkQoqBt8qM6 VPoLdAf+M+sdstBasq+5qtWLjbYrNZM5TrG5dPfS5L+CUazt3+8GlqQqwg4qbbLP vqyNd/J4onf4TJhJ8v0Q88HRTenLsCLWAa6BuVe8tqmYqcvKoQp3ciXPSYAtcEp4 mzvAAAgaKss6Jj9sLeiIOE1gtL+D9N3WYDV86QmGBK6TKgaMLzyR0Kh0WBjs6JUt WUHsebGAtRkpbzwBrgCC4B1w/Ex261cTRIJ5fS3+vaZpT2ZjpTzfJuvQlEs/IiCN 5GtNSP9UySDDDiNu+V+PCkZLZxVD3N0V2GIX+vR7dLdlLacnziKuVlexqOHBvw+c Hpkk9LsFuL6D0F2qIKMwfq8Nccazsw== =LOKW -----END PGP SIGNATURE----- --==-=-=--