From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 19 20:57:13 2022 Received: (at 32947) by debbugs.gnu.org; 20 Aug 2022 00:57:13 +0000 Received: from localhost ([127.0.0.1]:59416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPCnY-0003Km-FU for submit@debbugs.gnu.org; Fri, 19 Aug 2022 20:57:12 -0400 Received: from mail-pj1-f41.google.com ([209.85.216.41]:51140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPCnV-0003KY-Dq for 32947@debbugs.gnu.org; Fri, 19 Aug 2022 20:57:10 -0400 Received: by mail-pj1-f41.google.com with SMTP id g18so6082162pju.0 for <32947@debbugs.gnu.org>; Fri, 19 Aug 2022 17:57:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc; bh=JuOiaigB7oRC8qN22D6SiNVYe7JbDE9VWPYn261i0JY=; b=LjxnY7prbTfk+JgPCHq3zCt41hD8ZcB0AGShJ9CrtiN6eHcsSjXr5qI+Lho2L9THjv f+hLLuzWAktohhILJAPLL3sBGmcMiOutZSrAvz/fv8980o0eUDVcVphGAthdtvIOV4l7 m5O5o5i3WKYuCxxTS2oInALXy086PLjWuVHNQEw6vO/bqU4x3WRIE/XOASnLK3pK5ALt dr2q32lsV3Bn5pIYRes8K+Pmw62klACfbsumHHDvRSlgXLQ7aAoUbCAuKxyzPX5o+xGg ggHHUM8RoD4xlcCk6yp5UybOqY8+z2cieOtUzhQThmMRNuVi57xVIa3Q0N9trArtSBVB Xhyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc; bh=JuOiaigB7oRC8qN22D6SiNVYe7JbDE9VWPYn261i0JY=; b=yfdXCQkWC24AlaQXmP5dNw7ErLrrQiL7wKc/X3LECRQsBVoWt8L3g0DJo4nS/w0590 ++guAQBzCHk3DU6zF7DVItz4daLPpElH8wJDcFGjRZu9aMiwiv0Oq+XLkifJ1/JT/N3z H3W08DM4Fflg/gIXKyEjDjFtGna14Az9PLXaTOz2wZUKg/VSabxCMdP0xfzwRFQHf/1z iCoY8TcArtPpdwuaVCWF3psHGMrbyzUe5wzyn3DRohcNHilXHreQ+G/hPmqDJJXrkmuq IEYYZs0EWyOhIIFTVjDk+MogS+DnT4w7rKPrRlufacLCgpwhXWKU6ZX8J0YrUAVZb+M9 3ZOA== X-Gm-Message-State: ACgBeo0nWfhKNKg88miDCdlQuI/nHMNYmm/GUrxLvp64zsucXASDGZ5V jhvVueUwIPaP39cE/KsSE5CBJp2o6qw= X-Google-Smtp-Source: AA6agR5ymtIF+xhcynkn1AKRSRguBIwveJh6NbAT47HRxudKFEysQpPXokWGF6lp8f7MbbEwgFNadw== X-Received: by 2002:a17:902:ec90:b0:16e:d8d8:c2db with SMTP id x16-20020a170902ec9000b0016ed8d8c2dbmr9712100plg.69.1660957023158; Fri, 19 Aug 2022 17:57:03 -0700 (PDT) Received: from Ginko.local ([66.170.190.211]) by smtp.gmail.com with ESMTPSA id w13-20020aa7954d000000b0052d40c4c06esm4006890pfq.39.2022.08.19.17.57.02 for <32947@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 17:57:02 -0700 (PDT) From: Frank Pursel X-Google-Original-From: Frank Pursel To: 32947@debbugs.gnu.org Subject: Add java-xalan-interp Date: Fri, 19 Aug 2022 17:57:01 -0700 Message-ID: <87r11b4tr6.fsf@Ginko.local.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32947 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I was able to apply this patch on current master > ec6122250de7c83a7e77054584a34767b11337db ... and successfully build > java-xalan-interp! > > But this appears to add java-xalan-interp, but the subject is "Add > java-xalan". Back in 2018 people tried to add java-xalan but it never happened because the dependencies were never factored out and the author of the original effort apparently lost interest. I submitted an original patch to build an alternate, interpreted, version of xalan that avoided use of the unbootstrappable dependencies that were the earlier problem. Maxime prompted significant improvements to this patch to obtain the final version which you built but I thought it should have a name to distinguish it from the most common version which we did not build. The version this patch builds is an 'interpreted' version so I labelled it java-xalan-interp. Presumably, in a future where java-cup could be bootstrapped (currently it cannot be bootstrapped and so is excluded from guix and unused in this build of java-xalan-interp) we might eventually be able to provide java-xalan and comparisons might be made with java-xalan-interp. > I'm not confident in reviewing the whole patch series, and not terribly > savvy with guile or java ... > > The patches started in 2018, are some of the earlier patches applied? > Are there other patches that still need applying? Or can they be > dropped? They can be dropped because they were in the depricated style as well as depended on binary blobs from other sources that are not in guix and have not yet proven to be bootstrappable in guix. > > Do you have a summary of the discussion around licensing and other > issues? Makes me a bit nervous to apply patches as the current status is > not totally clear to me. > Summarizing -- the details are all above -- Maxime Devos identified some code from other projects included in the xalan source bundle which was of a suspicious nature. The patch here deletes this code and only creates an older version of xalan that is interpreted rather than compiled with the unbuildable compiler dependency. Maxime conducted a nearly line by line scrutiny of all the code and found two reference to JDK1.0 sources that he asked about upstream. Apache responded that the identified code was depricated by the JDK and that they had continued to maintain it. He also found a drawing that was part of the testing code for which we added correct acknowledgement in the current package. I believe all these curiosities have been appropriately considered. No further action is either needed or anticipated. > If these aren't the first generation patches in the series, maybe > re-send the patches that still need applying as a [PATCH v2] (or v3? > v4?) in the subject of each patch? The patch you built is the only one needed to build the entire java-xalan-interp library. The earlier versions are no longer relevant. > With a summary clarifying the licensing and which exact patches still > need applying, that would make it a lot easier to review! > > > Thanks for contributing to guix, and hanging onto patience with the > process! > > > live well, > vagrant Hoping that guix will soon be able to add this complete xalan implementation to guix in the near future. Regards, Frank Pursel