From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 08 13:36:30 2018 Received: (at 31531) by debbugs.gnu.org; 8 Jul 2018 17:36:30 +0000 Received: from localhost ([127.0.0.1]:51345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fcDbq-00042J-KX for submit@debbugs.gnu.org; Sun, 08 Jul 2018 13:36:30 -0400 Received: from mx2.mailbox.org ([80.241.60.215]:57336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fcDbp-000426-Md for 31531@debbugs.gnu.org; Sun, 08 Jul 2018 13:36:30 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx2.mailbox.org (Postfix) with ESMTPS id 5393A41346; Sun, 8 Jul 2018 19:36:23 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter03.heinlein-hosting.de (spamfilter03.heinlein-hosting.de [80.241.56.117]) (amavisd-new, port 10030) with ESMTP id dOT2jCPkHs6q; Sun, 8 Jul 2018 19:36:22 +0200 (CEST) References: <87bmdbtr7p.fsf@foradis.org> <20180519185437.23665-1-theodoros@foradis.org> <87vabgoimj.fsf@elephly.net> From: Theodoros Foradis To: Ricardo Wurmus Subject: Re: [bug#31531] [PATCH 1/3] gnu: Add cppzmq. In-reply-to: <87vabgoimj.fsf@elephly.net> Date: Sun, 08 Jul 2018 20:35:46 +0300 Message-ID: <87d0vxy6j1.fsf@foradis.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31531 Cc: Theodoros Foradis , 31531@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Ricardo, > Could you please send a new patch? Sorry for taking so long to send the new patch. In the meantime, monero was updated to 0.12.3.0 with a major difference, that using the system's miniupnpc was disabled, and the project's own version of it (due to security issues upstream) was added as a git submodule. So, there were 3 options for us. Either build from git and use the git submodule, disregard the security issue (that the folks at #monero-dev on freenode advised against) and use our own miniupnpc, or use monero's miniupnpc. I opted for the third option, introducing a patch that reverts the git commit that does not allow to use external miniupnpc, as well as packaging monero-project's miniupnpc as a non-public package in finance.scm. Is this the correct way to do this? Also, I included a commit renaming monero-core to monero-gui, as the official project was renamed. Is this appropriate? The old url (using monero-core) still worked as it's an alias for monero-gui now, but I figured it would be better to rename nonetheless. Lastly, I changed both packages to use git-fetch, as the github auto-generated tarballs would change. What do you think? I reply to this mail with the updated patch series. -- Theodoros Foradis