From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 04 09:22:20 2018 Received: (at 30991) by debbugs.gnu.org; 4 Sep 2018 13:22:21 +0000 Received: from localhost ([127.0.0.1]:45173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxBHg-0006hi-OL for submit@debbugs.gnu.org; Tue, 04 Sep 2018 09:22:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxBHg-0006hW-0t for 30991@debbugs.gnu.org; Tue, 04 Sep 2018 09:22:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxBHV-0005L1-BT for 30991@debbugs.gnu.org; Tue, 04 Sep 2018 09:22:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41597) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxBHV-0005Kl-6M; Tue, 04 Sep 2018 09:22:09 -0400 Received: from [193.50.110.186] (port=49074 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fxBHU-0000S0-SX; Tue, 04 Sep 2018 09:22:09 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: [bug#30991] [PATCH v2 2/3] services: Add modem-manager-service-type. References: <20180329222140.21590-1-dannym@scratchpost.org> <20180329222140.21590-3-dannym@scratchpost.org> <87tvswjk8h.fsf@gnu.org> Date: Tue, 04 Sep 2018 15:22:07 +0200 In-Reply-To: <87tvswjk8h.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 31 Mar 2018 18:14:06 +0200") Message-ID: <87d0ttbdog.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30991 Cc: 30991@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hello Danny, ludo@gnu.org (Ludovic Court=C3=A8s) skribis: > Danny Milosavljevic skribis: > >> * gnu/services/networking.scm (modem-manager-service-type): New variable. >> (): New variable. >> (modem-manager-configuration): New procedure. >> (modem-manager-configuration?): New procedure. >> * doc/guix.texi (Networking Services): Document it. > > LGTM, thanks! Ping! :-) I think the only question was about patch 3/3, which adds ModemManager to =E2=80=98%desktop-services=E2=80=99. I=E2=80=99m in favor of dropping p= atch 3/3, but regardless patches 1/3 (the variant that moves =E2=80=98static-networking-service-type=E2=80=99 to (gnu services base), as= we discussed) and 2/3 can definitely go in! Thanks, Ludo=E2=80=99.