From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 29 16:14:07 2018 Received: (at 30950) by debbugs.gnu.org; 29 Mar 2018 20:14:07 +0000 Received: from localhost ([127.0.0.1]:59082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1dvz-0005LN-BV for submit@debbugs.gnu.org; Thu, 29 Mar 2018 16:14:07 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:45928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1dvx-0005LF-3I for 30950@debbugs.gnu.org; Thu, 29 Mar 2018 16:14:05 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 8777812BDD; Thu, 29 Mar 2018 22:14:04 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dGEVkCx6bWSj; Thu, 29 Mar 2018 22:14:03 +0200 (CEST) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id CFB0012BD7; Thu, 29 Mar 2018 22:14:02 +0200 (CEST) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Carlo Zancanaro Subject: Re: [bug#30950] [PATCH shepherd]: Update required guile version, and remove some hacks References: <87lgefuk4o.fsf@zancanaro.id.au> Date: Thu, 29 Mar 2018 22:14:01 +0200 In-Reply-To: <87lgefuk4o.fsf@zancanaro.id.au> (Carlo Zancanaro's message of "Mon, 26 Mar 2018 22:55:03 +1100") Message-ID: <87605evdva.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 30950 Cc: 30950@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hello! Carlo Zancanaro skribis: > I'm not very familiar with autotools, but I think I got the configure > incantation right (I stole it from Guix). Well done. :-) > From 8c812534137a5dc17dd8073706983c451d26f2db Mon Sep 17 00:00:00 2001 > From: Carlo Zancanaro > Date: Mon, 26 Mar 2018 14:44:18 +1100 > Subject: [PATCH 1/3] Update Guile dependency to 2.0.13 or later > > * README (Requirements): Change 2.x to 2.0.13 or later. > * configure.ac: Check for 2.0.13 or later if Guile 2.0 is detected. LGTM. > From e11708aba0fbafd4c83273ee1fa5147e54d1c80e Mon Sep 17 00:00:00 2001 > From: Carlo Zancanaro > Date: Mon, 26 Mar 2018 14:49:18 +1100 > Subject: [PATCH 2/3] Remove EINTR-safe, and all references to it. > > * modules/shepherd/support.scm (EINTR-safe): Remove procedure and its exp= ort. > * modules/shepherd/service.scm (system*, system*): Remove now-unnecessary > procedures. > (waitpid*): Remove references to EINTR-safe. > * modules/shepherd.scm (main): Remove references to EINTR-safe. LGTM. > From 63bc9339d88d8f1bd8a9b366774ce8e33d76dd00 Mon Sep 17 00:00:00 2001 > From: Carlo Zancanaro > Date: Mon, 26 Mar 2018 14:55:32 +1100 > Subject: [PATCH 3/3] Remove SIGALRM hack. > > * modules/shepherd.scm (main): Remove SIGALRM hack for guile <=3D 2.0.9. > --- > modules/shepherd.scm | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/modules/shepherd.scm b/modules/shepherd.scm > index 5d97598..69fd69d 100644 > --- a/modules/shepherd.scm > +++ b/modules/shepherd.scm > @@ -207,15 +207,6 @@ > (apply format #f (gettext (cadr args)) (caddr args)) > (quit 1)))) >=20=20 > - (when (provided? 'threads) > - ;; XXX: This terrible hack allows us to make sure that signal ha= ndlers > - ;; get a chance to run in a timely fashion. Without it, after a= n EINTR, > - ;; we could restart the accept(2) call below before the correspo= nding > - ;; async has been queued. See the thread at > - ;; . > - (sigaction SIGALRM (lambda _ (alarm 1))) > - (alarm 1)) Unfortunately I think the problem remains. That=E2=80=99s one of the reaso= ns for using signalfd(2). Can you create an account on Savannah so I can add you to the group and let you push the first two patches? :-) Thank you! Ludo=E2=80=99.