From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 30 07:17:26 2018 Received: (at 30948) by debbugs.gnu.org; 30 Mar 2018 11:17:26 +0000 Received: from localhost ([127.0.0.1]:59412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1s2A-0004pI-9Q for submit@debbugs.gnu.org; Fri, 30 Mar 2018 07:17:26 -0400 Received: from mail-pf0-f177.google.com ([209.85.192.177]:34941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1s28-0004p5-Op for 30948@debbugs.gnu.org; Fri, 30 Mar 2018 07:17:25 -0400 Received: by mail-pf0-f177.google.com with SMTP id u86so5266826pfd.2 for <30948@debbugs.gnu.org>; Fri, 30 Mar 2018 04:17:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:references:user-agent:from:to:cc:subject:message-id :in-reply-to:date:mime-version; bh=RbwRXuM9eqeFTsC0SnbqvbyKnD7Eu8LVAQukofh3w4s=; b=mys2BoJj+I+T/fVyuie/jaUKlJxyasp89PzNLyTmhAFdKAPuM0PhSv2j8teWtEuvBJ 6MXgZpCP2Ky75oW3m2IL9nfCIBbTjBHNiev4v64Zb+FHspcHPs4Z+F7jQK+K3Xge5Iaa Ng0UZDsaa5CuENI1RmAPbs+/cd/0ezWG9XvnvqPpnynmNhghr3l7c70JQeY7Ak0b7XRS 5etZ+6SEOxClkOyRRRAt/wQckDgE/xbYBL/MOZ3I2MfG22sopfyJh/ehJ34VUjpDaWkv LneyPTHxTdkRc++c7DWN9vCU2+j4eK3JF1eIm5oWFDVdOXwACewysl1a3GtxHMFXyPTJ GYlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:references:user-agent:from:to:cc:subject :message-id:in-reply-to:date:mime-version; bh=RbwRXuM9eqeFTsC0SnbqvbyKnD7Eu8LVAQukofh3w4s=; b=LiTTMDQT+nW3Tifp2NDsVduyKPujL9qp4enXt9JJkmT6/Ik7RaE21QWsNkth+rb+d4 OvaxZlAkXcd5x86VxXvUSx9mtXlVUYojYrXO1zij1lKNeLe3VqryZek7kGu0dJxgWZFa xD7/3ACEgSVJ7exET014ei6n0mDoz+BjieJ11REUNDIHlHIS7HfzPYHajn+DZ9FwVaX2 DWOgGxGx6XWcpb49Oeq5HkvOmwoRWGC3cV0esqCwV82j0ON0qCg031ahC8CLXu2DjNQ0 ENSnxesY5MmGtsPPAYRjn4NPp7AoApbvLBk+EyZFy3D7iu4kI/VZd3ErFfUJnroujRx5 8Whg== X-Gm-Message-State: AElRT7EJOEizaVpAY8L+Z6goI7/u0zD6Q1S/wZmSthsV2DMN69dr9Yg6 gwkzinshB9dnljCqUSzMYz3QIdKa X-Google-Smtp-Source: AIpwx4+lBCUn7quopdFhMebAEjY57bEwV4MnGGJoFa1axNKb3cevh8kppGbpQ3N6S3OpcCa8l+R3yA== X-Received: by 10.99.190.5 with SMTP id l5mr8324299pgf.25.1522408638081; Fri, 30 Mar 2018 04:17:18 -0700 (PDT) Received: from gengar (210-1-202-160-cpe.spintel.net.au. [210.1.202.160]) by smtp.gmail.com with ESMTPSA id k70sm15013354pga.72.2018.03.30.04.17.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 30 Mar 2018 04:17:17 -0700 (PDT) References: <87muyvulwt.fsf@zancanaro.id.au> <87bmf6ve6u.fsf@gnu.org> <87sh8id1mg.fsf@zancanaro.id.au> <87vadeou54.fsf@gnu.org> User-agent: mu4e 1.0; emacs 25.3.1 From: Carlo Zancanaro To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#30948] [PATCH core-updates] guix: Reap finished child processes in build containers. Message-ID: <87o9j5x1d4.fsf@zancanaro.id.au> In-reply-to: <87vadeou54.fsf@gnu.org> Date: Fri, 30 Mar 2018 22:17:06 +1100 MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 30948 Cc: 30948@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hey, On Fri, Mar 30 2018, Ludovic Court=C3=A8s wrote: >> From what I can understand it's one of pid 1's responsiblities=20 >> to reap child processes, so I would expect this to be set up=20 >> for every builder, before the builder is run. > > True, but for derivations it=E2=80=99s also =E2=80=9Coptional=E2=80=9D be= cause=20 > eventually guix-daemon terminates all its child processes. As long as the build process doesn't rely on behaviour that,=20 strictly speaking, it should be allowed to rely on. It's not an=20 issue of resource leaking, it's an issue of correctness. >> Given it's not specific to the gnu-build-system, I don't think=20 >> it really fits there. > > Yes, but note that it would be inherited by all the build=20 > systems. Except for trivial-build-system, which is probably fine. I still=20 don't think it fits in a specific build system, given it's a=20 behaviour that transcends the specific action happening within the=20 container. Putting it in gnu-build-system will solve the problem in all=20 realistic cases, so that's probably fine. It's still subtly=20 incorrect, but will only be a problem if something using the=20 trivial build system relies on pid 1 to reap a process, or if we=20 make a new build system not deriving from gnu-build-system (which=20 seems unlikely, but not impossible). > The =E2=80=9Cbuild side=E2=80=9D is fully specified: =E2=80=98guix graph= =E2=80=99 shows exactly=20 > what Guile is used where, and you can see with, say: > > guix graph -t derivation \ > -e '(@@ (gnu packages commencement) findutils-boot0)' > > that the early derivations run on Guile 2.0.9. > > For =E2=80=9Chost side=E2=80=9D code, users can use any Guile >=3D 2.0.13. Yeah, okay. That makes sense. I guess I just expected 2.0.13 to be=20 the minimum version throughout. Carlo --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEwWt2bKTcV+mIZ20oCShLEsLiKqIFAlq+HLIACgkQCShLEsLi KqL7WAgAyftn/CJ0pPyDVc6L3qwhmU58s5hsT6U+E7TkRdkdf1NY6Hl1JK4JygJt FRFy7IuDgPWm4UpuBrCbHTbA5G7yzNoSqPzFiG+ephJmXvCyCg578NEfLD/ChUmz D/ES/rWw/rFmqTWTVxHZrnC7buiNOS9BgiiMkYbZ5cmAP1s77pzGFPKiZXoyp5zw zyn3lGPlh+ULvLGah+PdjLMM74qhIi7y3MDpGdRuHEFmCP4+vdz/33bZKwFqQ1YE Cj3Yi2tDPA4Ana0oAqCs4SMLGcseaZpAR4CmkDqaMq4t891k+JJ6EcvV45dFF0is 7gba+//F3RQAH9e1ujrp3SXCweO2GA== =qY0n -----END PGP SIGNATURE----- --=-=-=--