From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 09 17:26:57 2018 Received: (at 30604) by debbugs.gnu.org; 9 Mar 2018 22:26:57 +0000 Received: from localhost ([127.0.0.1]:52901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euQTY-0003R0-PE for submit@debbugs.gnu.org; Fri, 09 Mar 2018 17:26:56 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:50772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euQTX-0003Qs-AL for 30604@debbugs.gnu.org; Fri, 09 Mar 2018 17:26:55 -0500 Received: from localhost (178.113.255.63.wireless.dyn.drei.com [178.113.255.63]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 26D5D33600C4 for <30604@debbugs.gnu.org>; Fri, 9 Mar 2018 23:26:54 +0100 (CET) Date: Fri, 9 Mar 2018 23:26:50 +0100 From: Danny Milosavljevic To: 30604@debbugs.gnu.org Subject: Re: [PATCH v9 7/7] linux-initrd: Use module-aliases->module-file-names, too. Message-ID: <20180309232650.0f37fb89@scratchpost.org> In-Reply-To: <20180304010914.1322-8-dannym@scratchpost.org> References: <20180303135533.6112-1-dannym@scratchpost.org> <20180304010914.1322-1-dannym@scratchpost.org> <20180304010914.1322-8-dannym@scratchpost.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/Qg9Kzc.tiVe2MTnqVgF7R4i"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30604 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Sig_/Qg9Kzc.tiVe2MTnqVgF7R4i Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 4 Mar 2018 02:09:14 +0100 Danny Milosavljevic wrote: > --- a/gnu/system/linux-initrd.scm > +++ b/gnu/system/linux-initrd.scm > @@ -161,17 +161,17 @@ the derivations referenced by EXP are automatically= copied to the initrd." > #:references-graphs `(("init-closure" ,init) > ("modprobe-closure" ,modprobe)= ))) > =20 > -(define (flat-linux-module-directory linux modules) > - "Return a flat directory containing the Linux kernel modules listed in > -MODULES and taken from LINUX." > +(define (flat-linux-module-directory linux aliases) > + "Return a flat directory containing the Linux kernel modules resolved = by > +ALIASES and taken from LINUX." ... > + (define (find-only-entry directory) > + (match (scandir directory) > + (("." ".." basename) > + (string-append directory "/" basename)))) Probably unsafe since the order is not guaranteed. --Sig_/Qg9Kzc.tiVe2MTnqVgF7R4i Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlqjCioACgkQ5xo1VCww uqXOZQgAkZgLnU86tFzMFoHikvaAZ41DEtYdjK+787F90a0+RSvTIMDMpFXvL40K LjRBRv3k7Im8o/gw4v0h0Jx9DhfwKmL7zXOOFkaK4urXx80Gfp49kozLeAUJWutP LRt3kn4hqw8PQzT/nDW46jH9GnNUyCAk2sANoQQWOdk+LpBc1EHs4Z571y6rQDb8 i6x9Ui3CNvDHYXjWsRDRS1+EIZaKTNpeTbD9/iyZOLltD6CXR37/6vgPyKP/kqE9 RHtHdwyrl6MVfPuomee2iiqC5z1HT+EXWjevXXVkIvP1azIGwM2mWxpJLynDO5Ld 0KYbk0UMDZ3/HFCSbcoODoMwvFeNEA== =PIV0 -----END PGP SIGNATURE----- --Sig_/Qg9Kzc.tiVe2MTnqVgF7R4i--