From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 04 07:45:13 2018 Received: (at 30604) by debbugs.gnu.org; 4 Mar 2018 12:45:13 +0000 Received: from localhost ([127.0.0.1]:43520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esT0r-00062x-LN for submit@debbugs.gnu.org; Sun, 04 Mar 2018 07:45:13 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:36744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esT0q-00062p-8C for 30604@debbugs.gnu.org; Sun, 04 Mar 2018 07:45:12 -0500 Received: from localhost (77.118.231.171.wireless.dyn.drei.com [77.118.231.171]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 2D4963367616; Sun, 4 Mar 2018 13:45:11 +0100 (CET) Date: Sun, 4 Mar 2018 13:45:04 +0100 From: Danny Milosavljevic To: ludo@gnu.org (Ludovic =?ISO-8859-1?Q?Court=E8s?=) Subject: Re: [bug#30604] [PATCH v8 2/7] linux-modules: Add install-modules. Message-ID: <20180304134504.0a15b26d@scratchpost.org> In-Reply-To: <87y3j84xtu.fsf@gnu.org> References: <20180302153408.14091-1-dannym@scratchpost.org> <20180303135533.6112-1-dannym@scratchpost.org> <20180303135533.6112-3-dannym@scratchpost.org> <87y3j84xtu.fsf@gnu.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/4j2QMexvE7dYMZ.hPX8mPXg"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30604 Cc: 30604@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Sig_/4j2QMexvE7dYMZ.hPX8mPXg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, > (write-module-alias-database modules port) ;for =E2=80=9Cmodules.alias= =E2=80=9D > (write-module-device-database modules port) ;for =E2=80=9Cmodules.devna= me=E2=80=9D I'd prefer "install-" because their interface is somewhat like install-file (caller provides output directory and callee adds "modules."* automatically= ). But I used the names "write-module-"* in the patchset v9. > I=E2=80=99m not sure we need =E2=80=98install-module-files=E2=80=99 itsel= f. Perhaps we can > inline it at the call site? Sure. Did so now. > For the devname code, please avoid =E2=80=98set!=E2=80=99. I found an even better way to avoid both. > The indentation of =E2=80=98match=E2=80=99 forms is wrong. Would it be O= K for you to > pass it through ./etc/indent-code.el? (It=E2=80=99s non interactive, you= don=E2=80=99t > need to actually use Emacs.) I'm actually trying to switch to emacs but when I press Tab it messes up the stuff more. Is there some kind of configuration for guile indentation? Also, every time I open gnu/build/linux-modules.scm I get "The local variables list .. may not be safe * bug-reference-bug-repexp * eval: (modify-syntax-entry 126 "'") * eval: (modify-syntax-entry 36 "'") * eval: (modify-syntax-entry 43 "'")" ??? --Sig_/4j2QMexvE7dYMZ.hPX8mPXg Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlqb6lAACgkQ5xo1VCww uqVseAf/VW2PLCgcY8nImiTi4YlI/BODnYJVCkVIzmA5x/hS3+5OxKXh1LnUjECD p50Bhz9u8i6v3P6PFKYa7Om3aowsyKOH9E2nochuk8tGKkbBWTPA6ou2TZcJBE2G SjswuTE7nUBBIjg8vEEzZ9ufF536jDzrzzsyFaVTHlfCHr/eTJ29fg9fR0wMPGgB PVHZKSI5J0zrZycmSlO8+I1m/NQGzvUMDE2V01DGGIhbLQhcOSy/YL8hCYwbBF+G lMznbEgw+ZjvoZCeRJfooZeuRU/myeAbJ1mAVUlTeDLLdZzFKOTqTyRR/e7B9jUT hCsEiOUOX4Pino5+64dzLsfv16jBcg== =wMFl -----END PGP SIGNATURE----- --Sig_/4j2QMexvE7dYMZ.hPX8mPXg--