From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 03 16:58:40 2018 Received: (at 30604) by debbugs.gnu.org; 3 Mar 2018 21:58:40 +0000 Received: from localhost ([127.0.0.1]:43230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esFAu-0006ep-4C for submit@debbugs.gnu.org; Sat, 03 Mar 2018 16:58:40 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:54924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esFAs-0006eh-IA for 30604@debbugs.gnu.org; Sat, 03 Mar 2018 16:58:39 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id EA45611D90; Sat, 3 Mar 2018 22:58:37 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gcfN9Wz-4cDE; Sat, 3 Mar 2018 22:58:37 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 113E8111A6; Sat, 3 Mar 2018 22:58:37 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: [bug#30604] [PATCH v8 1/7] linux-modules: Add module-aliases. References: <20180302153408.14091-1-dannym@scratchpost.org> <20180303135533.6112-1-dannym@scratchpost.org> <20180303135533.6112-2-dannym@scratchpost.org> Date: Sat, 03 Mar 2018 22:58:36 +0100 In-Reply-To: <20180303135533.6112-2-dannym@scratchpost.org> (Danny Milosavljevic's message of "Sat, 3 Mar 2018 14:55:27 +0100") Message-ID: <87371g6ctv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 30604 Cc: 30604@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Danny Milosavljevic skribis: > * gnu/build/linux-modules.scm (module-aliases): New variable. LGTM! > +(define (module-aliases file) > + "Return the list of aliases of module FILE." > + (let ((info (modinfo-section-contents file))) > + (filter-map (match-lambda > + (('alias . value) > + value) > + (_ #f)) (modinfo-section-contents file)))) Nitpick: align like this: (filter-map first second) when the first arg spans several lines.