From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 10:07:58 2018 Received: (at 30604) by debbugs.gnu.org; 25 Feb 2018 15:07:58 +0000 Received: from localhost ([127.0.0.1]:60535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1epxu9-0001yP-WD for submit@debbugs.gnu.org; Sun, 25 Feb 2018 10:07:58 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:46008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1epxu8-0001yH-8G for 30604@debbugs.gnu.org; Sun, 25 Feb 2018 10:07:56 -0500 Received: from localhost (77.118.165.54.wireless.dyn.drei.com [77.118.165.54]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 9A68E33606CB; Sun, 25 Feb 2018 16:07:54 +0100 (CET) Date: Sun, 25 Feb 2018 16:07:50 +0100 From: Danny Milosavljevic To: Mathieu Othacehe Subject: Re: [bug#30604] [PATCH 3/4] linux-initrd: Add kmod. Message-ID: <20180225160750.46bf5b50@scratchpost.org> In-Reply-To: <87vaelf9ln.fsf@gmail.com> References: <20180225114557.816-1-dannym@scratchpost.org> <20180225114816.869-1-dannym@scratchpost.org> <20180225114816.869-3-dannym@scratchpost.org> <87vaelf9ln.fsf@gmail.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30604 Cc: 30604@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Mathieu, thanks for the review. On Sun, 25 Feb 2018 15:05:24 +0100 Mathieu Othacehe wrote: > > + ; -E > > Why is this commented ? Because it's an option for specifying the location of "Module.symvers" - and I don't know whether guix uses it (probably not). If one doesn't specify an option, depmod will default to the running kernel - which is not what we want. I should elaborate in the comment that, if we start using Module.symvers, we MUST pass "-E" there. Maybe better to even just check for the file existence and add it right now, otherwise we might forget later. What do you think?