From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 26 06:52:01 2018 Received: (at 30604) by debbugs.gnu.org; 26 Feb 2018 11:52:01 +0000 Received: from localhost ([127.0.0.1]:32826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqHK5-00075N-ES for submit@debbugs.gnu.org; Mon, 26 Feb 2018 06:52:01 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:37279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqHK3-00075A-F7 for 30604@debbugs.gnu.org; Mon, 26 Feb 2018 06:51:59 -0500 Received: by mail-wm0-f45.google.com with SMTP id 139so3519697wmn.2 for <30604@debbugs.gnu.org>; Mon, 26 Feb 2018 03:51:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=5i6T3rxqP8CWJWRxiWNh6xDnQ5Hvl15DMRbhDNWQMdI=; b=Wse6k8247do6aHihrvX3dKSu+y/PWmohVtP8kSh9pVkHJ7oU6kSMiWoqZCfjhwd2FB 9XL9HKEvheHn4BPrP7Ubqw3zEmltu1Fts3gDRKX6toHc3IqCcuYxAE4gi98Jtn23pXtn duh82szm94cqaarjfTkRKUEJmz+XsDsrWBnFBX1JANNKVps+vQCdBU1ThpCRx+sRrUVM 862dzqlGNVvdsinV/txl1+Iljv/857iyWYJQPs9qY2gYsf/oUcyoBLHYXmiVMvDyCoTf WCpUq+6G5/wH3ymmhpeHSIrONq7tJoWIzY4BF4ZQK55WQzPgajiSe7Ckce6N5XbR5Y12 Bb9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=5i6T3rxqP8CWJWRxiWNh6xDnQ5Hvl15DMRbhDNWQMdI=; b=LKi8ltl1CByVwAog/ENeeNHHGqTGbecP2OjgojHkjsq5cVY/uRnVGfjHErm8XmbkpG UV7akTall3Hl/56sASqU6I2lTQSGrq0BsMBT+ONnyYC6iRCsCZvkPl6J7ApDfu3p7Mes PSYHCKHUD9JjowIBCQplhqQTtz0uRStAMjTu/VPE/T/g9G8/Cp+sJaUAoTY74iDVzFIn rGHU3tXf30cvsH6EPyXWDuu7lDJy1INSj1ONtsQm9kvcdvMJt5G5iqcqLtyfDkAz/woy uHirvhq52wLddIu1ystJxgJWWwfK/9q213mIVvYLgYvWwUnLpEWXPTpUct9BZnOI3uXl SgOA== X-Gm-Message-State: APf1xPD9yeL0GxO7UgL29XYX5f0Urst2Y5yVo58jcHcAr4mfBWWFH3Am 5IDXVoCuFFcgCOjq4n3wpOQ92w== X-Google-Smtp-Source: AG47ELugXm3kREm1j/NY1qEAXEvwcJDzkGcHEr4LKGGF0FAVmDWCLHjAr4rwmDZ/K0WcsVJTaltBWg== X-Received: by 10.28.133.129 with SMTP id h123mr8763571wmd.146.1519645913390; Mon, 26 Feb 2018 03:51:53 -0800 (PST) Received: from denali ([46.218.109.88]) by smtp.gmail.com with ESMTPSA id x78sm19032749wmd.2.2018.02.26.03.51.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Feb 2018 03:51:52 -0800 (PST) References: <20180225114557.816-1-dannym@scratchpost.org> <20180225114816.869-1-dannym@scratchpost.org> <20180225114816.869-3-dannym@scratchpost.org> <87vaelf9ln.fsf@gmail.com> <20180225160750.46bf5b50@scratchpost.org> User-agent: mu4e 0.9.18; emacs 25.3.1 From: Mathieu Othacehe To: Danny Milosavljevic Subject: Re: [bug#30604] [PATCH 3/4] linux-initrd: Add kmod. In-reply-to: <20180225160750.46bf5b50@scratchpost.org> Date: Mon, 26 Feb 2018 12:51:51 +0100 Message-ID: <87h8q4j7e0.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30604 Cc: 30604@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hey Danny, > Because it's an option for specifying the location of "Module.symvers" - and > I don't know whether guix uses it (probably not). If one doesn't specify an > option, depmod will default to the running kernel - which is not what we want. > > I should elaborate in the comment that, if we start using Module.symvers, we > MUST pass "-E" there. Maybe better to even just check for the file existence > and add it right now, otherwise we might forget later. What do you think? Reading 'depmod' manpage, I understand that -E and -F are mutually exclusive. Both options seem to have an interest only if -e is supplied to "reports any symbols which a module needs which are not supplied by other modules or the kernel". So maybe something like "-F (string-append #$linux "/System.map") -e" would make more sense ? Mathieu