From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 14 13:18:39 2018 Received: (at 30434) by debbugs.gnu.org; 14 Feb 2018 18:18:39 +0000 Received: from localhost ([127.0.0.1]:43138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em1df-0003kd-BY for submit@debbugs.gnu.org; Wed, 14 Feb 2018 13:18:39 -0500 Received: from world.peace.net ([50.252.239.5]:58498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em1de-0003kQ-38 for 30434@debbugs.gnu.org; Wed, 14 Feb 2018 13:18:38 -0500 Received: from pool-72-93-28-59.bstnma.east.verizon.net ([72.93.28.59] helo=jojen) by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1em1dY-0006mQ-0d; Wed, 14 Feb 2018 13:18:32 -0500 From: Mark H Weaver To: Alex Kost Subject: Re: bug#30434: magit =?utf-8?Q?won=E2=80=99t?= work over TRAMP References: <87lgfyl67x.fsf@elephly.net> <87mv0e2jvm.fsf@gmail.com> <876072koq0.fsf@elephly.net> <87wozgosxx.fsf@netris.org> <871shny0a1.fsf@gmail.com> Date: Wed, 14 Feb 2018 13:17:57 -0500 In-Reply-To: <871shny0a1.fsf@gmail.com> (Alex Kost's message of "Wed, 14 Feb 2018 20:00:06 +0300") Message-ID: <877erfph9m.fsf@netris.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30434 Cc: rekado@elephly.net, 30434@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Hi Alex, Alex Kost writes: > Mark H Weaver (2018-02-14 03:51 -0500) wrote: > >> Ricardo Wurmus writes: >>> I think it makes sense *not* to hardcode the path to the git executable >>> here. >> >> Agreed. Done, in commit 5fe9ba59ba1cea12a70d011aacbace52e3bfda18 on >> master and commit 317e8e9404058af35d9843e076934560f95d895a on >> core-updates. I'm closing this bug now. > > You didn't remove "git" from the inputs. I think it is not needed now. I removed it on my first attempt, but the build failed. See below. Mark --8<---------------cut here---------------start------------->8--- starting phase `build' Cannot open load file: No such file or directory, /tmp/guix-build-magit-2.11.0.drv-0/magit-2.11.0/magit-version.el make[1]: Entering directory '/tmp/guix-build-magit-2.11.0.drv-0/magit-2.11.0/Documentation' make[1]: Entering directory '/tmp/guix-build-magit-2.11.0.drv-0/magit-2.11.0/lisp' Cannot open load file: No such file or directory, /tmp/guix-build-magit-2.11.0.drv-0/magit-2.11.0/Documentation/magit-version.el Generating magit.info Compiling git-commit.el Compiling magit-popup.el Compiling magit-utils.el Generating magit-autoloads.el Generating magit-version.el Compiling magit-section.el Compiling magit-git.el Compiling magit-mode.el Compiling magit-margin.el Compiling magit-process.el Generating magit-popup.info Compiling magit-autorevert.el Compiling magit-core.el Compiling magit-diff.el Generating dir make[1]: Leaving directory '/tmp/guix-build-magit-2.11.0.drv-0/magit-2.11.0/Documentation' Compiling magit-repos.el Compiling magit-log.el Compiling magit-wip.el Compiling magit-apply.el Compiling magit.el Compiling magit-refs.el Compiling magit-status.el In toplevel form: magit-status.el:30:1:Error: Searching for program: No such file or directory, git make[1]: *** [Makefile:61: magit-status.elc] Error 1 make[1]: *** Waiting for unfinished jobs.... In toplevel form: magit-refs.el:30:1:Error: Searching for program: No such file or directory, git make[1]: *** [Makefile:61: magit-refs.elc] Error 1 make[1]: Leaving directory '/tmp/guix-build-magit-2.11.0.drv-0/magit-2.11.0/lisp' make: *** [Makefile:75: lisp] Error 2 phase `build' failed after 7.5 seconds --8<---------------cut here---------------end--------------->8---