From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 21 00:04:20 2022 Received: (at 30434) by debbugs.gnu.org; 21 Jul 2022 04:04:20 +0000 Received: from localhost ([127.0.0.1]:36392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oENQB-0000kw-UO for submit@debbugs.gnu.org; Thu, 21 Jul 2022 00:04:20 -0400 Received: from mail-qk1-f174.google.com ([209.85.222.174]:42974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oENQ5-0000kd-Rg for 30434@debbugs.gnu.org; Thu, 21 Jul 2022 00:04:18 -0400 Received: by mail-qk1-f174.google.com with SMTP id o1so476495qkg.9 for <30434@debbugs.gnu.org>; Wed, 20 Jul 2022 21:04:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XCCwsV5Upik5EIaSGommEmVaJtN3ZP4oSfjI1u1PkL4=; b=C/6i+SMjAQmAGXcbrs7SIn91vjzrmthdJksDMfboOGL94/fdoQCS/kKE31WcN0HsK2 N2JLfZDV1PVkUhM60j5I/dy6PQlt0kFq3MZ/z/Io9ww1rQGLqx9ZNkccXQcb7npsQ6IN a3CRszFiLAtyn5U0MKvlsBZVGOPFIPLj1YzcxL2VGLgUYfBrqOQJEmYFyX2QhwsokX1n yC69lKTObALoxXmKkeFyuZMjVV36ch9H38ZyZQTDlIQkstSm+dD5TUBB9mpMU28Z5snK nyob73A9hkmmCYmdM6YGBP99MkOGyspgsRrMNaCI1lF8otCXM2j/dUGwog06PCTytSeU AeQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XCCwsV5Upik5EIaSGommEmVaJtN3ZP4oSfjI1u1PkL4=; b=pfANFOOLa1QP6b1+mPnMRrpeZhc8cJEqtpw1Jq8wvYgw0vPXqTiCxO8rwXA5G1XGXH hcLwQawQ6dnkcqOpyXSApUO0108ViEq2imKmNbappFyY9Yi0v/wsIvP8Qop/w7LxjZ6X aYuK6v/19B2qy9WdcKi4ymFkcM+tCV/G7eOC+439eIHR38BZyawybrHiy3wCuvYwNrqY QlI2v7kAhRamD1esoNEAqMRcb9/GdlqBU7IjdU8aHYUfd2PvpcjZEf2UPZU3D3BjrwMS 4LGF8oQssmmusA/9ZR9PTp5+Q1s1F4s5vywzPIF0bObGiKy0gIljbkSIPPANQw0y9d4O JFug== X-Gm-Message-State: AJIora9mNrNwsgrqBPMW8emf4IsaVK252TCKvZqWc4jMzMjVwQ+drcjf b086Zn7dPohgYYs/M4sU1EupLzSOQVI= X-Google-Smtp-Source: AGRyM1snvssIgNWr4AhGYTm6dnb8I82f8Y63d06Ijkd+9ksA9xmIlItxIDYJvzFHRTaz94uVy8czCw== X-Received: by 2002:a05:620a:2681:b0:6b5:b60c:1e66 with SMTP id c1-20020a05620a268100b006b5b60c1e66mr26900157qkp.99.1658376247889; Wed, 20 Jul 2022 21:04:07 -0700 (PDT) Received: from hurd (dsl-10-148-92.b2b2c.ca. [72.10.148.92]) by smtp.gmail.com with ESMTPSA id k21-20020a05620a415500b006b5ed1eccc5sm817852qko.44.2022.07.20.21.04.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jul 2022 21:04:07 -0700 (PDT) From: Maxim Cournoyer To: Maxime Devos Subject: Re: bug#30434: magit =?utf-8?Q?won=E2=80=99t?= work over TRAMP References: <365299e60040c03a84cbb7770adb3f94349dd2ed.camel@telenet.be> <87lgfyl67x.fsf@elephly.net> <77826704875d168a2f7c608e146d9d5b09e7588c.camel@telenet.be> <87zghd18du.fsf_-_@gmail.com> Date: Thu, 21 Jul 2022 00:04:06 -0400 In-Reply-To: (Maxime Devos's message of "Wed, 20 Jul 2022 17:42:51 +0200") Message-ID: <87v8rrqfgp.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30434 Cc: 30434@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxime, Maxime Devos writes: [...] >> Nowadays 'magit' has a separate magit-git-executable: >> >> "The Git executable used by Magit on the local host. >> On remote machines `magit-remote-git-executable' is used instead." >> >> and magit-remote-git-executable: >> >> (defcustom magit-remote-git-executable "git" >> "The Git executable used by Magit on remote machines. >> On the local host `magit-git-executable' is used instead. >> Consider customizing `tramp-remote-path' instead of this >> option." >> >> so maybe this patch can now be reversed, such that emacs-magit >> can be used without depending on the (possibly non-existent) 'git' in >> $PATH? Needs to be verified though. > > More concretely, try "guix shell emacs emacs-magit --pure -- emacs" > followed by "M-x magit-status" in a Git checkout, it will fail due to > not finding the 'git' executable. > > So my idea is to use the new magit changes to both make the remote > TRAMP work and _also_ make local things work in a pure environment, > undoing the regression that was caused by reverting the > git->/gnu/store/.../bin/git substitution without creating new > regressions. Sounds good to me! I'll be happy to review any patch implementing it. Maxim