From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 18 06:28:33 2018 Received: (at 30311-done) by debbugs.gnu.org; 18 Feb 2018 11:28:33 +0000 Received: from localhost ([127.0.0.1]:48960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1enN8z-0005lL-GX for submit@debbugs.gnu.org; Sun, 18 Feb 2018 06:28:33 -0500 Received: from pegasus.bbbm.mdc-berlin.de ([141.80.25.20]:42970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1enN8x-0005lC-6X for 30311-done@debbugs.gnu.org; Sun, 18 Feb 2018 06:28:32 -0500 Received: from localhost (localhost [127.0.0.1]) by pegasus.bbbm.mdc-berlin.de (Postfix) with ESMTP id 150CC787ABC; Sun, 18 Feb 2018 12:28:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mdc-berlin.de; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:date:date:in-reply-to:subject:subject:from:from :user-agent:references:received:received:received:received; s= mdc; t=1518953304; x=1520767705; bh=8CwqyfyjHRl9IjiHvvepE0guFDk8 HOhOXMsZS4YaMZo=; b=L264ph4siQHJ+GqnLe3MIii0uxOe+YLQFL5sXXFvHAJc WQQPlERsW9e7dzrCW6AbUO1Yir0LzTXfec96DGOxMeDZj+zA3G6VhkO32T41veIj uYKCzUtiwfH4AK3gLbyviTxtnqkIqAOcOALdko08XcYMSvqf0p0aVW2/sqZUIj8= X-Virus-Scanned: amavisd-new at mdc-berlin.de Received: from pegasus.bbbm.mdc-berlin.de ([127.0.0.1]) by localhost (pegasus.bbbm.mdc-berlin.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rJF0hLDpYQmC; Sun, 18 Feb 2018 12:28:24 +0100 (CET) Received: from HTCAONE.mdc-berlin.net (puck.citx.mdc-berlin.de [141.80.36.101]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pegasus.bbbm.mdc-berlin.de (Postfix) with ESMTPS; Sun, 18 Feb 2018 12:28:24 +0100 (CET) Received: from SW-IT-P-CAS2.mdc-berlin.net (141.80.113.54) by HTCAONE.mdc-berlin.net (141.80.180.120) with Microsoft SMTP Server (TLS) id 14.3.361.1; Sun, 18 Feb 2018 12:28:24 +0100 Received: from localhost (141.80.113.51) by SW-IT-P-CAS2.mdc-berlin.net (141.80.113.54) with Microsoft SMTP Server id 14.3.361.1; Sun, 18 Feb 2018 12:28:23 +0100 References: <20180201003414.4a535dec@scratchpost.org> <87inbgq3wp.fsf@fastmail.com> User-agent: mu4e 1.0-alpha3; emacs 25.3.1 From: Ricardo Wurmus To: Marius Bakke Subject: Re: bug#30311: efi-less grub install fails In-Reply-To: <87inbgq3wp.fsf@fastmail.com> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Sun, 18 Feb 2018 12:28:13 +0100 Message-ID: <87371yy1te.fsf@mdc-berlin.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [141.80.113.51] X-TM-AS-Product-Ver: SMEX-11.0.0.4283-8.200.1013-23670.006 X-TM-AS-Result: No--11.097400-0.000000-31 X-TM-AS-MatchedID: 150567-703731-139010-700075-707788-701674-186035-708712-7 00752-701753-706060-703096-105700-704578-701618-708855-709185-704689-709584 -700693-702609-707909-701640-701461-705974-702050-701837-700107-148004-1481 33-20043-42000-42003-63 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30311-done Cc: Danny Milosavljevic , 30311-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Marius Bakke writes: > Danny Milosavljevic writes: > >> Hi Ricardo, >> >> On Wed, 31 Jan 2018 19:55:58 +0100 >> Ricardo Wurmus wrote: >> >>> “guix system init” fails with a configuration file that specifies >>> grub-bootloader (not grub-efi-bootloader). >>> >>> “grub-install” reports an error about “lib/grub/x86_64-efi/modinfo.sh” >>> not being available. It suggests passing “--target” or “--device”. >>> >>> Our invocation of grub-install does not include a “--target” argument. >>> Only after I edited it to pass “--target=i386-pc” did “guix system init” >>> pass. >> >> Hmm, I wonder what happened here. >> >> We've been very careful to keep grub and grub-efi separate. >> >> The entire directory lib/grub/x86_64-efi shouldn't be available in the >> "grub" package output - and I checked on master, it isn't. Good. >> >> So that leaves automatic target selection as the culprit. >> >> And indeed, there's a call to grub_install_get_default_x86_platform >> in util/grub-install.c . And that checks for availability of >> /sys/firmware/efi and if it exists, defaults to EFI. >> >> I think it's a bug in grub to do that for a grub which doesn't have EFI >> platform support. :P >> >> We could just always pass i386-pc in install-grub for i386, but then >> we lose i386-ieee1275 (which I have never heard anyone using so maybe >> not so bad). > > I agree, passing --target seems like the best workaround for this GRUB > bug. Okay, I’ve added “--target=i386-pc” to the list of arguments. Thanks for the comments. -- Ricardo