From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 02 12:26:33 2018 Received: (at 29856) by debbugs.gnu.org; 2 Jan 2018 17:26:33 +0000 Received: from localhost ([127.0.0.1]:33384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWQKf-0002d9-Ji for submit@debbugs.gnu.org; Tue, 02 Jan 2018 12:26:33 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:51656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWQKd-0002d1-HV for 29856@debbugs.gnu.org; Tue, 02 Jan 2018 12:26:32 -0500 Received: from localhost (178.113.223.176.wireless.dyn.drei.com [178.113.223.176]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 6F69733601D1; Tue, 2 Jan 2018 18:26:30 +0100 (CET) Date: Tue, 2 Jan 2018 18:26:27 +0100 From: Danny Milosavljevic To: Hartmut Goebel Subject: Re: [bug#29856] [PATCH core-updates] guix: python-build-system:, Modify ".py" files in-place. Message-ID: <20180102182627.16566e3c@scratchpost.org> In-Reply-To: <86b45cc4-f8ef-95da-87f7-397db19c424e@crazy-compilers.com> References: <86b45cc4-f8ef-95da-87f7-397db19c424e@crazy-compilers.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29856 Cc: Marius Bakke , 29856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Hartmut, thanks for the review! On Tue, 2 Jan 2018 17:13:15 +0100 Hartmut Goebel wrote: > * it kills "from __future__ import", which must be the first import > statement (or even the first statement after any doc-string) to work. ... oops. > Thus I suggest aiming to implement the solution discussed in that thread > (see esp. > . I like that approach. Nice... > Beside of this, the patch suffers from some more issues. Sorry to say :-( > > * When converting PYTHONPATH into a list of python strings, these need > to be quoted properly. I agree. > * The description (commit-message) of the patch is much to terse. It > should describe the the reason and implications. Esp. it should > describe the case this is fixing. Sure.