From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 19 10:32:48 2017 Received: (at 29610) by debbugs.gnu.org; 19 Dec 2017 15:32:48 +0000 Received: from localhost ([127.0.0.1]:42455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRJsu-0005lj-8G for submit@debbugs.gnu.org; Tue, 19 Dec 2017 10:32:48 -0500 Received: from mout01.posteo.de ([185.67.36.65]:49934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRJsr-0005lS-MG for 29610@debbugs.gnu.org; Tue, 19 Dec 2017 10:32:47 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 27CD921040 for <29610@debbugs.gnu.org>; Tue, 19 Dec 2017 16:32:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1513697559; bh=G6m7H0RrfWNtIYx9eFCXb29EFPFT/69Ua2I7q4ley38=; h=From:To:Cc:Subject:Date:From; b=kzf+cfaQ/nEY3WXTKKxb18+4YS83oFrGu92+YXVg8+U+T8XostkseIfjKBzV3nd01 idVP+TJu/HWf5vBhbCxmZUu57eTTt6fwfGc6fevY6JXi95riOwUM29giHxROGMGJVt c7NWldkVbAGdCEje4iLibzzvVo7s1Oznwc6Ar+ouq+B0jdwkV7nKdYDTlfFb6hhGGB aOWUdxaGy6ooRjKOQ01YlKUYE4c2daNP5aWTm6G5FZVVSr9qD0xB0KYScNBU+f5g6D /Ce3Zvt/wp7XAcAarbgDLBQag2VjIN9/KVwLIsmjNLqhA+HdetlrCgw1eVjzRJ19us C2Pt/2S8DxVoQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 3z1MNN5ps3z9rxW; Tue, 19 Dec 2017 16:32:36 +0100 (CET) From: Kei Kebreau To: nee Subject: Re: [bug#29610] [PATCH] gnu: games: Add quakespasm. References: <9684edc1-5c32-4fab-fbfa-a77160eab0fb@cock.li> <87o9mwyo5b.fsf@posteo.net> <3f4e7ae4-0ab6-7d89-71c4-9d3dd54d2e00@cock.li> Date: Tue, 19 Dec 2017 10:32:34 -0500 In-Reply-To: <3f4e7ae4-0ab6-7d89-71c4-9d3dd54d2e00@cock.li> (nee@cock.li's message of "Tue, 19 Dec 2017 02:27:49 +0100") Message-ID: <87fu86zqb1.fsf@posteo.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29610 Cc: 29610@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable nee writes: > Am 18.12.2017 um 17:52 schrieb Kei Kebreau: >> A few things: >> * Please end the "fix-makefile-paths" phase with a #t. >> * It turns out that the license is actually gpl2+. >> * The description's indentation seems a bit early and weird. That is, we >> can have up to 80 characters per line in our description, and some of >> the description can be adjusted accordingly. >>=20 > > GJ spotting all of this. Here is the updated patch. One more nitpick: our commit messages tend not to include the name of the file being added to, so they look like gnu: Add quakespasm. as opposed to gnu: games: Add quakespasm. I've fixed that bit, though, and this patch is otherwise great! I've pushed this to master. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlo5MRIACgkQ5qXuPBlG eg1x9w//Tbgdya1RwDNOs4tVD1hn8hzVvdur2sDv8TmrKMfqj2vKq1vYYkmauipd o5Tmx7fDkTsHVV/lEubHSsMuh0zgWtQyVeS2U91KX0APRj33Gx+ePi0RIi0v7ukE s/PzJr2Zgxoj8UcU9wZ4WQH1rDQqFDg1aeiDGopEso7xqINZnagjtCRvFLaGQXa9 xi1mh8mBZDAll14GS/e0ZOl52Py+REcFx95xP5r8tyZSg4vTmi4mr+0xHxTWSQnF w5O+NvrPcVP1z2JpBjzjy29nxQLhHACMwxXTeAGB876BsoCVrWX+meMqD+dQ0spv GUwRZsZrNT43JN/flt1+KdLwTbvZK6ifvBydk19TSVaTaaqcEtLT4XlwUgx/Aj11 lpggxsTaJvgMYPv9DMiiqUdQcFeu5S/qKRSOjD1Xt4X3wMhcBcOiq81GC23HB0ko bs9iNDgk/E3MX9vyAM3e+JKubpVP83bTaBlR7bs+FVpaGaLJ0vGB3eqYIMLmmcn4 0sKxHXf1f2qeALhhu04n8mNHZOYFSgPag+MK209tyFMIQzujYA+egZEwpc22LH7g B86nn7y8srkMO4Dzq/9fsl1HzyPcjnzRS7CtpyyjvjqjWc8JFr92M0DIn1zHYpik CIj6j/7zQOMmPQpUYjV02CYwghLGBlY72Zq9fn5KTJk74PHgkJg= =JdPP -----END PGP SIGNATURE----- --=-=-=--